Skip to content

Conversation

@layershifter
Copy link
Member

@layershifter layershifter commented Jul 14, 2021

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

The same as #18847, I overlooked it in #18256 when was merging conflicts. Currently it causes build failures for master as runs a task that should be evaluated only for PR:

image

@layershifter layershifter requested a review from a team as a code owner July 14, 2021 12:36
@layershifter layershifter changed the title chore: fix "variables.isPR" condition chore: fix "variables.isPR" condition in azure-pipelines.bundlesize.yml Jul 14, 2021
@layershifter layershifter enabled auto-merge (squash) July 14, 2021 12:39
@size-auditor
Copy link

size-auditor bot commented Jul 14, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ea65e263e4e1e18cb570d28ef328b2561b070644 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-divider
Divider
15.889 kB
5.747 kB
react-image
Image
10.642 kB
4.264 kB
react-make-styles
makeStaticStyles (runtime)
7.59 kB
3.321 kB
react-make-styles
makeStyles + mergeClasses (runtime)
22.135 kB
8.356 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.557 kB
1.202 kB
react-menu
Menu - Default
113.348 kB
34.242 kB
react-menu
Menu - Selectable
115.36 kB
34.501 kB
react-popover
Popover
140.938 kB
41.968 kB
react-theme
Teams: all themes
31.935 kB
6.49 kB
react-theme
Teams: Light theme
19.527 kB
5.504 kB
🤖 This report was generated against ea65e263e4e1e18cb570d28ef328b2561b070644

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0a4dc25:

Sandbox Source
Fluent UI Button Configuration
codesandbox-react-template Configuration
codesandbox-react-northstar-template Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 797 778 5000
BaseButton mount 892 881 5000
Breadcrumb mount 2585 2606 1000
ButtonNext mount 512 523 5000
Checkbox mount 1491 1514 5000
CheckboxBase mount 1292 1268 5000
ChoiceGroup mount 4695 4585 5000
ComboBox mount 957 999 1000
CommandBar mount 9999 9964 1000
ContextualMenu mount 6085 6191 1000
DefaultButton mount 1102 1103 5000
DetailsRow mount 3622 3684 5000
DetailsRowFast mount 3650 3640 5000
DetailsRowNoStyles mount 3430 3433 5000
Dialog mount 2149 2136 1000
DocumentCardTitle mount 135 136 1000
Dropdown mount 3140 3170 5000
FluentProviderNext mount 7174 7127 5000
FocusTrapZone mount 1756 1761 5000
FocusZone mount 1770 1804 5000
IconButton mount 1695 1680 5000
Label mount 334 319 5000
Layer mount 1761 1735 5000
Link mount 464 444 5000
MakeStyles mount 1804 1805 50000
MenuButton mount 1411 1402 5000
MessageBar mount 1993 1984 5000
Nav mount 3206 3194 1000
OverflowSet mount 1016 1020 5000
Panel mount 1363 2041 1000
Persona mount 813 798 1000
Pivot mount 1375 1363 1000
PrimaryButton mount 1278 1281 5000
Rating mount 7465 7458 5000
SearchBox mount 1289 1299 5000
Shimmer mount 2445 2534 5000
Slider mount 1935 1914 5000
SpinButton mount 4912 4831 5000
Spinner mount 421 429 5000
SplitButton mount 3108 3110 5000
Stack mount 478 500 5000
StackWithIntrinsicChildren mount 1459 1496 5000
StackWithTextChildren mount 4386 4399 5000
SwatchColorPicker mount 10012 10001 5000
Tabs mount 1369 1373 1000
TagPicker mount 2345 2308 5000
TeachingBubble mount 11758 11605 5000
Text mount 418 409 5000
TextField mount 1339 1376 5000
ThemeProvider mount 1172 1156 5000
ThemeProvider virtual-rerender 611 586 5000
Toggle mount 766 805 5000
buttonNative mount 109 115 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
BoxMinimalPerf.default 353 327 1.08:1
AttachmentMinimalPerf.default 156 146 1.07:1
ChatMinimalPerf.default 639 611 1.05:1
ChatDuplicateMessagesPerf.default 294 283 1.04:1
PortalMinimalPerf.default 176 170 1.04:1
RadioGroupMinimalPerf.default 443 428 1.04:1
AttachmentSlotsPerf.default 1047 1015 1.03:1
GridMinimalPerf.default 329 319 1.03:1
ImageMinimalPerf.default 359 348 1.03:1
ReactionMinimalPerf.default 365 356 1.03:1
IconMinimalPerf.default 599 581 1.03:1
ButtonSlotsPerf.default 538 528 1.02:1
CheckboxMinimalPerf.default 2686 2646 1.02:1
DialogMinimalPerf.default 733 720 1.02:1
DividerMinimalPerf.default 339 332 1.02:1
DropdownManyItemsPerf.default 660 647 1.02:1
ItemLayoutMinimalPerf.default 1176 1151 1.02:1
ListNestedPerf.default 536 524 1.02:1
LoaderMinimalPerf.default 693 678 1.02:1
PopupMinimalPerf.default 587 573 1.02:1
RefMinimalPerf.default 236 231 1.02:1
TableMinimalPerf.default 400 391 1.02:1
TooltipMinimalPerf.default 982 961 1.02:1
AccordionMinimalPerf.default 153 151 1.01:1
ButtonOverridesMissPerf.default 1654 1638 1.01:1
CarouselMinimalPerf.default 444 441 1.01:1
EmbedMinimalPerf.default 4009 3987 1.01:1
InputMinimalPerf.default 1219 1206 1.01:1
ListMinimalPerf.default 498 495 1.01:1
MenuMinimalPerf.default 833 825 1.01:1
ProviderMinimalPerf.default 949 935 1.01:1
SliderMinimalPerf.default 1534 1519 1.01:1
TableManyItemsPerf.default 1850 1837 1.01:1
TextMinimalPerf.default 323 321 1.01:1
CustomToolbarPrototype.default 3729 3704 1.01:1
TreeMinimalPerf.default 772 766 1.01:1
AnimationMinimalPerf.default 402 400 1:1
ButtonMinimalPerf.default 155 155 1:1
DatepickerMinimalPerf.default 5248 5223 1:1
DropdownMinimalPerf.default 3043 3046 1:1
HeaderMinimalPerf.default 353 353 1:1
MenuButtonMinimalPerf.default 1586 1593 1:1
RosterPerf.default 1138 1136 1:1
SplitButtonMinimalPerf.default 3686 3671 1:1
StatusMinimalPerf.default 652 653 1:1
AlertMinimalPerf.default 271 275 0.99:1
FlexMinimalPerf.default 272 276 0.99:1
HeaderSlotsPerf.default 709 713 0.99:1
LayoutMinimalPerf.default 355 359 0.99:1
ProviderMergeThemesPerf.default 1619 1636 0.99:1
ToolbarMinimalPerf.default 903 910 0.99:1
TreeWith60ListItems.default 164 165 0.99:1
CardMinimalPerf.default 526 538 0.98:1
TextAreaMinimalPerf.default 466 475 0.98:1
ChatWithPopoverPerf.default 338 350 0.97:1
FormMinimalPerf.default 375 387 0.97:1
SegmentMinimalPerf.default 326 336 0.97:1
LabelMinimalPerf.default 361 375 0.96:1
ListCommonPerf.default 581 603 0.96:1
ListWith60ListItems.default 622 650 0.96:1
AvatarMinimalPerf.default 182 191 0.95:1
SkeletonMinimalPerf.default 333 349 0.95:1
VideoMinimalPerf.default 582 615 0.95:1

@layershifter layershifter merged commit 67cb7ff into master Jul 14, 2021
@layershifter layershifter deleted the chore/fix-task branch July 14, 2021 13:16
PeterDraex pushed a commit to PeterDraex/fluentui that referenced this pull request Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants