(web-components) Fixed ability to set palette base color on DSP #18958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bheston
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
chrisdholt
approved these changes
Jul 15, 2021
|
Thank you @bheston! |
📊 Bundle size report🤖 This report was generated against 6d75fc293e876c681f94aabb89000cabd631942d |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 581e3ac:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6d75fc293e876c681f94aabb89000cabd631942d (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 762 | 781 | 5000 | |
| BaseButton | mount | 872 | 857 | 5000 | |
| Breadcrumb | mount | 2483 | 2520 | 1000 | |
| ButtonNext | mount | 509 | 489 | 5000 | |
| Checkbox | mount | 1453 | 1431 | 5000 | |
| CheckboxBase | mount | 1201 | 1204 | 5000 | |
| ChoiceGroup | mount | 4488 | 4463 | 5000 | |
| ComboBox | mount | 921 | 931 | 1000 | |
| CommandBar | mount | 9687 | 9655 | 1000 | |
| ContextualMenu | mount | 5902 | 5906 | 1000 | |
| DefaultButton | mount | 1090 | 1081 | 5000 | |
| DetailsRow | mount | 3539 | 3437 | 5000 | |
| DetailsRowFast | mount | 3502 | 3521 | 5000 | |
| DetailsRowNoStyles | mount | 3342 | 3322 | 5000 | |
| Dialog | mount | 2075 | 2035 | 1000 | |
| DocumentCardTitle | mount | 137 | 137 | 1000 | |
| Dropdown | mount | 3081 | 3066 | 5000 | |
| FluentProviderNext | mount | 6889 | 6929 | 5000 | |
| FocusTrapZone | mount | 1725 | 1690 | 5000 | |
| FocusZone | mount | 1768 | 1743 | 5000 | |
| IconButton | mount | 1657 | 1674 | 5000 | |
| Label | mount | 320 | 328 | 5000 | |
| Layer | mount | 1740 | 1720 | 5000 | |
| Link | mount | 452 | 449 | 5000 | |
| MakeStyles | mount | 1772 | 1769 | 50000 | |
| MenuButton | mount | 1400 | 1419 | 5000 | |
| MessageBar | mount | 1940 | 1952 | 5000 | |
| Nav | mount | 3115 | 3110 | 1000 | |
| OverflowSet | mount | 1000 | 963 | 5000 | |
| Panel | mount | 2011 | 1950 | 1000 | |
| Persona | mount | 787 | 777 | 1000 | |
| Pivot | mount | 1327 | 1326 | 1000 | |
| PrimaryButton | mount | 1189 | 1197 | 5000 | |
| Rating | mount | 7233 | 7251 | 5000 | |
| SearchBox | mount | 1233 | 1245 | 5000 | |
| Shimmer | mount | 2426 | 2369 | 5000 | |
| Slider | mount | 1838 | 1855 | 5000 | |
| SpinButton | mount | 4735 | 4682 | 5000 | |
| Spinner | mount | 413 | 397 | 5000 | |
| SplitButton | mount | 3020 | 3042 | 5000 | |
| Stack | mount | 489 | 464 | 5000 | |
| StackWithIntrinsicChildren | mount | 1421 | 1436 | 5000 | |
| StackWithTextChildren | mount | 4250 | 4230 | 5000 | |
| SwatchColorPicker | mount | 9818 | 9690 | 5000 | |
| Tabs | mount | 1342 | 1307 | 1000 | |
| TagPicker | mount | 2287 | 2345 | 5000 | |
| TeachingBubble | mount | 11377 | 11264 | 5000 | |
| Text | mount | 394 | 392 | 5000 | |
| TextField | mount | 1317 | 1294 | 5000 | |
| ThemeProvider | mount | 1138 | 1119 | 5000 | |
| ThemeProvider | virtual-rerender | 576 | 584 | 5000 | |
| Toggle | mount | 773 | 788 | 5000 | |
| buttonNative | mount | 108 | 111 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 197 | 184 | 1.07:1 |
| ButtonSlotsPerf.default | 526 | 491 | 1.07:1 |
| FormMinimalPerf.default | 388 | 363 | 1.07:1 |
| PortalMinimalPerf.default | 170 | 159 | 1.07:1 |
| TreeWith60ListItems.default | 169 | 160 | 1.06:1 |
| AlertMinimalPerf.default | 263 | 250 | 1.05:1 |
| HeaderMinimalPerf.default | 344 | 327 | 1.05:1 |
| SkeletonMinimalPerf.default | 343 | 326 | 1.05:1 |
| ChatDuplicateMessagesPerf.default | 273 | 263 | 1.04:1 |
| ProviderMergeThemesPerf.default | 1648 | 1587 | 1.04:1 |
| VideoMinimalPerf.default | 585 | 560 | 1.04:1 |
| DropdownManyItemsPerf.default | 646 | 630 | 1.03:1 |
| FlexMinimalPerf.default | 272 | 263 | 1.03:1 |
| BoxMinimalPerf.default | 324 | 318 | 1.02:1 |
| DialogMinimalPerf.default | 720 | 708 | 1.02:1 |
| ImageMinimalPerf.default | 362 | 355 | 1.02:1 |
| LayoutMinimalPerf.default | 338 | 332 | 1.02:1 |
| RefMinimalPerf.default | 224 | 220 | 1.02:1 |
| SegmentMinimalPerf.default | 325 | 319 | 1.02:1 |
| SplitButtonMinimalPerf.default | 3640 | 3586 | 1.02:1 |
| IconMinimalPerf.default | 600 | 590 | 1.02:1 |
| TreeMinimalPerf.default | 754 | 738 | 1.02:1 |
| AnimationMinimalPerf.default | 389 | 387 | 1.01:1 |
| ButtonMinimalPerf.default | 161 | 159 | 1.01:1 |
| CardMinimalPerf.default | 503 | 497 | 1.01:1 |
| DropdownMinimalPerf.default | 2959 | 2933 | 1.01:1 |
| HeaderSlotsPerf.default | 721 | 714 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1146 | 1140 | 1.01:1 |
| ListCommonPerf.default | 585 | 577 | 1.01:1 |
| ListMinimalPerf.default | 480 | 477 | 1.01:1 |
| ListNestedPerf.default | 507 | 503 | 1.01:1 |
| ListWith60ListItems.default | 604 | 600 | 1.01:1 |
| LoaderMinimalPerf.default | 647 | 640 | 1.01:1 |
| RadioGroupMinimalPerf.default | 429 | 425 | 1.01:1 |
| ReactionMinimalPerf.default | 364 | 359 | 1.01:1 |
| TableManyItemsPerf.default | 1791 | 1768 | 1.01:1 |
| AttachmentSlotsPerf.default | 1017 | 1022 | 1:1 |
| ButtonOverridesMissPerf.default | 1598 | 1599 | 1:1 |
| CheckboxMinimalPerf.default | 2575 | 2578 | 1:1 |
| EmbedMinimalPerf.default | 3938 | 3923 | 1:1 |
| TableMinimalPerf.default | 374 | 375 | 1:1 |
| TextAreaMinimalPerf.default | 457 | 457 | 1:1 |
| CustomToolbarPrototype.default | 3624 | 3616 | 1:1 |
| CarouselMinimalPerf.default | 421 | 426 | 0.99:1 |
| ChatWithPopoverPerf.default | 325 | 327 | 0.99:1 |
| DatepickerMinimalPerf.default | 5176 | 5234 | 0.99:1 |
| GridMinimalPerf.default | 315 | 317 | 0.99:1 |
| InputMinimalPerf.default | 1195 | 1202 | 0.99:1 |
| LabelMinimalPerf.default | 359 | 363 | 0.99:1 |
| MenuMinimalPerf.default | 780 | 784 | 0.99:1 |
| MenuButtonMinimalPerf.default | 1520 | 1535 | 0.99:1 |
| ProviderMinimalPerf.default | 919 | 925 | 0.99:1 |
| SliderMinimalPerf.default | 1498 | 1506 | 0.99:1 |
| StatusMinimalPerf.default | 640 | 649 | 0.99:1 |
| ToolbarMinimalPerf.default | 863 | 875 | 0.99:1 |
| TooltipMinimalPerf.default | 945 | 957 | 0.99:1 |
| ChatMinimalPerf.default | 614 | 624 | 0.98:1 |
| TextMinimalPerf.default | 320 | 328 | 0.98:1 |
| PopupMinimalPerf.default | 556 | 571 | 0.97:1 |
| AttachmentMinimalPerf.default | 138 | 144 | 0.96:1 |
| DividerMinimalPerf.default | 323 | 335 | 0.96:1 |
| RosterPerf.default | 1094 | 1135 | 0.96:1 |
| AccordionMinimalPerf.default | 135 | 145 | 0.93:1 |
|
🎉 Handy links: |
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
…osoft#18958) * Fixed ability to set palette base color on DSP * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
Attribute converter seemed to be getting reset without
fromViewmode.Added a test scenario on
CardStorybook.Focus areas to test
(optional)