text-field: start/end display flex #18969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 499acbd08332c14de0a26fd2f66365a82148f9fc |
|
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dbf81c2:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 499acbd08332c14de0a26fd2f66365a82148f9fc (build) |
fredrikhr
requested review from
chrisdholt,
EisenbergEffect and
nicholasrice
as code owners
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 814 | 791 | 5000 | |
| BaseButton | mount | 890 | 888 | 5000 | |
| Breadcrumb | mount | 2584 | 2630 | 1000 | |
| ButtonNext | mount | 521 | 527 | 5000 | |
| Checkbox | mount | 1490 | 1485 | 5000 | |
| CheckboxBase | mount | 1247 | 1256 | 5000 | |
| ChoiceGroup | mount | 4682 | 4661 | 5000 | |
| ComboBox | mount | 941 | 982 | 1000 | |
| CommandBar | mount | 10092 | 10020 | 1000 | |
| ContextualMenu | mount | 6181 | 6271 | 1000 | |
| DefaultButton | mount | 1125 | 1085 | 5000 | |
| DetailsRow | mount | 3691 | 3651 | 5000 | |
| DetailsRowFast | mount | 3690 | 3695 | 5000 | |
| DetailsRowNoStyles | mount | 3419 | 3460 | 5000 | |
| Dialog | mount | 2154 | 2085 | 1000 | |
| DocumentCardTitle | mount | 155 | 154 | 1000 | |
| Dropdown | mount | 3174 | 3169 | 5000 | |
| FluentProviderNext | mount | 7124 | 7194 | 5000 | |
| FocusTrapZone | mount | 1742 | 1729 | 5000 | |
| FocusZone | mount | 1754 | 1756 | 5000 | |
| IconButton | mount | 1720 | 1713 | 5000 | |
| Label | mount | 324 | 327 | 5000 | |
| Layer | mount | 1771 | 1704 | 5000 | |
| Link | mount | 453 | 453 | 5000 | |
| MakeStyles | mount | 1815 | 1766 | 50000 | |
| MenuButton | mount | 1400 | 1444 | 5000 | |
| MessageBar | mount | 2004 | 1988 | 5000 | |
| Nav | mount | 3211 | 3216 | 1000 | |
| OverflowSet | mount | 1029 | 1038 | 5000 | |
| Panel | mount | 2057 | 2041 | 1000 | |
| Persona | mount | 795 | 816 | 1000 | |
| Pivot | mount | 1395 | 1370 | 1000 | |
| PrimaryButton | mount | 1236 | 1262 | 5000 | |
| Rating | mount | 7403 | 7434 | 5000 | |
| SearchBox | mount | 1251 | 1264 | 5000 | |
| Shimmer | mount | 2457 | 2395 | 5000 | |
| Slider | mount | 1898 | 1936 | 5000 | |
| SpinButton | mount | 4851 | 4868 | 5000 | |
| Spinner | mount | 415 | 411 | 5000 | |
| SplitButton | mount | 3076 | 3058 | 5000 | |
| Stack | mount | 496 | 491 | 5000 | |
| StackWithIntrinsicChildren | mount | 1467 | 1493 | 5000 | |
| StackWithTextChildren | mount | 4380 | 4380 | 5000 | |
| SwatchColorPicker | mount | 9902 | 9891 | 5000 | |
| Tabs | mount | 1364 | 1377 | 1000 | |
| TagPicker | mount | 2386 | 2329 | 5000 | |
| TeachingBubble | mount | 11564 | 11568 | 5000 | |
| Text | mount | 412 | 412 | 5000 | |
| TextField | mount | 1336 | 1346 | 5000 | |
| ThemeProvider | mount | 1167 | 1179 | 5000 | |
| ThemeProvider | virtual-rerender | 601 | 596 | 5000 | |
| Toggle | mount | 796 | 794 | 5000 | |
| buttonNative | mount | 115 | 105 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AccordionMinimalPerf.default | 151 | 140 | 1.08:1 |
| CarouselMinimalPerf.default | 462 | 435 | 1.06:1 |
| DividerMinimalPerf.default | 362 | 343 | 1.06:1 |
| SegmentMinimalPerf.default | 346 | 326 | 1.06:1 |
| ChatWithPopoverPerf.default | 345 | 328 | 1.05:1 |
| LayoutMinimalPerf.default | 365 | 351 | 1.04:1 |
| RadioGroupMinimalPerf.default | 434 | 416 | 1.04:1 |
| TableMinimalPerf.default | 393 | 379 | 1.04:1 |
| AttachmentMinimalPerf.default | 154 | 150 | 1.03:1 |
| ListCommonPerf.default | 626 | 607 | 1.03:1 |
| ListNestedPerf.default | 552 | 535 | 1.03:1 |
| TextAreaMinimalPerf.default | 481 | 468 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 283 | 277 | 1.02:1 |
| FormMinimalPerf.default | 396 | 389 | 1.02:1 |
| LabelMinimalPerf.default | 377 | 370 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1612 | 1579 | 1.02:1 |
| SkeletonMinimalPerf.default | 348 | 340 | 1.02:1 |
| StatusMinimalPerf.default | 661 | 648 | 1.02:1 |
| TableManyItemsPerf.default | 1862 | 1833 | 1.02:1 |
| AnimationMinimalPerf.default | 399 | 395 | 1.01:1 |
| BoxMinimalPerf.default | 331 | 327 | 1.01:1 |
| ButtonOverridesMissPerf.default | 1652 | 1638 | 1.01:1 |
| CheckboxMinimalPerf.default | 2694 | 2677 | 1.01:1 |
| DatepickerMinimalPerf.default | 5290 | 5258 | 1.01:1 |
| DialogMinimalPerf.default | 748 | 740 | 1.01:1 |
| HeaderSlotsPerf.default | 739 | 733 | 1.01:1 |
| ItemLayoutMinimalPerf.default | 1193 | 1186 | 1.01:1 |
| ListMinimalPerf.default | 507 | 503 | 1.01:1 |
| MenuMinimalPerf.default | 824 | 812 | 1.01:1 |
| RefMinimalPerf.default | 233 | 231 | 1.01:1 |
| SplitButtonMinimalPerf.default | 3673 | 3647 | 1.01:1 |
| TextMinimalPerf.default | 336 | 333 | 1.01:1 |
| CustomToolbarPrototype.default | 3743 | 3689 | 1.01:1 |
| ToolbarMinimalPerf.default | 905 | 898 | 1.01:1 |
| TooltipMinimalPerf.default | 972 | 965 | 1.01:1 |
| AttachmentSlotsPerf.default | 1043 | 1040 | 1:1 |
| ChatMinimalPerf.default | 621 | 622 | 1:1 |
| EmbedMinimalPerf.default | 4036 | 4055 | 1:1 |
| FlexMinimalPerf.default | 284 | 285 | 1:1 |
| HeaderMinimalPerf.default | 346 | 346 | 1:1 |
| InputMinimalPerf.default | 1235 | 1235 | 1:1 |
| ListWith60ListItems.default | 627 | 629 | 1:1 |
| PopupMinimalPerf.default | 579 | 579 | 1:1 |
| ProviderMinimalPerf.default | 934 | 937 | 1:1 |
| DropdownMinimalPerf.default | 3024 | 3043 | 0.99:1 |
| GridMinimalPerf.default | 323 | 327 | 0.99:1 |
| LoaderMinimalPerf.default | 666 | 674 | 0.99:1 |
| SliderMinimalPerf.default | 1504 | 1524 | 0.99:1 |
| TreeMinimalPerf.default | 761 | 770 | 0.99:1 |
| AvatarMinimalPerf.default | 186 | 190 | 0.98:1 |
| ButtonMinimalPerf.default | 157 | 161 | 0.98:1 |
| ButtonSlotsPerf.default | 532 | 542 | 0.98:1 |
| CardMinimalPerf.default | 530 | 539 | 0.98:1 |
| DropdownManyItemsPerf.default | 643 | 657 | 0.98:1 |
| PortalMinimalPerf.default | 172 | 175 | 0.98:1 |
| ReactionMinimalPerf.default | 355 | 362 | 0.98:1 |
| IconMinimalPerf.default | 589 | 599 | 0.98:1 |
| TreeWith60ListItems.default | 166 | 169 | 0.98:1 |
| VideoMinimalPerf.default | 592 | 603 | 0.98:1 |
| ImageMinimalPerf.default | 346 | 357 | 0.97:1 |
| ProviderMergeThemesPerf.default | 1601 | 1653 | 0.97:1 |
| RosterPerf.default | 1113 | 1164 | 0.96:1 |
| AlertMinimalPerf.default | 258 | 273 | 0.95:1 |
chrisdholt
requested changes
Jul 16, 2021
packages/web-components/src/text-field/fixtures/text-field.html
Outdated
Show resolved
Hide resolved
fredrikhr
force-pushed
the
web-components-textfield-start-end-flex
branch
from
fbd74aa
to
dbf81c2
Compare
|
@chrisdholt I reset the branch to dbf81c2. I'll open a new issue for the icons. Following the discussion we had yesterday on Discord I think https://github.com/microsoft/fluentui-system-icons will be a more correct place to file that issue? And if these icons are published to a CDN with stylesheets in the future we should re-introduce the test cases as I think there is value to testing |
chrisdholt
approved these changes
Jul 21, 2021
|
thanks for this fix @fredrikhr! |
|
🎉 Handy links: |
PeterDraex
pushed a commit
to PeterDraex/fluentui
that referenced
this pull request
Aug 6, 2021
* text-field: start/end display flex ref.: microsoft/fast@ff37847 * Change files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR brings fluentui web-components to parity with the bugfix accepted in microsoft/fast#4938
Pull request checklist
$ yarn changeDescription of changes
startandendslot influent-text-fieldget thedisplay: flexrule.Add Fabric Core CSS to storybook for testing components with non-svg icons.Focus areas to test
fluent-text-field