Skip to content

Conversation

@theerebuss
Copy link
Contributor

Pull request checklist

- Addresses an existing issue: Fixes #0000
- Include a change request file using $ yarn change

Description of changes

This PR addresses some housekeeping needed for the release of react-text.
Changes done:

  • Remove duplicate Storybook story
  • Add missing bundle-size command to package.json
  • Remove typographyStyles from being exported

@fabricteam
Copy link
Collaborator

fabricteam commented Jul 23, 2021

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-text
Text - Default
0 B
0 B
30.03 kB
10.913 kB
🆕 New entry
react-text
Text - Wrappers
0 B
0 B
32.35 kB
11.138 kB
🆕 New entry

🤖 This report was generated against 17c38c14b8b57d0150341cb914fb78c8e295443c

@size-auditor
Copy link

size-auditor bot commented Jul 23, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 17c38c14b8b57d0150341cb914fb78c8e295443c (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5156bf4:

Sandbox Source
Fluent UI React Starter Configuration

@theerebuss theerebuss mentioned this pull request Jul 23, 2021
44 tasks
@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
Panel mount 2057 1338 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 805 845 5000
BaseButton mount 944 972 5000
Breadcrumb mount 2532 2561 1000
ButtonNext mount 453 424 5000
Checkbox mount 1538 1632 5000
CheckboxBase mount 1353 1357 5000
ChoiceGroup mount 4934 4916 5000
ComboBox mount 971 974 1000
CommandBar mount 10303 9982 1000
ContextualMenu mount 6144 6573 1000
DefaultButton mount 1164 1188 5000
DetailsRow mount 4016 3817 5000
DetailsRowFast mount 3844 3843 5000
DetailsRowNoStyles mount 3684 3578 5000
Dialog mount 2288 2271 1000
DocumentCardTitle mount 142 167 1000
Dropdown mount 3384 3369 5000
FluentProviderNext mount 7025 6982 5000
FocusTrapZone mount 1800 1767 5000
FocusZone mount 1847 1835 5000
IconButton mount 1817 1848 5000
Label mount 331 335 5000
Layer mount 1881 1876 5000
Link mount 490 464 5000
MakeStyles mount 1886 1784 50000
MenuButton mount 1683 1641 5000
MessageBar mount 2051 2171 5000
Nav mount 3291 3768 1000
OverflowSet mount 1012 1089 5000
Panel mount 2057 1338 1000 Possible regression
Persona mount 839 871 1000
Pivot mount 1390 1409 1000
PrimaryButton mount 1481 1356 5000
Rating mount 8359 8577 5000
SearchBox mount 1394 1367 5000
Shimmer mount 2835 2633 5000
Slider mount 1946 2024 5000
SpinButton mount 5013 5087 5000
Spinner mount 410 395 5000
SplitButton mount 3232 3331 5000
Stack mount 533 512 5000
StackWithIntrinsicChildren mount 1708 1730 5000
StackWithTextChildren mount 4851 5031 5000
SwatchColorPicker mount 10767 10856 5000
Tabs mount 1539 1512 1000
TagPicker mount 2662 2681 5000
TeachingBubble mount 12361 12340 5000
Text mount 456 452 5000
TextField mount 1462 1457 5000
ThemeProvider mount 1188 1215 5000
ThemeProvider virtual-rerender 597 611 5000
Toggle mount 845 825 5000
buttonNative mount 127 120 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ListMinimalPerf.default 604 520 1.16:1
AttachmentMinimalPerf.default 184 163 1.13:1
IconMinimalPerf.default 710 635 1.12:1
ImageMinimalPerf.default 421 384 1.1:1
PortalMinimalPerf.default 174 158 1.1:1
ChatWithPopoverPerf.default 392 359 1.09:1
SkeletonMinimalPerf.default 384 354 1.08:1
ButtonSlotsPerf.default 596 557 1.07:1
RefMinimalPerf.default 237 221 1.07:1
BoxMinimalPerf.default 381 359 1.06:1
DividerMinimalPerf.default 387 370 1.05:1
SegmentMinimalPerf.default 372 353 1.05:1
CardMinimalPerf.default 579 558 1.04:1
DropdownManyItemsPerf.default 761 729 1.04:1
ListCommonPerf.default 720 695 1.04:1
ListWith60ListItems.default 675 652 1.04:1
PopupMinimalPerf.default 599 576 1.04:1
RadioGroupMinimalPerf.default 483 463 1.04:1
AlertMinimalPerf.default 306 298 1.03:1
CarouselMinimalPerf.default 476 461 1.03:1
InputMinimalPerf.default 1316 1278 1.03:1
ItemLayoutMinimalPerf.default 1297 1265 1.03:1
MenuMinimalPerf.default 887 859 1.03:1
TableMinimalPerf.default 432 418 1.03:1
TreeMinimalPerf.default 822 795 1.03:1
AttachmentSlotsPerf.default 1128 1103 1.02:1
FlexMinimalPerf.default 290 285 1.02:1
ListNestedPerf.default 585 576 1.02:1
StatusMinimalPerf.default 780 767 1.02:1
ChatMinimalPerf.default 680 672 1.01:1
DialogMinimalPerf.default 805 798 1.01:1
DropdownMinimalPerf.default 3136 3113 1.01:1
MenuButtonMinimalPerf.default 1711 1692 1.01:1
ProviderMergeThemesPerf.default 1581 1568 1.01:1
TableManyItemsPerf.default 2012 1991 1.01:1
TextMinimalPerf.default 363 359 1.01:1
ChatDuplicateMessagesPerf.default 292 292 1:1
EmbedMinimalPerf.default 4243 4245 1:1
GridMinimalPerf.default 359 359 1:1
SliderMinimalPerf.default 1597 1594 1:1
TextAreaMinimalPerf.default 550 548 1:1
ToolbarMinimalPerf.default 974 972 1:1
CheckboxMinimalPerf.default 2732 2763 0.99:1
FormMinimalPerf.default 463 467 0.99:1
HeaderSlotsPerf.default 789 799 0.99:1
ReactionMinimalPerf.default 395 397 0.99:1
VideoMinimalPerf.default 635 642 0.99:1
ButtonOverridesMissPerf.default 1743 1770 0.98:1
LoaderMinimalPerf.default 691 703 0.98:1
CustomToolbarPrototype.default 3869 3954 0.98:1
AnimationMinimalPerf.default 422 436 0.97:1
HeaderMinimalPerf.default 372 384 0.97:1
LayoutMinimalPerf.default 393 407 0.97:1
SplitButtonMinimalPerf.default 3956 4069 0.97:1
DatepickerMinimalPerf.default 5451 5690 0.96:1
TooltipMinimalPerf.default 1027 1065 0.96:1
ButtonMinimalPerf.default 176 185 0.95:1
RosterPerf.default 1227 1292 0.95:1
ProviderMinimalPerf.default 997 1056 0.94:1
AvatarMinimalPerf.default 193 208 0.93:1
LabelMinimalPerf.default 426 461 0.92:1
TreeWith60ListItems.default 161 177 0.91:1
AccordionMinimalPerf.default 158 176 0.9:1

@theerebuss theerebuss requested review from a team August 10, 2021 12:54
@theerebuss theerebuss marked this pull request as ready for review August 10, 2021 12:54
@theerebuss theerebuss merged commit e260020 into microsoft:master Aug 11, 2021
@theerebuss theerebuss deleted the text-touchups branch May 12, 2022 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants