Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: syntax error in card styles #19573

Merged
merged 32 commits into from
Aug 31, 2021

Conversation

eljefe223
Copy link
Contributor

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Include a change request file using $ yarn change

Description of changes

Foxes error in card styles

Focus areas to test

(optional)

eljefe223 and others added 30 commits September 17, 2020 15:03
Updating my fork with changes
@eljefe223 eljefe223 changed the title fix: error in card styles fix: syntax error in card styles Aug 31, 2021
@fabricteam
Copy link
Collaborator

fabricteam commented Aug 31, 2021

📊 Bundle size report

🤖 This report was generated against cb4515542336a543ccb15f1ea9a9cb0ec4d33330

@eljefe223 eljefe223 enabled auto-merge (squash) August 31, 2021 03:05
@size-auditor
Copy link

size-auditor bot commented Aug 31, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: cb4515542336a543ccb15f1ea9a9cb0ec4d33330 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 63040e5:

Sandbox Source
Fluent UI React Starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 952 934 5000
BaseButton mount 967 987 5000
Breadcrumb mount 2655 2657 1000
ButtonNext mount 465 465 5000
Checkbox mount 1621 1669 5000
CheckboxBase mount 1432 1463 5000
ChoiceGroup mount 5125 5072 5000
ComboBox mount 993 1001 1000
CommandBar mount 10453 10341 1000
ContextualMenu mount 6323 6488 1000
DefaultButton mount 1214 1204 5000
DetailsRow mount 3847 3917 5000
DetailsRowFast mount 3879 3796 5000
DetailsRowNoStyles mount 3686 3745 5000
Dialog mount 2172 2225 1000
DocumentCardTitle mount 159 159 1000
Dropdown mount 3468 3521 5000
FluentProviderNext mount 7131 7052 5000
FocusTrapZone mount 1860 1832 5000
FocusZone mount 1894 1851 5000
IconButton mount 2021 1852 5000
Label mount 332 331 5000
Layer mount 1884 1897 5000
Link mount 492 521 5000
MakeStyles mount 1867 1869 50000
MenuButton mount 1548 1541 5000
MessageBar mount 2055 2157 5000
Nav mount 3415 3389 1000
OverflowSet mount 1159 1149 5000
Panel mount 2123 2134 1000
Persona mount 865 864 1000
Pivot mount 1469 1455 1000
PrimaryButton mount 1364 1310 5000
Rating mount 8421 8324 5000
SearchBox mount 1447 1449 5000
Shimmer mount 2720 2749 5000
Slider mount 2027 2015 5000
SpinButton mount 5162 5174 5000
Spinner mount 402 438 5000
SplitButton mount 3242 3308 5000
Stack mount 520 536 5000
StackWithIntrinsicChildren mount 1701 1658 5000
StackWithTextChildren mount 4951 4995 5000
SwatchColorPicker mount 10738 10698 5000
Tabs mount 1499 1478 1000
TagPicker mount 2728 2798 5000
TeachingBubble mount 12155 12114 5000
Text mount 484 441 5000
TextField mount 1451 1463 5000
ThemeProvider mount 1192 1205 5000
ThemeProvider virtual-rerender 606 611 5000
Toggle mount 847 858 5000
buttonNative mount 116 124 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
TreeWith60ListItems.default 206 174 1.18:1
PortalMinimalPerf.default 194 173 1.12:1
HeaderMinimalPerf.default 417 376 1.11:1
AccordionMinimalPerf.default 183 166 1.1:1
ChatWithPopoverPerf.default 398 364 1.09:1
AvatarMinimalPerf.default 208 192 1.08:1
ListNestedPerf.default 622 574 1.08:1
AlertMinimalPerf.default 300 281 1.07:1
ButtonMinimalPerf.default 186 174 1.07:1
ChatDuplicateMessagesPerf.default 308 287 1.07:1
DividerMinimalPerf.default 398 373 1.07:1
ListMinimalPerf.default 584 547 1.07:1
SegmentMinimalPerf.default 412 385 1.07:1
IconMinimalPerf.default 678 636 1.07:1
FormMinimalPerf.default 440 416 1.06:1
ReactionMinimalPerf.default 430 405 1.06:1
RefMinimalPerf.default 261 246 1.06:1
SkeletonMinimalPerf.default 406 384 1.06:1
BoxMinimalPerf.default 364 348 1.05:1
ButtonSlotsPerf.default 607 577 1.05:1
ChatMinimalPerf.default 733 700 1.05:1
FlexMinimalPerf.default 296 283 1.05:1
AttachmentSlotsPerf.default 1123 1081 1.04:1
ButtonOverridesMissPerf.default 1837 1759 1.04:1
RosterPerf.default 1342 1291 1.04:1
DropdownManyItemsPerf.default 741 719 1.03:1
LoaderMinimalPerf.default 743 718 1.03:1
RadioGroupMinimalPerf.default 510 494 1.03:1
ToolbarMinimalPerf.default 1010 979 1.03:1
AnimationMinimalPerf.default 439 432 1.02:1
CardMinimalPerf.default 596 585 1.02:1
CheckboxMinimalPerf.default 2885 2816 1.02:1
DatepickerMinimalPerf.default 5601 5513 1.02:1
EmbedMinimalPerf.default 4353 4253 1.02:1
LabelMinimalPerf.default 420 412 1.02:1
ProviderMergeThemesPerf.default 1723 1693 1.02:1
SliderMinimalPerf.default 1719 1678 1.02:1
SplitButtonMinimalPerf.default 4550 4455 1.02:1
DropdownMinimalPerf.default 3218 3183 1.01:1
HeaderSlotsPerf.default 807 802 1.01:1
ItemLayoutMinimalPerf.default 1339 1325 1.01:1
MenuButtonMinimalPerf.default 1787 1772 1.01:1
ListCommonPerf.default 664 661 1:1
ListWith60ListItems.default 684 681 1:1
TextMinimalPerf.default 376 377 1:1
TextAreaMinimalPerf.default 548 548 1:1
CustomToolbarPrototype.default 4041 4056 1:1
CarouselMinimalPerf.default 488 491 0.99:1
DialogMinimalPerf.default 781 786 0.99:1
ImageMinimalPerf.default 409 414 0.99:1
LayoutMinimalPerf.default 397 399 0.99:1
MenuMinimalPerf.default 898 908 0.99:1
TreeMinimalPerf.default 864 872 0.99:1
ProviderMinimalPerf.default 1050 1075 0.98:1
TableManyItemsPerf.default 2041 2084 0.98:1
VideoMinimalPerf.default 684 696 0.98:1
PopupMinimalPerf.default 610 630 0.97:1
StatusMinimalPerf.default 725 748 0.97:1
TooltipMinimalPerf.default 1067 1104 0.97:1
GridMinimalPerf.default 357 371 0.96:1
InputMinimalPerf.default 1310 1366 0.96:1
TableMinimalPerf.default 427 445 0.96:1
AttachmentMinimalPerf.default 165 181 0.91:1

@eljefe223 eljefe223 merged commit 2180a7a into microsoft:master Aug 31, 2021
@msft-fluent-ui-bot
Copy link
Collaborator

🎉@fluentui/web-components@v1.3.8 has been released which incorporates this pull request.:tada:

Handy links:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants