-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ScrollablePane: Moves onScroll
from root element to container
#20123
ScrollablePane: Moves onScroll
from root element to container
#20123
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3dcc0eb:
|
Asset size changes
Over Tolerance (1024 B) Over Baseline Below Baseline New Removed 1 kB = 1000 B Baseline commit: 6da8d2a907c97f4eb2bb1fe09569720f42247bd3 (build) |
📊 Bundle size report🤖 This report was generated against b277c0c2919aff304aa62b7efb302393be8e89f1 |
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
BaseButton | mount | 783 | 791 | 5000 | |
Breadcrumb | mount | 2341 | 2344 | 1000 | |
Checkbox | mount | 1301 | 1272 | 5000 | |
CheckboxBase | mount | 1074 | 1096 | 5000 | |
ChoiceGroup | mount | 4013 | 4014 | 5000 | |
ComboBox | mount | 1078 | 858 | 1000 | |
CommandBar | mount | 9193 | 9249 | 1000 | |
ContextualMenu | mount | 10196 | 10332 | 1000 | |
DefaultButton | mount | 986 | 985 | 5000 | |
DetailsRow | mount | 3326 | 3803 | 5000 | |
DetailsRowFast | mount | 3315 | 3220 | 5000 | |
DetailsRowNoStyles | mount | 3211 | 3162 | 5000 | |
Dialog | mount | 1920 | 1920 | 1000 | |
DocumentCardTitle | mount | 148 | 148 | 1000 | |
Dropdown | mount | 2859 | 2854 | 5000 | |
FocusTrapZone | mount | 1603 | 1595 | 5000 | |
FocusZone | mount | 1623 | 1566 | 5000 | |
IconButton | mount | 1528 | 1509 | 5000 | |
Label | mount | 300 | 305 | 5000 | |
Layer | mount | 2514 | 2585 | 5000 | |
Link | mount | 406 | 411 | 5000 | |
MenuButton | mount | 1297 | 1269 | 5000 | |
MessageBar | mount | 1822 | 1808 | 5000 | |
Nav | mount | 2883 | 2823 | 1000 | |
OverflowSet | mount | 935 | 955 | 5000 | |
Panel | mount | 1848 | 1821 | 1000 | |
Persona | mount | 874 | 877 | 1000 | |
Pivot | mount | 1241 | 1249 | 1000 | |
PrimaryButton | mount | 1122 | 1115 | 5000 | |
Rating | mount | 6704 | 7938 | 5000 | |
SearchBox | mount | 1137 | 1126 | 5000 | |
Shimmer | mount | 2146 | 2118 | 5000 | |
Slider | mount | 1681 | 1662 | 5000 | |
SpinButton | mount | 4318 | 4336 | 5000 | |
Spinner | mount | 390 | 376 | 5000 | |
SplitButton | mount | 2737 | 2748 | 5000 | |
Stack | mount | 445 | 447 | 5000 | |
StackWithIntrinsicChildren | mount | 1986 | 1956 | 5000 | |
StackWithTextChildren | mount | 4501 | 4502 | 5000 | |
SwatchColorPicker | mount | 10023 | 9977 | 5000 | |
TagPicker | mount | 2332 | 2367 | 5000 | |
TeachingBubble | mount | 85589 | 86100 | 5000 | |
Text | mount | 369 | 369 | 5000 | |
TextField | mount | 1201 | 1228 | 5000 | |
ThemeProvider | mount | 1024 | 1011 | 5000 | |
ThemeProvider | virtual-rerender | 563 | 561 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 1579 | 1613 | 5000 | |
Toggle | mount | 698 | 681 | 5000 | |
buttonNative | mount | 103 | 117 | 5000 |
Because this pull request has not had activity for over 150 days, we're automatically closing it for house-keeping purposes. The pull request will still be available for reference. If it's still relevant to merge at some point, you can reopen or make a new version based on the latest code. |
I vote for reopening this PR. |
How can I help to get this back on track? |
…osoft#20123) * Moves onScroll method on ScrollablePane from root to container * Change files * Using excludedPropNames instead of undefining the onScroll prop. * Using excludedPropNames instead of undefining the onScroll prop. Co-authored-by: KHMakoto <Humberto.Morimoto@microsoft.com>
Pull request checklist
$ yarn change
Description of changes
Moves
onScroll
from root element to container element. on v17onScroll
is not being invoked on root element,