Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hard coded PR deploy URL to allow for local testing #20205

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

micahgodbolt
Copy link
Member

urlForMaster was dependent on process.env.DEPLOYHOST which meant that perf-test could not be ran locally without manually adding in the URL. Now running perf-test locally will compare the local target perf against the deployed baseline perf.

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 03ffa695d4724dc554fbe111624448f285c0536a

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ee165dd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 13, 2021

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 03ffa695d4724dc554fbe111624448f285c0536a (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 993 984 5000
BaseButton mount 984 960 5000
Breadcrumb mount 2656 2604 1000
ButtonNext mount 518 540 5000
Checkbox mount 1635 1667 5000
CheckboxBase mount 1401 1462 5000
ChoiceGroup mount 5039 5038 5000
ComboBox mount 1030 995 1000
CommandBar mount 10256 10307 1000
ContextualMenu mount 6478 6537 1000
DefaultButton mount 1203 1195 5000
DetailsRow mount 3868 3865 5000
DetailsRowFast mount 3928 3918 5000
DetailsRowNoStyles mount 3773 3777 5000
Dialog mount 2577 2548 1000
DocumentCardTitle mount 178 175 1000
Dropdown mount 3384 3409 5000
FluentProviderNext mount 3285 3299 5000
FluentProviderWithTheme mount 187 213 10
FluentProviderWithTheme virtual-rerender 93 108 10
FluentProviderWithTheme virtual-rerender-with-unmount 227 238 10
FocusTrapZone mount 1829 1814 5000
FocusZone mount 1808 1797 5000
IconButton mount 1854 1886 5000
Label mount 371 373 5000
Layer mount 3127 3126 5000
Link mount 513 495 5000
MakeStyles mount 1858 1853 50000
MenuButton mount 1602 1592 5000
MessageBar mount 2055 2009 5000
Nav mount 3512 3436 1000
OverflowSet mount 1152 1169 5000
Panel mount 2468 2414 1000
Persona mount 892 851 1000
Pivot mount 1490 1504 1000
PrimaryButton mount 1378 1384 5000
Rating mount 8405 8404 5000
SearchBox mount 1426 1473 5000
Shimmer mount 2775 2758 5000
Slider mount 2025 2068 5000
SpinButton mount 5188 5318 5000
Spinner mount 443 445 5000
SplitButton mount 3260 3230 5000
Stack mount 548 558 5000
StackWithIntrinsicChildren mount 1862 1847 5000
StackWithTextChildren mount 5118 5168 5000
SwatchColorPicker mount 11086 10961 5000
Tabs mount 1512 1485 1000
TagPicker mount 2769 2707 5000
TeachingBubble mount 12947 13061 5000
Text mount 480 455 5000
TextField mount 1506 1482 5000
ThemeProvider mount 1197 1232 5000
ThemeProvider virtual-rerender 650 632 5000
ThemeProvider virtual-rerender-with-unmount 2014 1994 5000
Toggle mount 832 855 5000
buttonNative mount 143 134 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 186 169 1.1:1
SegmentMinimalPerf.default 389 353 1.1:1
TextAreaMinimalPerf.default 583 537 1.09:1
ListMinimalPerf.default 586 547 1.07:1
GridMinimalPerf.default 400 377 1.06:1
RadioGroupMinimalPerf.default 500 470 1.06:1
BoxMinimalPerf.default 396 377 1.05:1
ImageMinimalPerf.default 431 410 1.05:1
ListWith60ListItems.default 694 660 1.05:1
AvatarMinimalPerf.default 213 205 1.04:1
ButtonMinimalPerf.default 199 191 1.04:1
DropdownManyItemsPerf.default 770 737 1.04:1
HeaderMinimalPerf.default 409 395 1.04:1
LabelMinimalPerf.default 435 417 1.04:1
LayoutMinimalPerf.default 410 396 1.04:1
TableMinimalPerf.default 453 437 1.04:1
ButtonSlotsPerf.default 608 589 1.03:1
CardMinimalPerf.default 607 590 1.03:1
ChatMinimalPerf.default 724 703 1.03:1
ChatWithPopoverPerf.default 425 412 1.03:1
FormMinimalPerf.default 474 462 1.03:1
HeaderSlotsPerf.default 857 832 1.03:1
StatusMinimalPerf.default 743 722 1.03:1
ToolbarMinimalPerf.default 1007 974 1.03:1
ButtonOverridesMissPerf.default 1847 1818 1.02:1
CheckboxMinimalPerf.default 2871 2815 1.02:1
InputMinimalPerf.default 1435 1409 1.02:1
LoaderMinimalPerf.default 736 722 1.02:1
PortalMinimalPerf.default 175 172 1.02:1
ProviderMergeThemesPerf.default 1725 1690 1.02:1
SliderMinimalPerf.default 1754 1725 1.02:1
TableManyItemsPerf.default 2079 2032 1.02:1
TreeMinimalPerf.default 854 836 1.02:1
DatepickerMinimalPerf.default 5770 5703 1.01:1
DialogMinimalPerf.default 824 816 1.01:1
DividerMinimalPerf.default 400 398 1.01:1
DropdownMinimalPerf.default 3304 3266 1.01:1
EmbedMinimalPerf.default 4486 4439 1.01:1
ItemLayoutMinimalPerf.default 1323 1311 1.01:1
PopupMinimalPerf.default 611 606 1.01:1
SplitButtonMinimalPerf.default 4578 4511 1.01:1
AnimationMinimalPerf.default 437 439 1:1
ListCommonPerf.default 698 697 1:1
MenuMinimalPerf.default 884 882 1:1
RosterPerf.default 1331 1325 1:1
ProviderMinimalPerf.default 1168 1168 1:1
TextMinimalPerf.default 371 371 1:1
FlexMinimalPerf.default 307 310 0.99:1
MenuButtonMinimalPerf.default 1761 1781 0.99:1
SkeletonMinimalPerf.default 381 386 0.99:1
IconMinimalPerf.default 656 664 0.99:1
CustomToolbarPrototype.default 4180 4229 0.99:1
TooltipMinimalPerf.default 1099 1112 0.99:1
AccordionMinimalPerf.default 167 170 0.98:1
AttachmentSlotsPerf.default 1146 1165 0.98:1
ListNestedPerf.default 589 598 0.98:1
RefMinimalPerf.default 232 237 0.98:1
AlertMinimalPerf.default 298 306 0.97:1
ChatDuplicateMessagesPerf.default 311 322 0.97:1
CarouselMinimalPerf.default 495 514 0.96:1
TreeWith60ListItems.default 198 206 0.96:1
ReactionMinimalPerf.default 398 419 0.95:1
VideoMinimalPerf.default 674 724 0.93:1

@micahgodbolt micahgodbolt enabled auto-merge (squash) October 13, 2021 19:41
@micahgodbolt micahgodbolt merged commit 99f64c1 into microsoft:master Oct 13, 2021
@micahgodbolt micahgodbolt deleted the local-perf-tests branch October 13, 2021 23:44
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants