Adding calendar component #20356
Merged
Adding calendar component #20356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 26, 2021 07:59
robarbms
requested review from
chrisdholt,
EisenbergEffect,
nicholasrice and
a team
as code owners
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 41fe1d6:
|
EisenbergEffect
approved these changes
Oct 26, 2021
|
Looks like you have merge conflicts. |
added 2 commits
October 26, 2021 21:10
…sers/robarb/calendar-component
Updates to fast-element and fast-foundation had gone in since the last pull. I've merged back with master. |
📊 Bundle size report🤖 This report was generated against bdeb8ffab8835d5d97592ae4c642570da4a12da3 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bdeb8ffab8835d5d97592ae4c642570da4a12da3 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 973 | 968 | 5000 | |
| BaseButton | mount | 950 | 981 | 5000 | |
| Breadcrumb | mount | 2568 | 2542 | 1000 | |
| ButtonNext | mount | 514 | 543 | 5000 | |
| Checkbox | mount | 1639 | 1626 | 5000 | |
| CheckboxBase | mount | 1333 | 1362 | 5000 | |
| ChoiceGroup | mount | 4939 | 4939 | 5000 | |
| ComboBox | mount | 1000 | 974 | 1000 | |
| CommandBar | mount | 10116 | 10111 | 1000 | |
| ContextualMenu | mount | 6448 | 6311 | 1000 | |
| DefaultButton | mount | 1204 | 1183 | 5000 | |
| DetailsRow | mount | 3941 | 3920 | 5000 | |
| DetailsRowFast | mount | 3945 | 3857 | 5000 | |
| DetailsRowNoStyles | mount | 3751 | 3738 | 5000 | |
| Dialog | mount | 2610 | 2578 | 1000 | |
| DocumentCardTitle | mount | 167 | 165 | 1000 | |
| Dropdown | mount | 3298 | 3301 | 5000 | |
| FluentProviderNext | mount | 3504 | 3555 | 5000 | |
| FluentProviderWithTheme | mount | 215 | 224 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 97 | 99 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 228 | 231 | 10 | |
| FocusTrapZone | mount | 1800 | 1789 | 5000 | |
| FocusZone | mount | 1754 | 1740 | 5000 | |
| IconButton | mount | 1822 | 1834 | 5000 | |
| Label | mount | 359 | 352 | 5000 | |
| Layer | mount | 3012 | 3023 | 5000 | |
| Link | mount | 488 | 495 | 5000 | |
| MakeStyles | mount | 1770 | 1743 | 50000 | |
| MenuButton | mount | 1555 | 1585 | 5000 | |
| MessageBar | mount | 1964 | 1989 | 5000 | |
| Nav | mount | 3627 | 3421 | 1000 | |
| OverflowSet | mount | 1117 | 1131 | 5000 | |
| Panel | mount | 2495 | 2476 | 1000 | |
| Persona | mount | 846 | 870 | 1000 | |
| Pivot | mount | 1481 | 1450 | 1000 | |
| PrimaryButton | mount | 1352 | 1360 | 5000 | |
| Rating | mount | 8256 | 8295 | 5000 | |
| SearchBox | mount | 1419 | 1397 | 5000 | |
| Shimmer | mount | 2643 | 2638 | 5000 | |
| Slider | mount | 2022 | 2134 | 5000 | |
| SpinButton | mount | 5159 | 5239 | 5000 | |
| Spinner | mount | 453 | 446 | 5000 | |
| SplitButton | mount | 3328 | 3299 | 5000 | |
| Stack | mount | 528 | 520 | 5000 | |
| StackWithIntrinsicChildren | mount | 1877 | 1860 | 5000 | |
| StackWithTextChildren | mount | 4982 | 5099 | 5000 | |
| SwatchColorPicker | mount | 10767 | 10826 | 5000 | |
| TagPicker | mount | 2817 | 2749 | 5000 | |
| TeachingBubble | mount | 12889 | 13165 | 5000 | |
| Text | mount | 452 | 460 | 5000 | |
| TextField | mount | 1471 | 1451 | 5000 | |
| ThemeProvider | mount | 1195 | 1189 | 5000 | |
| ThemeProvider | virtual-rerender | 592 | 595 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1957 | 1964 | 5000 | |
| Toggle | mount | 822 | 838 | 5000 | |
| buttonNative | mount | 134 | 112 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| TreeWith60ListItems.default | 211 | 182 | 1.16:1 |
| DividerMinimalPerf.default | 411 | 374 | 1.1:1 |
| AlertMinimalPerf.default | 310 | 286 | 1.08:1 |
| AvatarMinimalPerf.default | 217 | 201 | 1.08:1 |
| PortalMinimalPerf.default | 191 | 177 | 1.08:1 |
| ButtonMinimalPerf.default | 204 | 191 | 1.07:1 |
| FlexMinimalPerf.default | 304 | 284 | 1.07:1 |
| ListMinimalPerf.default | 582 | 546 | 1.07:1 |
| TextMinimalPerf.default | 396 | 371 | 1.07:1 |
| DropdownManyItemsPerf.default | 766 | 724 | 1.06:1 |
| ListNestedPerf.default | 618 | 581 | 1.06:1 |
| RefMinimalPerf.default | 244 | 230 | 1.06:1 |
| SkeletonMinimalPerf.default | 378 | 357 | 1.06:1 |
| BoxMinimalPerf.default | 383 | 365 | 1.05:1 |
| GridMinimalPerf.default | 372 | 353 | 1.05:1 |
| AttachmentMinimalPerf.default | 172 | 165 | 1.04:1 |
| ChatWithPopoverPerf.default | 419 | 401 | 1.04:1 |
| ImageMinimalPerf.default | 410 | 395 | 1.04:1 |
| LabelMinimalPerf.default | 426 | 410 | 1.04:1 |
| ListWith60ListItems.default | 706 | 676 | 1.04:1 |
| TreeMinimalPerf.default | 859 | 829 | 1.04:1 |
| AnimationMinimalPerf.default | 431 | 419 | 1.03:1 |
| CardMinimalPerf.default | 602 | 585 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1303 | 1266 | 1.03:1 |
| CustomToolbarPrototype.default | 4303 | 4191 | 1.03:1 |
| CarouselMinimalPerf.default | 506 | 495 | 1.02:1 |
| ChatDuplicateMessagesPerf.default | 333 | 326 | 1.02:1 |
| HeaderMinimalPerf.default | 393 | 385 | 1.02:1 |
| HeaderSlotsPerf.default | 837 | 824 | 1.02:1 |
| InputMinimalPerf.default | 1399 | 1377 | 1.02:1 |
| MenuButtonMinimalPerf.default | 1738 | 1697 | 1.02:1 |
| TableManyItemsPerf.default | 2093 | 2044 | 1.02:1 |
| ButtonOverridesMissPerf.default | 1848 | 1825 | 1.01:1 |
| ChatMinimalPerf.default | 719 | 712 | 1.01:1 |
| DialogMinimalPerf.default | 786 | 782 | 1.01:1 |
| EmbedMinimalPerf.default | 4531 | 4473 | 1.01:1 |
| FormMinimalPerf.default | 457 | 451 | 1.01:1 |
| ListCommonPerf.default | 663 | 659 | 1.01:1 |
| PopupMinimalPerf.default | 596 | 589 | 1.01:1 |
| ProviderMinimalPerf.default | 1173 | 1167 | 1.01:1 |
| RadioGroupMinimalPerf.default | 496 | 489 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4587 | 4520 | 1.01:1 |
| StatusMinimalPerf.default | 737 | 731 | 1.01:1 |
| TextAreaMinimalPerf.default | 563 | 556 | 1.01:1 |
| ToolbarMinimalPerf.default | 1006 | 999 | 1.01:1 |
| AttachmentSlotsPerf.default | 1141 | 1140 | 1:1 |
| DatepickerMinimalPerf.default | 5704 | 5720 | 1:1 |
| DropdownMinimalPerf.default | 3227 | 3223 | 1:1 |
| MenuMinimalPerf.default | 888 | 891 | 1:1 |
| ReactionMinimalPerf.default | 410 | 410 | 1:1 |
| SliderMinimalPerf.default | 1757 | 1765 | 1:1 |
| TooltipMinimalPerf.default | 1096 | 1098 | 1:1 |
| VideoMinimalPerf.default | 696 | 695 | 1:1 |
| ButtonSlotsPerf.default | 589 | 594 | 0.99:1 |
| CheckboxMinimalPerf.default | 2842 | 2866 | 0.99:1 |
| LayoutMinimalPerf.default | 388 | 390 | 0.99:1 |
| LoaderMinimalPerf.default | 728 | 735 | 0.99:1 |
| RosterPerf.default | 1322 | 1342 | 0.99:1 |
| SegmentMinimalPerf.default | 369 | 373 | 0.99:1 |
| ProviderMergeThemesPerf.default | 1684 | 1746 | 0.96:1 |
| IconMinimalPerf.default | 617 | 645 | 0.96:1 |
| TableMinimalPerf.default | 443 | 466 | 0.95:1 |
| AccordionMinimalPerf.default | 159 | 170 | 0.94:1 |
added 2 commits
October 27, 2021 08:32
chrisdholt
reviewed
Oct 27, 2021
chrisdholt
reviewed
Oct 27, 2021
chrisdholt
approved these changes
Oct 27, 2021
…sers/robarb/calendar-component
bheston
reviewed
Oct 27, 2021
packages/web-components/src/calendar/calendar.vscode.definition.json
Outdated
Show resolved
Hide resolved
added 7 commits
October 27, 2021 12:30
…sers/robarb/calendar-component
…sers/robarb/calendar-component
added 7 commits
November 2, 2021 12:32
…sers/robarb/calendar-component
bheston
approved these changes
Nov 4, 2021
added 2 commits
November 8, 2021 09:43
…sers/robarb/calendar-component
nicholasrice
approved these changes
Nov 8, 2021
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
* FluentUI calendar component * Change files * Reverting fast-element and fast-foundation updates * Updating change file type * Updating documentation * Updating api-report * Updating stories * Updating styles * Style cleanup * Updating disabled and selected styles * Fixing disabled and selected styles for RTL * Updating high contrast styles * Fixing readonly styles. * Cleaning up calendar styles * More style cleanup. * Removing unused fixture * Removing hard coded values in styles * Removing an unused import * Fixing interactive calendar styles * Style updates
|
Is there a follow-up task for the documentation, @robarbms? I could not find this component on https://docs.microsoft.com/en-us/fluent-ui/web-components/components/overview |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ yarn changeDescription of changes
This adds the fast-calendar component to FluentUI. This is a prerequisite for the upcoming date-picker component.
Focus areas to test
(optional)