Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump @linaria/shaker #20538

Merged
merged 4 commits into from
Nov 9, 2021
Merged

chore: bump @linaria/shaker #20538

merged 4 commits into from
Nov 9, 2021

Conversation

layershifter
Copy link
Member

@layershifter layershifter commented Nov 8, 2021 •
edited
Loading

Pull request checklist

Description of changes

This PR bumps @linaria/shaker to adopt a fix for callstack/linaria#861.

Previously changes in @fluentui/react-slider were failing on Screener, now it's safe to remove this workaround.

@layershifter layershifter changed the title Chore/bump linaria chore: bump @linaria/shaker Nov 8, 2021
@size-auditor
Copy link

size-auditor bot commented Nov 8, 2021 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5e04b6208619318aa256768635101d5e64b96cc5 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 8, 2021 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f20aba:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 8, 2021 •
edited
Loading

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-slider
RangedSlider		 39.807 kB
11.454 kB		 39.807 kB
11.491 kB
37 B
react-slider
Slider		 33.204 kB
10.302 kB		 33.196 kB
10.312 kB		 -8 B
10 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)		 56.753 kB
17.873 kB
react-avatar
Avatar		 54.097 kB
15.331 kB
react-badge
Badge		 22.394 kB
6.707 kB
react-badge
CounterBadge		 24.773 kB
7.387 kB
react-badge
PresenceBadge		 29.768 kB
8.517 kB
react-button
Button		 24.651 kB
7.462 kB
react-button
CompoundButton		 29.939 kB
8.418 kB
react-button
MenuButton		 27.046 kB
8.227 kB
react-button
SplitButton		 33.261 kB
9.328 kB
react-button
ToggleButton		 33.78 kB
8.065 kB
react-card
Card - All		 48.534 kB
14.421 kB
react-card
Card		 43.954 kB
13.196 kB
react-card
CardFooter		 7.418 kB
3.182 kB
react-card
CardHeader		 8.778 kB
3.64 kB
react-card
CardPreview		 7.682 kB
3.341 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 166.267 kB
47.598 kB
react-components
react-components: FluentProvider & webLightTheme		 31.058 kB
10.346 kB
react-divider
Divider		 14.828 kB
5.375 kB
react-image
Image		 9.041 kB
3.734 kB
react-input
Input		 13.83 kB
4.958 kB
react-label
Label		 8.177 kB
3.445 kB
react-link
Link		 10.883 kB
4.449 kB
react-make-styles
makeStaticStyles (runtime)		 7.59 kB
3.322 kB
react-make-styles
makeStyles + mergeClasses (runtime)		 22.238 kB
8.411 kB
react-make-styles
makeStyles + mergeClasses (build time)		 2.561 kB
1.206 kB
react-menu
Menu (including children components)		 103.644 kB
31.979 kB
react-menu
Menu (including selectable components)		 106.032 kB
32.349 kB
react-popover
Popover		 99.149 kB
30.108 kB
react-portal
Portal		 6.621 kB
2.226 kB
react-positioning
usePopper		 22.808 kB
7.935 kB
react-provider
FluentProvider		 14.056 kB
5.267 kB
react-switch
Switch		 25.311 kB
8.143 kB
react-text
Text - Default		 10.603 kB
4.172 kB
react-text
Text - Wrappers		 13.899 kB
4.513 kB
react-theme
Teams: all themes		 25.334 kB
6.012 kB
react-theme
Teams: Light theme		 16.937 kB
4.948 kB
react-tooltip
Tooltip		 43.871 kB
15.165 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against 5e04b6208619318aa256768635101d5e64b96cc5

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 8, 2021 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1099 1101 5000
BaseButton mount 1078 1094 5000
Breadcrumb mount 2875 2849 1000
ButtonNext mount 573 586 5000
Checkbox mount 1796 1797 5000
CheckboxBase mount 1542 1529 5000
ChoiceGroup mount 5548 5563 5000
ComboBox mount 1104 1115 1000
CommandBar mount 11284 11397 1000
ContextualMenu mount 7150 7232 1000
DefaultButton mount 1352 1342 5000
DetailsRow mount 4255 4271 5000
DetailsRowFast mount 4278 4282 5000
DetailsRowNoStyles mount 3918 4033 5000
Dialog mount 2743 2731 1000
DocumentCardTitle mount 194 191 1000
Dropdown mount 3730 3634 5000
FluentProviderNext mount 3942 3934 5000
FluentProviderWithTheme mount 227 227 10
FluentProviderWithTheme virtual-rerender 114 96 10
FluentProviderWithTheme virtual-rerender-with-unmount 282 269 10
FocusTrapZone mount 1966 1966 5000
FocusZone mount 1932 1923 5000
IconButton mount 2043 2010 5000
Label mount 390 381 5000
Layer mount 3402 3396 5000
Link mount 549 546 5000
MakeStyles mount 1989 1977 50000
MenuButton mount 1727 1734 5000
MessageBar mount 2235 2188 5000
Nav mount 3809 3760 1000
OverflowSet mount 1275 1226 5000
Panel mount 2676 2644 1000
Persona mount 949 957 1000
Pivot mount 1582 1582 1000
PrimaryButton mount 1476 1480 5000
Rating mount 8911 9097 5000
SearchBox mount 1529 1538 5000
Shimmer mount 2856 2942 5000
Slider mount 2174 2244 5000
SpinButton mount 5580 5833 5000
Spinner mount 462 476 5000
SplitButton mount 3599 3546 5000
Stack mount 582 626 5000
StackWithIntrinsicChildren mount 2034 2048 5000
StackWithTextChildren mount 5386 5479 5000
SwatchColorPicker mount 11529 11607 5000
TagPicker mount 3012 3014 5000
TeachingBubble mount 14087 13977 5000
Text mount 478 489 5000
TextField mount 1620 1601 5000
ThemeProvider mount 1299 1309 5000
ThemeProvider virtual-rerender 654 651 5000
ThemeProvider virtual-rerender-with-unmount 2146 2123 5000
Toggle mount 923 923 5000
buttonNative mount 147 149 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
LabelMinimalPerf.default 467 429 1.09:1
ChatDuplicateMessagesPerf.default 352 328 1.07:1
ListCommonPerf.default 771 718 1.07:1
RadioGroupMinimalPerf.default 529 496 1.07:1
ReactionMinimalPerf.default 455 427 1.07:1
AttachmentMinimalPerf.default 197 186 1.06:1
SkeletonMinimalPerf.default 420 397 1.06:1
TableMinimalPerf.default 478 452 1.06:1
TextMinimalPerf.default 428 402 1.06:1
ButtonSlotsPerf.default 661 630 1.05:1
ListWith60ListItems.default 769 733 1.05:1
PopupMinimalPerf.default 673 638 1.05:1
AvatarMinimalPerf.default 225 216 1.04:1
ChatWithPopoverPerf.default 440 422 1.04:1
DialogMinimalPerf.default 855 825 1.04:1
FlexMinimalPerf.default 338 325 1.04:1
ListNestedPerf.default 680 654 1.04:1
MenuMinimalPerf.default 1001 962 1.04:1
TreeWith60ListItems.default 218 209 1.04:1
BoxMinimalPerf.default 401 388 1.03:1
CardMinimalPerf.default 652 633 1.03:1
SegmentMinimalPerf.default 423 411 1.03:1
ToolbarMinimalPerf.default 1085 1057 1.03:1
AnimationMinimalPerf.default 473 464 1.02:1
AttachmentSlotsPerf.default 1221 1202 1.02:1
ChatMinimalPerf.default 735 721 1.02:1
GridMinimalPerf.default 409 402 1.02:1
LoaderMinimalPerf.default 809 795 1.02:1
MenuButtonMinimalPerf.default 1883 1855 1.02:1
SliderMinimalPerf.default 1930 1900 1.02:1
StatusMinimalPerf.default 772 754 1.02:1
TreeMinimalPerf.default 925 903 1.02:1
ButtonMinimalPerf.default 216 214 1.01:1
ButtonOverridesMissPerf.default 2032 2006 1.01:1
CarouselMinimalPerf.default 525 520 1.01:1
DropdownManyItemsPerf.default 820 811 1.01:1
EmbedMinimalPerf.default 4857 4804 1.01:1
HeaderSlotsPerf.default 901 894 1.01:1
LayoutMinimalPerf.default 425 421 1.01:1
ListMinimalPerf.default 598 590 1.01:1
PortalMinimalPerf.default 208 205 1.01:1
RefMinimalPerf.default 259 256 1.01:1
SplitButtonMinimalPerf.default 4826 4779 1.01:1
TableManyItemsPerf.default 2197 2182 1.01:1
TextAreaMinimalPerf.default 596 591 1.01:1
TooltipMinimalPerf.default 1191 1182 1.01:1
DatepickerMinimalPerf.default 6307 6299 1:1
DropdownMinimalPerf.default 3443 3460 1:1
ItemLayoutMinimalPerf.default 1410 1406 1:1
CustomToolbarPrototype.default 4528 4513 1:1
CheckboxMinimalPerf.default 2941 2960 0.99:1
InputMinimalPerf.default 1442 1458 0.99:1
RosterPerf.default 1370 1384 0.99:1
DividerMinimalPerf.default 427 437 0.98:1
HeaderMinimalPerf.default 430 437 0.98:1
ProviderMergeThemesPerf.default 1851 1880 0.98:1
ProviderMinimalPerf.default 1287 1321 0.97:1
IconMinimalPerf.default 698 717 0.97:1
AlertMinimalPerf.default 310 322 0.96:1
FormMinimalPerf.default 477 499 0.96:1
ImageMinimalPerf.default 428 447 0.96:1
VideoMinimalPerf.default 696 725 0.96:1
AccordionMinimalPerf.default 179 188 0.95:1

@layershifter layershifter marked this pull request as ready for review November 8, 2021 11:13
@layershifter layershifter requested review from ecraig12345, khmakoto and a team as code owners November 8, 2021 11:13
@ling1726
Copy link
Member

ling1726 commented Nov 8, 2021

you need a changefile

@layershifter layershifter merged commit e48014a into master Nov 9, 2021
@layershifter layershifter deleted the chore/bump-linaria branch November 9, 2021 10:14
mlp73 pushed a commit to mlp73/fluentui that referenced this pull request Jan 17, 2022
@layershifter
chore: bump @linaria/shaker (microsoft#20538)
9c8fa70 
* chore: bump @linaria/shaker

* Change files

* bump preset too

* Change files
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ling1726 ling1726 ling1726 approved these changes

@khmakoto khmakoto khmakoto approved these changes

@ecraig12345 ecraig12345 Awaiting requested review from ecraig12345

Assignees
No one assigned
Labels
Fluent UI react-components (v9)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bump @linaria/sharer once bug is fixed
4 participants
@layershifter @fabricteam @ling1726 @khmakoto