Storybook iframe update to match website design #21270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3bb6d97:
|
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0f3e58e289514a5b8dc1eddbb70a720112b48df0 (build) |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| ContextualMenu | mount | 15519 | 8303 | 1000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 952 | 946 | 5000 | |
| BaseButton | mount | 956 | 963 | 5000 | |
| Breadcrumb | mount | 2594 | 2544 | 1000 | |
| ButtonNext | mount | 523 | 544 | 5000 | |
| Checkbox | mount | 1670 | 1604 | 5000 | |
| CheckboxBase | mount | 1316 | 1382 | 5000 | |
| ChoiceGroup | mount | 5011 | 5038 | 5000 | |
| ComboBox | mount | 1013 | 994 | 1000 | |
| CommandBar | mount | 9950 | 10165 | 1000 | |
| ContextualMenu | mount | 15519 | 8303 | 1000 | Possible regression |
| DefaultButton | mount | 1220 | 1167 | 5000 | |
| DetailsRow | mount | 3823 | 3837 | 5000 | |
| DetailsRowFast | mount | 3828 | 3889 | 5000 | |
| DetailsRowNoStyles | mount | 3614 | 3642 | 5000 | |
| Dialog | mount | 2655 | 2625 | 1000 | |
| DocumentCardTitle | mount | 178 | 185 | 1000 | |
| Dropdown | mount | 3330 | 3340 | 5000 | |
| FluentProviderNext | mount | 1870 | 1766 | 5000 | |
| FluentProviderWithTheme | mount | 160 | 165 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 118 | 98 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 190 | 192 | 10 | |
| FocusTrapZone | mount | 1854 | 1827 | 5000 | |
| FocusZone | mount | 1738 | 1834 | 5000 | |
| IconButton | mount | 1852 | 1893 | 5000 | |
| Label | mount | 366 | 368 | 5000 | |
| Layer | mount | 3060 | 3056 | 5000 | |
| Link | mount | 508 | 527 | 5000 | |
| MakeStyles | mount | 1645 | 1669 | 50000 | |
| MenuButton | mount | 1595 | 1579 | 5000 | |
| MessageBar | mount | 2016 | 1983 | 5000 | |
| Nav | mount | 3376 | 3409 | 1000 | |
| OverflowSet | mount | 1165 | 1177 | 5000 | |
| Panel | mount | 2465 | 2515 | 1000 | |
| Persona | mount | 878 | 877 | 1000 | |
| Pivot | mount | 1452 | 1477 | 1000 | |
| PrimaryButton | mount | 1362 | 1336 | 5000 | |
| Rating | mount | 8012 | 8205 | 5000 | |
| SearchBox | mount | 1457 | 1416 | 5000 | |
| Shimmer | mount | 2695 | 2646 | 5000 | |
| Slider | mount | 2027 | 2018 | 5000 | |
| SpinButton | mount | 5097 | 5198 | 5000 | |
| Spinner | mount | 452 | 456 | 5000 | |
| SplitButton | mount | 3238 | 3219 | 5000 | |
| Stack | mount | 559 | 574 | 5000 | |
| StackWithIntrinsicChildren | mount | 2510 | 2514 | 5000 | |
| StackWithTextChildren | mount | 5723 | 5781 | 5000 | |
| SwatchColorPicker | mount | 11823 | 11851 | 5000 | |
| TagPicker | mount | 2767 | 2719 | 5000 | |
| TeachingBubble | mount | 12979 | 13111 | 5000 | |
| Text | mount | 467 | 471 | 5000 | |
| TextField | mount | 1413 | 1465 | 5000 | |
| ThemeProvider | mount | 1184 | 1188 | 5000 | |
| ThemeProvider | virtual-rerender | 632 | 614 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1911 | 1992 | 5000 | |
| Toggle | mount | 850 | 858 | 5000 | |
| buttonNative | mount | 153 | 150 | 5000 |
Perf Analysis (@fluentui/react-northstar)
ling1726
reviewed
Feb 1, 2022
ling1726
reviewed
Feb 1, 2022
packages/react-components/src/DocsComponents/FluentDocsContainer.stories.tsx
Outdated
Show resolved
Hide resolved
ling1726
reviewed
Feb 1, 2022
ling1726
reviewed
Feb 1, 2022
ling1726
reviewed
Feb 1, 2022
ling1726
reviewed
Feb 1, 2022
ling1726
reviewed
Feb 1, 2022
ling1726
reviewed
Feb 1, 2022
|
Please detail if there are any other visual details we should look out for in the URL you provided, apart from reviewing just the code. |
|
Not sure if it's caused by this PR, but spacing in the red area looks really weird 🙃 |
That space was intentional and already in there. It just reduces the line length of that text |
|
Great feedback! Lots of updates and notes added to files. |
andrefcdias
approved these changes
Feb 2, 2022
yeah, it's pretty ugly in places with that width restriction. I'll remove it |
GeoffCoxMSFT
approved these changes
Feb 2, 2022
ling1726
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various updates to react-components storybook design and layout to improve internal docs, and prepare the storybook docs for embedding in the new fluent website.
Preview updates at https://fluentuipr.z22.web.core.windows.net/pull/21270/react-components/storybook/index.html?path=/docs/components-menu--default
Note:
docs-root.csswas copied over into package to enable making some sweeping updates without affecting other packages. We could consider moving that back to the root storybook if we want these styles propagated all around.Also, these styles are a WIP. There will inevitably be more updates as the website work evolves in prep for build.
fixes #21512