Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove temp fix for mini-css-extractor-plugin error #21326

Merged
merged 2 commits into from
Jan 18, 2022

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Jan 18, 2022

Current Behavior

  • An older version of the mini-css-extractor-plugin was added to the the resolutions section of the test app's package.json for both cra-template and projects-test packages. The root issue has since been fixed in the latest version (see comment) of mini-css-extrator-plugin so this temp fix is no longer needed.

New Behavior

Removes temporary fix added in #21295

Related Issue(s)

Fixes #21300

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1389610:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against 1389610

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 8dfa712156b70414205b87b5b6d099367b0c297d

@size-auditor
Copy link

size-auditor bot commented Jan 18, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 8dfa712156b70414205b87b5b6d099367b0c297d (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
ContextualMenu mount 7160 14595 1000 Possible regression
FluentProviderWithTheme mount 118 141 10 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 785 779 5000
BaseButton mount 801 793 5000
Breadcrumb mount 2252 2273 1000
ButtonNext mount 436 447 5000
Checkbox mount 1304 1328 5000
CheckboxBase mount 1132 1137 5000
ChoiceGroup mount 4098 4059 5000
ComboBox mount 884 849 1000
CommandBar mount 8834 8819 1000
ContextualMenu mount 7160 14595 1000 Possible regression
DefaultButton mount 991 1009 5000
DetailsRow mount 3269 3255 5000
DetailsRowFast mount 3290 3308 5000
DetailsRowNoStyles mount 3126 3077 5000
Dialog mount 2233 2211 1000
DocumentCardTitle mount 158 160 1000
Dropdown mount 2750 2747 5000
FluentProviderNext mount 1642 1647 5000
FluentProviderWithTheme mount 118 141 10 Possible regression
FluentProviderWithTheme virtual-rerender 94 104 10
FluentProviderWithTheme virtual-rerender-with-unmount 184 173 10
FocusTrapZone mount 1568 1580 5000
FocusZone mount 1605 1609 5000
IconButton mount 1514 1508 5000
Label mount 320 320 5000
Layer mount 2492 2567 5000
Link mount 428 423 5000
MakeStyles mount 1483 1478 50000
MenuButton mount 1265 1275 5000
MessageBar mount 1744 1754 5000
Nav mount 2893 2834 1000
OverflowSet mount 972 1006 5000
Panel mount 2142 2147 1000
Persona mount 740 746 1000
Pivot mount 1245 1256 1000
PrimaryButton mount 1100 1119 5000
Rating mount 6697 6595 5000
SearchBox mount 1171 1148 5000
Shimmer mount 2196 2198 5000
Slider mount 1709 1693 5000
SpinButton mount 4276 4297 5000
Spinner mount 393 396 5000
SplitButton mount 2701 2720 5000
Stack mount 457 478 5000
StackWithIntrinsicChildren mount 1974 1990 5000
StackWithTextChildren mount 4433 4436 5000
SwatchColorPicker mount 9784 9794 5000
TagPicker mount 2274 2266 5000
TeachingBubble mount 11089 11166 5000
Text mount 384 377 5000
TextField mount 1196 1211 5000
ThemeProvider mount 1019 1027 5000
ThemeProvider virtual-rerender 544 544 5000
ThemeProvider virtual-rerender-with-unmount 1614 1593 5000
Toggle mount 721 703 5000
buttonNative mount 133 140 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AvatarMinimalPerf.default 185 165 1.12:1
TreeWith60ListItems.default 165 152 1.09:1
SkeletonMinimalPerf.default 310 291 1.07:1
FormMinimalPerf.default 353 332 1.06:1
ReactionMinimalPerf.default 323 308 1.05:1
SegmentMinimalPerf.default 313 298 1.05:1
AccordionMinimalPerf.default 129 124 1.04:1
ButtonMinimalPerf.default 146 142 1.03:1
CardMinimalPerf.default 477 463 1.03:1
ImageMinimalPerf.default 327 318 1.03:1
ListCommonPerf.default 557 540 1.03:1
TableMinimalPerf.default 356 344 1.03:1
ToolbarMinimalPerf.default 807 784 1.03:1
AnimationMinimalPerf.default 468 458 1.02:1
ChatMinimalPerf.default 634 621 1.02:1
ChatWithPopoverPerf.default 316 311 1.02:1
DropdownManyItemsPerf.default 579 565 1.02:1
GridMinimalPerf.default 298 291 1.02:1
InputMinimalPerf.default 1105 1086 1.02:1
ListNestedPerf.default 477 466 1.02:1
TextMinimalPerf.default 301 295 1.02:1
VideoMinimalPerf.default 559 546 1.02:1
BoxMinimalPerf.default 291 289 1.01:1
CarouselMinimalPerf.default 402 398 1.01:1
CheckboxMinimalPerf.default 2282 2256 1.01:1
EmbedMinimalPerf.default 3503 3466 1.01:1
HeaderMinimalPerf.default 316 312 1.01:1
LabelMinimalPerf.default 333 330 1.01:1
LayoutMinimalPerf.default 310 306 1.01:1
LoaderMinimalPerf.default 585 577 1.01:1
ProviderMinimalPerf.default 961 951 1.01:1
RadioGroupMinimalPerf.default 378 374 1.01:1
SliderMinimalPerf.default 1419 1411 1.01:1
StatusMinimalPerf.default 590 584 1.01:1
TableManyItemsPerf.default 1613 1603 1.01:1
CustomToolbarPrototype.default 3481 3450 1.01:1
TooltipMinimalPerf.default 880 869 1.01:1
AttachmentSlotsPerf.default 914 914 1:1
ButtonOverridesMissPerf.default 1429 1429 1:1
ChatDuplicateMessagesPerf.default 250 250 1:1
DialogMinimalPerf.default 647 648 1:1
DropdownMinimalPerf.default 2581 2580 1:1
FlexMinimalPerf.default 250 250 1:1
HeaderSlotsPerf.default 643 642 1:1
ItemLayoutMinimalPerf.default 1011 1010 1:1
ListMinimalPerf.default 433 431 1:1
ListWith60ListItems.default 556 554 1:1
MenuButtonMinimalPerf.default 1412 1411 1:1
ProviderMergeThemesPerf.default 1458 1452 1:1
RefMinimalPerf.default 205 204 1:1
SplitButtonMinimalPerf.default 3655 3645 1:1
PortalMinimalPerf.default 155 156 0.99:1
TextAreaMinimalPerf.default 423 427 0.99:1
TreeMinimalPerf.default 673 678 0.99:1
ButtonSlotsPerf.default 465 475 0.98:1
DatepickerMinimalPerf.default 4614 4731 0.98:1
DividerMinimalPerf.default 306 313 0.98:1
MenuMinimalPerf.default 717 732 0.98:1
RosterPerf.default 1001 1022 0.98:1
PopupMinimalPerf.default 516 524 0.98:1
IconMinimalPerf.default 504 513 0.98:1
AlertMinimalPerf.default 231 242 0.95:1
AttachmentMinimalPerf.default 125 133 0.94:1

@TristanWatanabe TristanWatanabe changed the title chore: remove temp fix to mitigate mini-css-extractor-plugin-error chore: remove temp fix for mini-css-extractor-plugin error Jan 18, 2022
@TristanWatanabe TristanWatanabe marked this pull request as ready for review January 18, 2022 17:24
@TristanWatanabe TristanWatanabe merged commit 4de874e into microsoft:master Jan 18, 2022
@TristanWatanabe TristanWatanabe deleted the remove-temp-fix branch January 18, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove mini-css-extractor-plugin resolutions in CRA tests
6 participants