Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated code owners for cxe-coastal #21364

Merged
merged 1 commit into from
Jan 20, 2022

Conversation

GeoffCoxMSFT
Copy link
Member

Updated the codeowners file to add cxe-coastal based on web focus areas.

@GeoffCoxMSFT GeoffCoxMSFT self-assigned this Jan 20, 2022
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e966ed1:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Jan 20, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4f22b6dad04ea37eb53e4af23c73d2de4db512a2 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
165.872 kB
46.984 kB
165.914 kB
46.997 kB
42 B
13 B
react-menu
Menu (including children components)
102.919 kB
31.787 kB
102.961 kB
31.798 kB
42 B
11 B
react-menu
Menu (including selectable components)
105.17 kB
32.144 kB
105.212 kB
32.153 kB
42 B
9 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
54.694 kB
17.486 kB
react-avatar
Avatar
43.858 kB
12.488 kB
react-badge
Badge
24.258 kB
7.128 kB
react-badge
CounterBadge
25.126 kB
7.429 kB
react-badge
PresenceBadge
22.314 kB
6.544 kB
react-button
Button
28.265 kB
8.113 kB
react-button
CompoundButton
33.562 kB
9.074 kB
react-button
MenuButton
29.92 kB
8.69 kB
react-button
SplitButton
36.006 kB
9.757 kB
react-button
ToggleButton
37.502 kB
8.711 kB
react-card
Card - All
48.475 kB
14.343 kB
react-card
Card
43.984 kB
13.191 kB
react-card
CardFooter
7.686 kB
3.254 kB
react-card
CardHeader
8.953 kB
3.693 kB
react-card
CardPreview
7.879 kB
3.381 kB
react-components
react-components: FluentProvider & webLightTheme
32.297 kB
10.592 kB
react-divider
Divider
15.071 kB
5.441 kB
react-image
Image
10.143 kB
3.969 kB
react-input
Input
21.542 kB
7.139 kB
react-label
Label
8.391 kB
3.5 kB
react-link
Link
11.14 kB
4.521 kB
react-make-styles
makeStaticStyles (runtime)
8.161 kB
3.564 kB
react-make-styles
makeStyles + mergeClasses (runtime)
19.554 kB
7.446 kB
react-make-styles
makeStyles + mergeClasses (build time)
2.793 kB
1.267 kB
react-popover
Popover
95.459 kB
29.031 kB
react-portal
Portal
6.249 kB
2.163 kB
react-positioning
usePopper
22.808 kB
7.935 kB
react-provider
FluentProvider
13.8 kB
5.19 kB
react-slider
Slider
22.011 kB
7.52 kB
react-switch
Switch
25.383 kB
8.204 kB
react-text
Text - Default
10.837 kB
4.248 kB
react-text
Text - Wrappers
14.139 kB
4.589 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.344 kB
6.55 kB
react-theme
Teams: Light theme
18.4 kB
5.273 kB
react-tooltip
Tooltip
45.167 kB
15.671 kB
react-utilities
SSRProvider
189 B
161 B
🤖 This report was generated against 7c50f4d58b4ba834f667fd69ddee2701ad0745fb

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react)

Scenario Render type Master Ticks PR Ticks Iterations Status
ContextualMenu mount 16029 8179 1000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 894 881 5000
BaseButton mount 890 895 5000
Breadcrumb mount 2575 2626 1000
ButtonNext mount 510 509 5000
Checkbox mount 1516 1531 5000
CheckboxBase mount 1298 1286 5000
ChoiceGroup mount 4820 4726 5000
ComboBox mount 977 993 1000
CommandBar mount 10048 9892 1000
ContextualMenu mount 16029 8179 1000 Possible regression
DefaultButton mount 1148 1157 5000
DetailsRow mount 3773 3748 5000
DetailsRowFast mount 3925 3789 5000
DetailsRowNoStyles mount 3513 3616 5000
Dialog mount 2544 2557 1000
DocumentCardTitle mount 180 187 1000
Dropdown mount 3223 3150 5000
FluentProviderNext mount 1759 1803 5000
FluentProviderWithTheme mount 164 153 10
FluentProviderWithTheme virtual-rerender 117 106 10
FluentProviderWithTheme virtual-rerender-with-unmount 205 196 10
FocusTrapZone mount 1797 1739 5000
FocusZone mount 1793 1802 5000
IconButton mount 1751 1717 5000
Label mount 365 367 5000
Layer mount 2885 2916 5000
Link mount 477 507 5000
MakeStyles mount 1659 1664 50000
MenuButton mount 1446 1451 5000
MessageBar mount 1982 2068 5000
Nav mount 3247 3279 1000
OverflowSet mount 1125 1096 5000
Panel mount 2482 2428 1000
Persona mount 852 864 1000
Pivot mount 1421 1411 1000
PrimaryButton mount 1303 1260 5000
Rating mount 7676 7474 5000
SearchBox mount 1334 1323 5000
Shimmer mount 2453 2559 5000
Slider mount 1897 1917 5000
SpinButton mount 4888 4819 5000
Spinner mount 461 444 5000
SplitButton mount 3045 3088 5000
Stack mount 547 541 5000
StackWithIntrinsicChildren mount 2174 2230 5000
StackWithTextChildren mount 5132 5084 5000
SwatchColorPicker mount 11093 11173 5000
TagPicker mount 2589 2571 5000
TeachingBubble mount 12817 12845 5000
Text mount 441 464 5000
TextField mount 1391 1407 5000
ThemeProvider mount 1172 1179 5000
ThemeProvider virtual-rerender 611 625 5000
ThemeProvider virtual-rerender-with-unmount 1869 1839 5000
Toggle mount 797 771 5000
buttonNative mount 145 144 5000

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 154 144 1.07:1
AvatarMinimalPerf.default 196 184 1.07:1
TreeWith60ListItems.default 174 163 1.07:1
PortalMinimalPerf.default 186 176 1.06:1
VideoMinimalPerf.default 618 581 1.06:1
LayoutMinimalPerf.default 366 350 1.05:1
TextAreaMinimalPerf.default 482 461 1.05:1
ListNestedPerf.default 556 535 1.04:1
RadioGroupMinimalPerf.default 441 425 1.04:1
TableMinimalPerf.default 404 390 1.04:1
GridMinimalPerf.default 331 320 1.03:1
HeaderSlotsPerf.default 752 731 1.03:1
ProviderMinimalPerf.default 1102 1069 1.03:1
SegmentMinimalPerf.default 342 331 1.03:1
AnimationMinimalPerf.default 534 523 1.02:1
ChatDuplicateMessagesPerf.default 294 287 1.02:1
DialogMinimalPerf.default 756 743 1.02:1
InputMinimalPerf.default 1257 1228 1.02:1
ItemLayoutMinimalPerf.default 1160 1141 1.02:1
ListMinimalPerf.default 497 487 1.02:1
LoaderMinimalPerf.default 661 647 1.02:1
ProviderMergeThemesPerf.default 1727 1690 1.02:1
StatusMinimalPerf.default 651 637 1.02:1
BoxMinimalPerf.default 340 338 1.01:1
ButtonMinimalPerf.default 160 159 1.01:1
ButtonOverridesMissPerf.default 1683 1674 1.01:1
DropdownManyItemsPerf.default 656 651 1.01:1
MenuMinimalPerf.default 829 818 1.01:1
MenuButtonMinimalPerf.default 1627 1618 1.01:1
PopupMinimalPerf.default 614 605 1.01:1
ReactionMinimalPerf.default 373 368 1.01:1
AlertMinimalPerf.default 262 263 1:1
AttachmentSlotsPerf.default 1048 1044 1:1
ChatMinimalPerf.default 704 703 1:1
DatepickerMinimalPerf.default 5287 5284 1:1
DividerMinimalPerf.default 351 352 1:1
DropdownMinimalPerf.default 2905 2891 1:1
EmbedMinimalPerf.default 3993 3982 1:1
FlexMinimalPerf.default 277 278 1:1
RosterPerf.default 1174 1179 1:1
RefMinimalPerf.default 232 233 1:1
SplitButtonMinimalPerf.default 4181 4188 1:1
CustomToolbarPrototype.default 3933 3952 1:1
ToolbarMinimalPerf.default 901 900 1:1
TooltipMinimalPerf.default 987 991 1:1
TreeMinimalPerf.default 772 773 1:1
AccordionMinimalPerf.default 144 146 0.99:1
CarouselMinimalPerf.default 471 476 0.99:1
ChatWithPopoverPerf.default 355 360 0.99:1
CheckboxMinimalPerf.default 2609 2625 0.99:1
HeaderMinimalPerf.default 348 351 0.99:1
SliderMinimalPerf.default 1626 1637 0.99:1
IconMinimalPerf.default 610 614 0.99:1
TableManyItemsPerf.default 1829 1845 0.99:1
ImageMinimalPerf.default 356 363 0.98:1
TextMinimalPerf.default 349 355 0.98:1
CardMinimalPerf.default 533 547 0.97:1
ListWith60ListItems.default 591 610 0.97:1
FormMinimalPerf.default 375 390 0.96:1
ListCommonPerf.default 589 620 0.95:1
SkeletonMinimalPerf.default 343 360 0.95:1
LabelMinimalPerf.default 374 397 0.94:1
ButtonSlotsPerf.default 535 579 0.92:1

@GeoffCoxMSFT GeoffCoxMSFT merged commit 9fafa80 into microsoft:master Jan 20, 2022
@GeoffCoxMSFT GeoffCoxMSFT deleted the code-owners-coastal branch April 18, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants