chore: upgrading fast-foundation to v2.32.0 #21443
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 74f2e67:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 05da13bb294d7152dc8bb4e5a5fdc72d502156d3 (build) |
📊 Bundle size reportUnchanged fixtures
|
|
Thanks @robarbms - let's look at why this is failing, but this can come out of draft. |
packages/web-components/package.json
Outdated
| "@microsoft/fast-web-utilities": "^5.0.0", | ||
| "@microsoft/fast-element": "^1.7.0", | ||
| "@microsoft/fast-foundation": "^2.32.0", | ||
| "@microsoft/fast-web-utilities": "^5.0.2", |
packages/web-components/package.json
Outdated
| "@microsoft/fast-element": "^1.6.0", | ||
| "@microsoft/fast-foundation": "^2.27.1", | ||
| "@microsoft/fast-web-utilities": "^5.0.0", | ||
| "@microsoft/fast-element": "^1.7.0", |
There was a problem hiding this comment.
Let's keep this at 1.6.0 if we can.
There was a problem hiding this comment.
I could not get it to build without errors and run unless I updated fast-element and fast-web-utilities. Maybe it was being caused by the yarn.lock file?
There was a problem hiding this comment.
Yeah, I'd do a full rebuild with the yarn.lock file. Just check to ensure only one version of FAST Element is included. If you have trouble building, push up the changes and I can look and advise.
There was a problem hiding this comment.
I think it will pull 2 versions. I was seeing @microsoft/fast-element^1.7.0 and @microsoft/fast-web-utilities^5.0.2 dependencies for @micrsoft/fast-foundation^2.32.0 in the yarn.lock file. Should I upgrade to the last fast-foundation version using fast-element v1.6 and fast-web-utilities v5.0.0?
There was a problem hiding this comment.
You should be able to manually adjust. Yarn is finicky, but you can adjust the lock file manually if need be to ensure proper resolution.
There was a problem hiding this comment.
In some cases for deduplication you can run yarn-deduplicate locally. Just be sure to supply either --packages or --scopes to avoid deduplicating the entire lock file and breaking things.
There was a problem hiding this comment.
Got it building that time. I've pushed an update.
robarbms
requested review from
EisenbergEffect,
nicholasrice and
a team
as code owners
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1139 | 1132 | 5000 | |
| BaseButton | mount | 1174 | 1139 | 5000 | |
| Breadcrumb | mount | 2871 | 2903 | 1000 | |
| ButtonNext | mount | 606 | 594 | 5000 | |
| Checkbox | mount | 1814 | 1784 | 5000 | |
| CheckboxBase | mount | 1535 | 1591 | 5000 | |
| ChoiceGroup | mount | 5498 | 5583 | 5000 | |
| ComboBox | mount | 1119 | 1215 | 1000 | |
| CommandBar | mount | 11305 | 11173 | 1000 | |
| ContextualMenu | mount | 9308 | 9220 | 1000 | |
| DefaultButton | mount | 1296 | 1374 | 5000 | |
| DetailsRow | mount | 4294 | 4316 | 5000 | |
| DetailsRowFast | mount | 4344 | 4312 | 5000 | |
| DetailsRowNoStyles | mount | 4115 | 4098 | 5000 | |
| Dialog | mount | 2890 | 2880 | 1000 | |
| DocumentCardTitle | mount | 216 | 216 | 1000 | |
| Dropdown | mount | 3726 | 3737 | 5000 | |
| FluentProviderNext | mount | 2098 | 2038 | 5000 | |
| FluentProviderWithTheme | mount | 193 | 186 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 136 | 136 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 227 | 220 | 10 | |
| FocusTrapZone | mount | 2082 | 2024 | 5000 | |
| FocusZone | mount | 1999 | 2041 | 5000 | |
| IconButton | mount | 2039 | 2057 | 5000 | |
| Label | mount | 429 | 410 | 5000 | |
| Layer | mount | 3439 | 3469 | 5000 | |
| Link | mount | 583 | 564 | 5000 | |
| MakeStyles | mount | 1789 | 1867 | 50000 | |
| MenuButton | mount | 1757 | 1736 | 5000 | |
| MessageBar | mount | 2202 | 2243 | 5000 | |
| Nav | mount | 3733 | 3722 | 1000 | |
| OverflowSet | mount | 1244 | 1252 | 5000 | |
| Panel | mount | 2826 | 2835 | 1000 | |
| Persona | mount | 987 | 1000 | 1000 | |
| Pivot | mount | 1666 | 1635 | 1000 | |
| PrimaryButton | mount | 1522 | 1489 | 5000 | |
| Rating | mount | 9030 | 8952 | 5000 | |
| SearchBox | mount | 1557 | 1611 | 5000 | |
| Shimmer | mount | 2928 | 3074 | 5000 | |
| Slider | mount | 2215 | 2210 | 5000 | |
| SpinButton | mount | 5613 | 5674 | 5000 | |
| Spinner | mount | 497 | 527 | 5000 | |
| SplitButton | mount | 3603 | 3566 | 5000 | |
| Stack | mount | 634 | 645 | 5000 | |
| StackWithIntrinsicChildren | mount | 2723 | 2783 | 5000 | |
| StackWithTextChildren | mount | 6307 | 6418 | 5000 | |
| SwatchColorPicker | mount | 12981 | 13057 | 5000 | |
| TagPicker | mount | 3014 | 3018 | 5000 | |
| TeachingBubble | mount | 14601 | 14563 | 5000 | |
| Text | mount | 546 | 526 | 5000 | |
| TextField | mount | 1626 | 1635 | 5000 | |
| ThemeProvider | mount | 1330 | 1361 | 5000 | |
| ThemeProvider | virtual-rerender | 708 | 709 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2152 | 2224 | 5000 | |
| Toggle | mount | 934 | 940 | 5000 | |
| buttonNative | mount | 187 | 172 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 235 | 214 | 1.1:1 |
| ButtonMinimalPerf.default | 222 | 205 | 1.08:1 |
| DividerMinimalPerf.default | 453 | 421 | 1.08:1 |
| ChatMinimalPerf.default | 888 | 835 | 1.06:1 |
| SegmentMinimalPerf.default | 431 | 406 | 1.06:1 |
| HeaderMinimalPerf.default | 442 | 421 | 1.05:1 |
| SkeletonMinimalPerf.default | 423 | 403 | 1.05:1 |
| ToolbarMinimalPerf.default | 1132 | 1081 | 1.05:1 |
| AttachmentSlotsPerf.default | 1303 | 1248 | 1.04:1 |
| BoxMinimalPerf.default | 419 | 402 | 1.04:1 |
| DialogMinimalPerf.default | 945 | 907 | 1.04:1 |
| PortalMinimalPerf.default | 204 | 196 | 1.04:1 |
| RadioGroupMinimalPerf.default | 542 | 522 | 1.04:1 |
| ReactionMinimalPerf.default | 455 | 439 | 1.04:1 |
| ButtonOverridesMissPerf.default | 1993 | 1934 | 1.03:1 |
| ButtonSlotsPerf.default | 660 | 642 | 1.03:1 |
| ChatWithPopoverPerf.default | 456 | 444 | 1.03:1 |
| GridMinimalPerf.default | 409 | 398 | 1.03:1 |
| ItemLayoutMinimalPerf.default | 1433 | 1398 | 1.03:1 |
| LabelMinimalPerf.default | 478 | 465 | 1.03:1 |
| SliderMinimalPerf.default | 1887 | 1840 | 1.03:1 |
| StatusMinimalPerf.default | 811 | 790 | 1.03:1 |
| TableManyItemsPerf.default | 2282 | 2218 | 1.03:1 |
| TreeWith60ListItems.default | 209 | 202 | 1.03:1 |
| VideoMinimalPerf.default | 738 | 715 | 1.03:1 |
| AnimationMinimalPerf.default | 628 | 613 | 1.02:1 |
| CarouselMinimalPerf.default | 553 | 544 | 1.02:1 |
| FlexMinimalPerf.default | 340 | 334 | 1.02:1 |
| InputMinimalPerf.default | 1484 | 1458 | 1.02:1 |
| ListNestedPerf.default | 674 | 661 | 1.02:1 |
| LoaderMinimalPerf.default | 786 | 773 | 1.02:1 |
| MenuMinimalPerf.default | 987 | 964 | 1.02:1 |
| IconMinimalPerf.default | 711 | 695 | 1.02:1 |
| TableMinimalPerf.default | 475 | 464 | 1.02:1 |
| TooltipMinimalPerf.default | 1216 | 1188 | 1.02:1 |
| AccordionMinimalPerf.default | 189 | 187 | 1.01:1 |
| DropdownMinimalPerf.default | 3339 | 3310 | 1.01:1 |
| MenuButtonMinimalPerf.default | 1930 | 1909 | 1.01:1 |
| ProviderMergeThemesPerf.default | 1912 | 1887 | 1.01:1 |
| SplitButtonMinimalPerf.default | 4997 | 4937 | 1.01:1 |
| TextMinimalPerf.default | 421 | 418 | 1.01:1 |
| TextAreaMinimalPerf.default | 629 | 622 | 1.01:1 |
| CardMinimalPerf.default | 661 | 662 | 1:1 |
| CheckboxMinimalPerf.default | 3008 | 2998 | 1:1 |
| DatepickerMinimalPerf.default | 6261 | 6244 | 1:1 |
| ListCommonPerf.default | 722 | 720 | 1:1 |
| ListWith60ListItems.default | 736 | 736 | 1:1 |
| PopupMinimalPerf.default | 701 | 703 | 1:1 |
| ProviderMinimalPerf.default | 1304 | 1298 | 1:1 |
| CustomToolbarPrototype.default | 4571 | 4579 | 1:1 |
| ChatDuplicateMessagesPerf.default | 356 | 358 | 0.99:1 |
| EmbedMinimalPerf.default | 4713 | 4743 | 0.99:1 |
| FormMinimalPerf.default | 498 | 504 | 0.99:1 |
| ListMinimalPerf.default | 604 | 608 | 0.99:1 |
| RefMinimalPerf.default | 262 | 264 | 0.99:1 |
| DropdownManyItemsPerf.default | 792 | 807 | 0.98:1 |
| HeaderSlotsPerf.default | 893 | 914 | 0.98:1 |
| LayoutMinimalPerf.default | 421 | 430 | 0.98:1 |
| TreeMinimalPerf.default | 936 | 953 | 0.98:1 |
| AlertMinimalPerf.default | 327 | 336 | 0.97:1 |
| RosterPerf.default | 1357 | 1397 | 0.97:1 |
| AttachmentMinimalPerf.default | 177 | 184 | 0.96:1 |
| ImageMinimalPerf.default | 440 | 458 | 0.96:1 |
There was a problem hiding this comment.
Need @ecraig12345 or @Hotell to take a look on the yarn.lock
|
For some reason all the |
|
Fixed the lock file. @robarbms I'm not sure exactly how this happened (maybe running with |
I didn't run --skip-integrity-check. I'll check my global settings. I'll make sure that it doesn't happen in the future. |
Current Behavior
fast-foundation v2.27.1
New Behavior
fast-foundation v2.32.0
Related Issue(s)
Fixes #