Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onChange event prop to Radio #21901

Closed
wants to merge 2 commits into from

Conversation

behowell
Copy link
Contributor

@behowell behowell commented Mar 1, 2022

New Behavior

@behowell behowell self-assigned this Mar 1, 2022
@behowell behowell requested a review from a team as a code owner March 1, 2022 09:09
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ce8a9fa:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 1, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
175.69 kB
48.974 kB
react-components
react-components: FluentProvider & webLightTheme
32.526 kB
10.645 kB
🤖 This report was generated against fcbdedc99e36f562680ebd2b1a7d422dabd5078b

@size-auditor
Copy link

size-auditor bot commented Mar 1, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: fcbdedc99e36f562680ebd2b1a7d422dabd5078b (build)

@spmonahan
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 872 889 5000
Button mount 539 545 5000
FluentProvider mount 1919 1913 5000
FluentProviderWithTheme mount 283 258 10
FluentProviderWithTheme virtual-rerender 211 245 10
FluentProviderWithTheme virtual-rerender-with-unmount 295 279 10
MakeStyles mount 1572 1578 50000

@spmonahan
Copy link
Contributor

Closed in favor of #22104 (adds change files)

@spmonahan spmonahan closed this Mar 15, 2022
@behowell behowell deleted the radio-onchange branch July 25, 2022 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants