Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update to latest versions of fast-element and fast-foundation for web components #22648

Merged
merged 1 commit into from
Apr 27, 2022
Merged

update to latest versions of fast-element and fast-foundation for web components #22648

merged 1 commit into from
Apr 27, 2022

Conversation

chrisdholt
Copy link
Member

Current Behavior

Updates to the latest version of FAST dependencies.

New Behavior

n/a

Related Issue(s)

n/a

Fixes #

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 26, 2022 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c01151a:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@chrisdholt
Copy link
Member Author

@nicholasrice any idea why API report all of a sudden wants to pull everything - seems unrelated to this PR.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 26, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 924 930 5000
Button mount 570 569 5000
FluentProvider mount 1966 2040 5000
FluentProviderWithTheme mount 256 272 10
FluentProviderWithTheme virtual-rerender 261 257 10
FluentProviderWithTheme virtual-rerender-with-unmount 306 311 10
MakeStyles mount 1544 1564 50000

@size-auditor
Copy link

size-auditor bot commented Apr 26, 2022 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 00d967912b845ab5cbabf22deb6cc6a018433e30 (build)

@chrisdholt chrisdholt force-pushed the users/chhol/update-dependencies-for-fluentui-wc branch from ed8d3f5 to c01151a Compare April 26, 2022 21:46
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 26, 2022 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
priority-overflow
createOverflowManager		 2.936 kB
1.212 kB
react-accordion
Accordion (including children components)		 73.754 kB
22.494 kB
react-avatar
Avatar		 45.196 kB
13.126 kB
react-badge
Badge		 20.965 kB
6.605 kB
react-badge
CounterBadge		 21.918 kB
6.919 kB
react-badge
PresenceBadge		 22.005 kB
6.582 kB
react-button
Button		 32.408 kB
8.986 kB
react-button
CompoundButton		 38.635 kB
10.146 kB
react-button
MenuButton		 34.175 kB
9.567 kB
react-button
SplitButton		 41.431 kB
10.865 kB
react-button
ToggleButton		 43.31 kB
9.921 kB
react-card
Card - All		 57.884 kB
16.524 kB
react-card
Card		 53.169 kB
15.238 kB
react-card
CardFooter		 7.756 kB
3.299 kB
react-card
CardHeader		 9.321 kB
3.816 kB
react-card
CardPreview		 7.728 kB
3.323 kB
react-combobox
Combobox		 60.564 kB
20.751 kB
react-divider
Divider		 15.455 kB
5.57 kB
react-image
Image		 10.179 kB
3.995 kB
react-input
Input		 21.775 kB
7.228 kB
react-label
Label		 8.441 kB
3.541 kB
react-link
Link		 11.176 kB
4.545 kB
react-menu
Menu (including children components)		 110.192 kB
33.528 kB
react-menu
Menu (including selectable components)		 113.367 kB
33.991 kB
react-popover
Popover		 100.693 kB
30.67 kB
react-portal
Portal		 6.272 kB
2.17 kB
react-positioning
usePopper		 23.21 kB
8.084 kB
react-priority-overflow
hooks only		 10.792 kB
4.125 kB
react-provider
FluentProvider		 14.079 kB
5.274 kB
react-select
Select		 16.616 kB
6.281 kB
react-slider
Slider		 25.619 kB
8.287 kB
react-spinbutton
SpinButton		 42.003 kB
11.886 kB
react-spinner
Spinner		 17.224 kB
5.856 kB
react-switch
Switch		 24.333 kB
8.019 kB
react-text
Text - Default		 10.867 kB
4.269 kB
react-text
Text - Wrappers		 14.183 kB
4.61 kB
react-textarea
Textarea		 20.672 kB
7.07 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 30.098 kB
6.657 kB
react-theme
Teams: Light theme		 18.632 kB
5.317 kB
react-tooltip
Tooltip		 42.907 kB
14.761 kB
react-utilities
SSRProvider		 189 B
161 B
🤖 This report was generated against 00d967912b845ab5cbabf22deb6cc6a018433e30

@chrisdholt
Copy link
Member Author

@nicholasrice any idea why API report all of a sudden wants to pull everything - seems unrelated to this PR.

Resolved...odd.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 26, 2022 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 132 120 1.1:1
PortalMinimalPerf.default 152 139 1.09:1
AttachmentMinimalPerf.default 130 120 1.08:1
ImageMinimalPerf.default 322 298 1.08:1
AlertMinimalPerf.default 233 219 1.06:1
DividerMinimalPerf.default 301 284 1.06:1
RefMinimalPerf.default 204 195 1.05:1
StatusMinimalPerf.default 579 555 1.04:1
TextAreaMinimalPerf.default 403 387 1.04:1
AnimationMinimalPerf.default 459 446 1.03:1
ButtonSlotsPerf.default 464 452 1.03:1
ChatWithPopoverPerf.default 309 299 1.03:1
RadioGroupMinimalPerf.default 381 369 1.03:1
SkeletonMinimalPerf.default 291 283 1.03:1
ToolbarMinimalPerf.default 821 794 1.03:1
BoxMinimalPerf.default 282 276 1.02:1
CardMinimalPerf.default 463 456 1.02:1
CarouselMinimalPerf.default 391 382 1.02:1
CheckboxMinimalPerf.default 2284 2240 1.02:1
HeaderMinimalPerf.default 299 294 1.02:1
InputMinimalPerf.default 1105 1087 1.02:1
LabelMinimalPerf.default 318 313 1.02:1
LayoutMinimalPerf.default 292 285 1.02:1
ListMinimalPerf.default 430 423 1.02:1
ListNestedPerf.default 473 462 1.02:1
MenuMinimalPerf.default 726 709 1.02:1
PopupMinimalPerf.default 536 525 1.02:1
ProviderMinimalPerf.default 344 337 1.02:1
TreeMinimalPerf.default 690 677 1.02:1
TreeWith60ListItems.default 140 137 1.02:1
ButtonMinimalPerf.default 136 135 1.01:1
ButtonOverridesMissPerf.default 1257 1243 1.01:1
ChatMinimalPerf.default 612 605 1.01:1
DatepickerMinimalPerf.default 4845 4785 1.01:1
DropdownMinimalPerf.default 2573 2549 1.01:1
HeaderSlotsPerf.default 636 627 1.01:1
ItemLayoutMinimalPerf.default 985 976 1.01:1
ListCommonPerf.default 522 515 1.01:1
LoaderMinimalPerf.default 573 567 1.01:1
SplitButtonMinimalPerf.default 3724 3694 1.01:1
TableMinimalPerf.default 335 331 1.01:1
TextMinimalPerf.default 287 285 1.01:1
CustomToolbarPrototype.default 2322 2303 1.01:1
AvatarMinimalPerf.default 154 154 1:1
DialogMinimalPerf.default 628 630 1:1
EmbedMinimalPerf.default 3450 3446 1:1
FlexMinimalPerf.default 234 235 1:1
FormMinimalPerf.default 334 333 1:1
GridMinimalPerf.default 279 280 1:1
MenuButtonMinimalPerf.default 1416 1423 1:1
ProviderMergeThemesPerf.default 1066 1068 1:1
ReactionMinimalPerf.default 311 312 1:1
SegmentMinimalPerf.default 283 282 1:1
TableManyItemsPerf.default 1612 1617 1:1
TooltipMinimalPerf.default 904 905 1:1
VideoMinimalPerf.default 528 528 1:1
DropdownManyItemsPerf.default 560 566 0.99:1
SliderMinimalPerf.default 1411 1425 0.99:1
AttachmentSlotsPerf.default 902 920 0.98:1
ListWith60ListItems.default 538 550 0.98:1
RosterPerf.default 910 937 0.97:1
IconMinimalPerf.default 494 509 0.97:1
ChatDuplicateMessagesPerf.default 234 245 0.96:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 26, 2022 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 767 787 5000
Breadcrumb mount 2377 2379 1000
Checkbox mount 1276 1285 5000
CheckboxBase mount 1080 1099 5000
ChoiceGroup mount 4078 4060 5000
ComboBox mount 847 853 1000
CommandBar mount 9084 9125 1000
ContextualMenu mount 10131 9940 1000
DefaultButton mount 979 981 5000
DetailsRow mount 3333 3275 5000
DetailsRowFast mount 3312 3324 5000
DetailsRowNoStyles mount 3150 3126 5000
Dialog mount 1918 1918 1000
DocumentCardTitle mount 150 133 1000
Dropdown mount 2825 2831 5000
FocusTrapZone mount 1594 1562 5000
FocusZone mount 1589 1573 5000
IconButton mount 1503 1525 5000
Label mount 296 297 5000
Layer mount 2548 2542 5000
Link mount 405 403 5000
MenuButton mount 1272 1275 5000
MessageBar mount 1831 1830 5000
Nav mount 2823 2820 1000
OverflowSet mount 926 943 5000
Panel mount 1837 1871 1000
Persona mount 871 862 1000
Pivot mount 1250 1261 1000
PrimaryButton mount 1119 1132 5000
Rating mount 6720 6693 5000
SearchBox mount 1128 1127 5000
Shimmer mount 2154 2136 5000
Slider mount 1682 1678 5000
SpinButton mount 4318 4338 5000
Spinner mount 368 363 5000
SplitButton mount 2736 2732 5000
Stack mount 455 453 5000
StackWithIntrinsicChildren mount 1966 1957 5000
StackWithTextChildren mount 4522 4504 5000
SwatchColorPicker mount 10010 10028 5000
TagPicker mount 2307 2298 5000
TeachingBubble mount 82910 83130 5000
Text mount 364 379 5000
TextField mount 1182 1229 5000
ThemeProvider mount 1018 1057 5000
ThemeProvider virtual-rerender 569 560 5000
ThemeProvider virtual-rerender-with-unmount 1623 1646 5000
Toggle mount 681 707 5000
buttonNative mount 114 114 5000

@tudorpopams tudorpopams requested a review from Hotell April 27, 2022 12:18
@chrisdholt chrisdholt merged commit 7b73745 into microsoft:master Apr 27, 2022
@chrisdholt chrisdholt deleted the users/chhol/update-dependencies-for-fluentui-wc branch April 27, 2022 18:41
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
@chrisdholt @marwan38
update to latest versions of fast-element and fast-foundation for web…
14ae37b 
… components (microsoft#22648)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasrice nicholasrice nicholasrice approved these changes

@Hotell Hotell Hotell approved these changes

@EisenbergEffect EisenbergEffect EisenbergEffect approved these changes

Assignees

@miroslavstastny miroslavstastny

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@chrisdholt @fabricteam @EisenbergEffect @Hotell @nicholasrice @miroslavstastny