Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-components) Fix issue loading Color Explorer values #23392

Merged
merged 1 commit into from
Jun 6, 2022

Conversation

bheston
Copy link
Contributor

@bheston bheston commented Jun 3, 2022

Current Behavior

The Color Explorer has been recently incorporated to the web component Storybook site. We discovered the hex values were not always updating correctly.

New Behavior

This fixes a timing or dependency issue for evaluating the hex values for the color recipes.

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 3, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a9be58e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against ec418075aad560a860b394eeb4ba57b2896c1eed

@size-auditor
Copy link

size-auditor bot commented Jun 3, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: ec418075aad560a860b394eeb4ba57b2896c1eed (build)

@bheston bheston merged commit 8949b3e into microsoft:master Jun 6, 2022
marwan38 pushed a commit to marwan38/fluentui that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants