Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve screener configs #24777

Closed
wants to merge 6 commits into from
Closed

Improve screener configs #24777

wants to merge 6 commits into from

Conversation

ralucapelin
Copy link
Contributor

Current Behavior

Northstar screener config file name can cause confusion as it is used only within gulp task.

Screener config files for v8 and v9 are almost identical, yet there are two different files for each version.

New Behavior

Northstar screener config file named appropriately.

V8 and v9 share the same screener config file.

Related Issue(s)

Addresses comments raised in PR #24739

@ralucapelin ralucapelin added the Ready for VR Used to trigger screener checks for PRs label Sep 13, 2022
@size-auditor
Copy link

size-auditor bot commented Sep 13, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e0a0ab1481d0fb64f2a9804376ad17e4f4f8ea01 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 732eea8:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1258 1251 5000
Button mount 910 834 5000
FluentProvider mount 1544 1516 5000
FluentProviderWithTheme mount 567 562 10
FluentProviderWithTheme virtual-rerender 597 517 10
FluentProviderWithTheme virtual-rerender-with-unmount 635 562 10
MakeStyles mount 1887 1860 50000
SpinButton mount 2498 2549 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2022

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AccordionMinimalPerf.default 122 113 1.08:1
AttachmentMinimalPerf.default 129 119 1.08:1
GridMinimalPerf.default 278 266 1.05:1
LabelMinimalPerf.default 318 304 1.05:1
BoxMinimalPerf.default 279 267 1.04:1
CardMinimalPerf.default 449 431 1.04:1
ImageMinimalPerf.default 325 314 1.04:1
ListNestedPerf.default 461 443 1.04:1
SliderMinimalPerf.default 1336 1288 1.04:1
TreeWith60ListItems.default 136 131 1.04:1
AvatarMinimalPerf.default 158 153 1.03:1
CarouselMinimalPerf.default 397 384 1.03:1
HeaderSlotsPerf.default 628 610 1.03:1
ListMinimalPerf.default 430 418 1.03:1
RefMinimalPerf.default 184 179 1.03:1
SkeletonMinimalPerf.default 281 273 1.03:1
AnimationMinimalPerf.default 437 428 1.02:1
ChatMinimalPerf.default 598 588 1.02:1
DividerMinimalPerf.default 290 285 1.02:1
LayoutMinimalPerf.default 290 285 1.02:1
ListWith60ListItems.default 522 512 1.02:1
ProviderMinimalPerf.default 337 330 1.02:1
ReactionMinimalPerf.default 304 299 1.02:1
TableMinimalPerf.default 333 327 1.02:1
TextMinimalPerf.default 290 284 1.02:1
TextAreaMinimalPerf.default 392 383 1.02:1
TreeMinimalPerf.default 673 661 1.02:1
VideoMinimalPerf.default 585 574 1.02:1
ChatWithPopoverPerf.default 306 302 1.01:1
CheckboxMinimalPerf.default 1741 1718 1.01:1
DialogMinimalPerf.default 641 637 1.01:1
DropdownMinimalPerf.default 2231 2215 1.01:1
InputMinimalPerf.default 950 937 1.01:1
LoaderMinimalPerf.default 546 538 1.01:1
RosterPerf.default 1778 1758 1.01:1
RadioGroupMinimalPerf.default 368 365 1.01:1
TooltipMinimalPerf.default 1975 1954 1.01:1
ButtonMinimalPerf.default 130 130 1:1
DatepickerMinimalPerf.default 4748 4743 1:1
HeaderMinimalPerf.default 293 293 1:1
MenuMinimalPerf.default 691 688 1:1
PortalMinimalPerf.default 141 141 1:1
ProviderMergeThemesPerf.default 1059 1055 1:1
SegmentMinimalPerf.default 279 280 1:1
SplitButtonMinimalPerf.default 3598 3608 1:1
TableManyItemsPerf.default 1538 1543 1:1
CustomToolbarPrototype.default 2265 2270 1:1
ToolbarMinimalPerf.default 762 759 1:1
ButtonOverridesMissPerf.default 1076 1082 0.99:1
DropdownManyItemsPerf.default 545 553 0.99:1
EmbedMinimalPerf.default 2998 3038 0.99:1
MenuButtonMinimalPerf.default 1379 1398 0.99:1
PopupMinimalPerf.default 522 525 0.99:1
StatusMinimalPerf.default 549 555 0.99:1
ButtonSlotsPerf.default 449 456 0.98:1
ChatDuplicateMessagesPerf.default 232 236 0.98:1
ItemLayoutMinimalPerf.default 942 960 0.98:1
AttachmentSlotsPerf.default 924 956 0.97:1
FlexMinimalPerf.default 227 233 0.97:1
IconMinimalPerf.default 529 545 0.97:1
FormMinimalPerf.default 299 312 0.96:1
ListCommonPerf.default 493 521 0.95:1
AlertMinimalPerf.default 214 232 0.92:1

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
554 B
348 B
priority-overflow
createOverflowManager
2.936 kB
1.212 kB
react-accordion
Accordion (including children components)
78.914 kB
24.06 kB
react-alert
Alert
83.511 kB
20.921 kB
react-avatar
Avatar
48.381 kB
13.696 kB
react-avatar
AvatarGroup
14.95 kB
5.989 kB
react-avatar
AvatarGroupItem
68.349 kB
19.039 kB
react-badge
Badge
22.6 kB
7.205 kB
react-badge
CounterBadge
23.503 kB
7.497 kB
react-badge
PresenceBadge
24.05 kB
7.067 kB
react-button
Button
36.119 kB
9.647 kB
react-button
CompoundButton
43.144 kB
10.86 kB
react-button
MenuButton
38.737 kB
10.521 kB
react-button
SplitButton
46.136 kB
11.9 kB
react-button
ToggleButton
51.888 kB
11.127 kB
react-card
Card - All
67.002 kB
19.261 kB
react-card
Card
62.684 kB
18.177 kB
react-card
CardFooter
8.561 kB
3.601 kB
react-card
CardHeader
9.604 kB
3.94 kB
react-card
CardPreview
8.662 kB
3.656 kB
react-combobox
Combobox (including child components)
74.636 kB
24.186 kB
react-combobox
Dropdown (including child components)
74.236 kB
24.086 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.939 kB
52.05 kB
react-components
react-components: FluentProvider & webLightTheme
33.359 kB
11.004 kB
react-dialog
Dialog (including children components)
81.048 kB
24.208 kB
react-divider
Divider
16.459 kB
5.902 kB
react-image
Image
10.78 kB
4.264 kB
react-input
Input
23.598 kB
7.661 kB
react-label
Label
9.338 kB
3.86 kB
react-link
Link
11.784 kB
4.867 kB
react-menu
Menu (including children components)
115.735 kB
35.419 kB
react-menu
Menu (including selectable components)
118.934 kB
35.916 kB
react-overflow
hooks only
10.685 kB
4.104 kB
react-popover
Popover
102.938 kB
31.542 kB
react-portal
Portal
10.576 kB
3.875 kB
react-portal-compat
PortalCompatProvider
5.851 kB
1.964 kB
react-positioning
usePositioning
19.7 kB
7.404 kB
react-provider
FluentProvider
15.755 kB
5.883 kB
react-radio
Radio
35.56 kB
11.929 kB
react-radio
RadioGroup
14.248 kB
5.7 kB
react-select
Select
20.846 kB
7.346 kB
react-slider
Slider
31.526 kB
10.046 kB
react-spinbutton
SpinButton
43.943 kB
12.382 kB
react-spinner
Spinner
19.977 kB
6.438 kB
react-switch
Switch
32.097 kB
10.27 kB
react-text
Text - Default
11.782 kB
4.605 kB
react-text
Text - Wrappers
15.092 kB
5.044 kB
react-textarea
Textarea
23.988 kB
8.011 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
29.548 kB
6.434 kB
react-theme
Teams: Light theme
17.452 kB
5.054 kB
react-tooltip
Tooltip
41.502 kB
14.623 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against e0a0ab1481d0fb64f2a9804376ad17e4f4f8ea01

@fabricteam
Copy link
Collaborator

fabricteam commented Sep 13, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1023 1005 5000
Breadcrumb mount 3068 3069 1000
Checkbox mount 2880 2880 5000
CheckboxBase mount 2512 2556 5000
ChoiceGroup mount 5224 5166 5000
ComboBox mount 1029 1024 1000
CommandBar mount 11209 11172 1000
ContextualMenu mount 12687 12731 1000
DefaultButton mount 1269 1299 5000
DetailsRow mount 4174 4230 5000
DetailsRowFast mount 4186 4091 5000
DetailsRowNoStyles mount 4002 3991 5000
Dialog mount 3338 3310 1000
DocumentCardTitle mount 211 202 1000
Dropdown mount 3709 3691 5000
FocusTrapZone mount 2008 1997 5000
FocusZone mount 1939 1908 5000
IconButton mount 2019 2015 5000
Label mount 386 384 5000
Layer mount 4826 4928 5000
Link mount 503 558 5000
MenuButton mount 1703 1671 5000
MessageBar mount 2386 2359 5000
Nav mount 3741 3719 1000
OverflowSet mount 1167 1204 5000
Panel mount 2674 2614 1000
Persona mount 1132 1102 1000
Pivot mount 1654 1575 1000
PrimaryButton mount 1434 1455 5000
Rating mount 8829 8824 5000
SearchBox mount 1520 1480 5000
Shimmer mount 3222 3222 5000
Slider mount 2141 2130 5000
SpinButton mount 5573 5447 5000
Spinner mount 487 485 5000
SplitButton mount 3491 3471 5000
Stack mount 563 602 5000
StackWithIntrinsicChildren mount 2761 2742 5000
StackWithTextChildren mount 6060 6118 5000
SwatchColorPicker mount 13157 12879 5000
TagPicker mount 2976 2942 5000
TeachingBubble mount 103909 103739 5000
Text mount 459 478 5000
TextField mount 1552 1580 5000
ThemeProvider mount 1360 1401 5000
ThemeProvider virtual-rerender 826 810 5000
ThemeProvider virtual-rerender-with-unmount 2176 2197 5000
Toggle mount 869 883 5000
buttonNative mount 155 156 5000

@ralucapelin ralucapelin removed the Ready for VR Used to trigger screener checks for PRs label Sep 14, 2022
@khmakoto khmakoto deleted the improve-screener-configs branch April 11, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants