Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-accordion): migrate to new package structure #25196

Merged
merged 3 commits into from
Oct 14, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@fabricteam
Copy link
Collaborator

fabricteam commented Oct 12, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-accordion
Accordion (including children components)
79.083 kB
24.079 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.827 kB
17.599 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.299 kB
52.51 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 863058740bb2f3e82680db503268b3e937ddf86d

@TristanWatanabe TristanWatanabe marked this pull request as ready for review October 12, 2022 20:45
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner October 12, 2022 20:45
@fabricteam
Copy link
Collaborator

fabricteam commented Oct 12, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1662 1675 5000
Button mount 1209 1139 5000
FluentProvider mount 1972 1954 5000
FluentProviderWithTheme mount 717 728 10
FluentProviderWithTheme virtual-rerender 662 680 10
FluentProviderWithTheme virtual-rerender-with-unmount 716 724 10
MakeStyles mount 2352 2336 50000
SpinButton mount 3298 3212 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 00c68e3:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Oct 12, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 863058740bb2f3e82680db503268b3e937ddf86d (build)

@TristanWatanabe TristanWatanabe merged commit 4f7430e into microsoft:master Oct 14, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-accordion branch October 14, 2022 21:47
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants