Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix(react-northstar): react-portal-compat-context deps mismatch #25317

Conversation

bsunderhus
Copy link
Contributor

@bsunderhus bsunderhus commented Oct 20, 2022

Fix dependencies mismatches manually after release from @fluentui/react-components@9.5.2

@DustyTheBot
Copy link

Warnings
⚠️ There are no updates provided to CHANGELOG. Ensure there are no publicly visible changes introduced by this PR.

Generated by 🚫 dangerJS against b497389

@bsunderhus bsunderhus marked this pull request as ready for review October 20, 2022 09:09
@bsunderhus bsunderhus requested a review from a team as a code owner October 20, 2022 09:09
@bsunderhus bsunderhus enabled auto-merge (squash) October 20, 2022 09:11
@size-auditor
Copy link

size-auditor bot commented Oct 20, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5a6d712ad6e6dc9f654c6635d467104db35e7dca (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b497389:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 5a6d712ad6e6dc9f654c6635d467104db35e7dca

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
IconMinimalPerf.default 581 543 1.07:1
RefMinimalPerf.default 190 181 1.05:1
SkeletonMinimalPerf.default 312 298 1.05:1
AttachmentMinimalPerf.default 128 123 1.04:1
AvatarMinimalPerf.default 168 162 1.04:1
GridMinimalPerf.default 301 290 1.04:1
ListNestedPerf.default 474 457 1.04:1
ButtonSlotsPerf.default 425 413 1.03:1
CarouselMinimalPerf.default 358 349 1.03:1
ListMinimalPerf.default 466 453 1.03:1
StatusMinimalPerf.default 617 597 1.03:1
TextAreaMinimalPerf.default 416 402 1.03:1
BoxMinimalPerf.default 303 297 1.02:1
ChatMinimalPerf.default 646 632 1.02:1
ImageMinimalPerf.default 346 340 1.02:1
PopupMinimalPerf.default 566 553 1.02:1
ReactionMinimalPerf.default 331 324 1.02:1
TreeMinimalPerf.default 704 689 1.02:1
ChatDuplicateMessagesPerf.default 217 215 1.01:1
CheckboxMinimalPerf.default 1547 1534 1.01:1
ItemLayoutMinimalPerf.default 971 964 1.01:1
TableManyItemsPerf.default 1579 1559 1.01:1
CustomToolbarPrototype.default 2186 2155 1.01:1
TooltipMinimalPerf.default 1872 1858 1.01:1
AttachmentSlotsPerf.default 871 873 1:1
ButtonOverridesMissPerf.default 1014 1019 1:1
DropdownManyItemsPerf.default 545 546 1:1
LabelMinimalPerf.default 336 337 1:1
LayoutMinimalPerf.default 316 316 1:1
ListWith60ListItems.default 503 505 1:1
LoaderMinimalPerf.default 517 519 1:1
MenuButtonMinimalPerf.default 1357 1352 1:1
RosterPerf.default 1705 1704 1:1
ProviderMergeThemesPerf.default 988 984 1:1
SegmentMinimalPerf.default 303 304 1:1
TextMinimalPerf.default 299 299 1:1
AnimationMinimalPerf.default 464 467 0.99:1
DatepickerMinimalPerf.default 4780 4832 0.99:1
DialogMinimalPerf.default 686 695 0.99:1
DropdownMinimalPerf.default 2169 2186 0.99:1
EmbedMinimalPerf.default 2640 2661 0.99:1
HeaderSlotsPerf.default 681 686 0.99:1
InputMinimalPerf.default 845 850 0.99:1
ListCommonPerf.default 528 531 0.99:1
MenuMinimalPerf.default 726 733 0.99:1
RadioGroupMinimalPerf.default 385 389 0.99:1
SplitButtonMinimalPerf.default 3284 3306 0.99:1
TableMinimalPerf.default 354 358 0.99:1
AccordionMinimalPerf.default 122 124 0.98:1
CardMinimalPerf.default 454 465 0.98:1
ChatWithPopoverPerf.default 285 290 0.98:1
FlexMinimalPerf.default 250 254 0.98:1
FormMinimalPerf.default 320 326 0.98:1
ProviderMinimalPerf.default 315 320 0.98:1
ToolbarMinimalPerf.default 785 805 0.98:1
TreeWith60ListItems.default 128 131 0.98:1
ButtonMinimalPerf.default 136 140 0.97:1
DividerMinimalPerf.default 308 319 0.97:1
SliderMinimalPerf.default 1220 1258 0.97:1
VideoMinimalPerf.default 606 627 0.97:1
HeaderMinimalPerf.default 315 327 0.96:1
AlertMinimalPerf.default 212 226 0.94:1
PortalMinimalPerf.default 135 144 0.94:1

@bsunderhus bsunderhus merged commit 8bcb3d3 into microsoft:master Oct 20, 2022
@khmakoto khmakoto added Fluent UI react-northstar (v0) Work related to Fluent UI V0 and removed Fluent UI react-northstar labels Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Fluent UI react-northstar (v0) Work related to Fluent UI V0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants