Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-button): migrate to new package structure #25336

Merged
merged 2 commits into from
Oct 21, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@TristanWatanabe TristanWatanabe self-assigned this Oct 21, 2022
@size-auditor
Copy link

size-auditor bot commented Oct 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2cf6f6338447c0e81dd06763e4791972a34b0548 (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit acdb118:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1276 1315 5000
Button mount 946 948 5000
FluentProvider mount 1548 1552 5000
FluentProviderWithTheme mount 635 632 10
FluentProviderWithTheme virtual-rerender 587 601 10
FluentProviderWithTheme virtual-rerender-with-unmount 635 634 10
MakeStyles mount 1914 1908 50000
SpinButton mount 2520 2467 5000

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-alert
Alert
84.688 kB
21.233 kB
react-button
Button
36.849 kB
9.907 kB
react-button
CompoundButton
43.874 kB
11.123 kB
react-button
MenuButton
39.543 kB
10.807 kB
react-button
SplitButton
46.989 kB
12.192 kB
react-button
ToggleButton
52.716 kB
11.381 kB
react-card
Card - All
67.664 kB
19.635 kB
react-card
Card
63.346 kB
18.539 kB
react-card
CardFooter
8.607 kB
3.622 kB
react-card
CardHeader
9.65 kB
3.962 kB
react-card
CardPreview
8.708 kB
3.678 kB
react-components
react-components: Button, FluentProvider & webLightTheme
62.94 kB
17.663 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
189.603 kB
52.909 kB
react-components
react-components: FluentProvider & webLightTheme
33.446 kB
11.033 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 2cf6f6338447c0e81dd06763e4791972a34b0548

@TristanWatanabe TristanWatanabe marked this pull request as ready for review October 21, 2022 19:59
@TristanWatanabe TristanWatanabe requested review from a team and khmakoto as code owners October 21, 2022 19:59
@TristanWatanabe TristanWatanabe merged commit 619b625 into microsoft:master Oct 21, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-button branch October 21, 2022 21:29
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants