chore(react-avatar, avatar-context): migrate to new package structure #25473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 tasks
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 792bd72b19e360afe9ac8e9da298dc3d85776c74 (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 23669cc:
|
📊 Bundle size reportUnchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1282 | 1271 | 5000 | |
| Button | mount | 924 | 917 | 5000 | |
| FluentProvider | mount | 1497 | 1482 | 5000 | |
| FluentProviderWithTheme | mount | 584 | 592 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 542 | 536 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 571 | 580 | 10 | |
| MakeStyles | mount | 1964 | 1944 | 50000 | |
| SpinButton | mount | 2349 | 2337 | 5000 |
khmakoto
approved these changes
Nov 1, 2022
TristanWatanabe
requested review from
a team,
behowell and
sopranopillow
as code owners
ling1726
reviewed
Nov 1, 2022
| @@ -3,10 +3,11 @@ | |||
| bundle-size/ | |||
| config/ | |||
| coverage/ | |||
| e2e/ | |||
| docs/ | |||
There was a problem hiding this comment.
This entire package can actually be deleted
ling1726
approved these changes
Nov 1, 2022
sopranopillow
approved these changes
Nov 1, 2022
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Nov 3, 2022
* master: feat(scripts): improve API violation reporting (microsoft#25356) applying package updates fix: Preventing blanket selectors from Fabric component from being applied via new preventBlanketFontInheritance prop (microsoft#25453) feat(react-infobutton): Add initial implementation (microsoft#25247) chore(react-avatar, avatar-context): migrate to new package structure (microsoft#25473) chore(react-portal, portal-compat, portal-compat-context): migrate to new package structure (microsoft#25481) docs(react-infobutton): Adding component's spec (microsoft#25251) fix(screener-build workflow): scope package to build for v9 VR tests to speed up perf (microsoft#25494) chore(vr-tests-v9): Convert Button VR tests to CSF (microsoft#25108)
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
migrate-converged-pkgwhich reflects updates made in chore(migrate-converged): add functionality to execute various v9 package file restructuring tasks #24458.stories/folder in the root of the package.common/folder and moves contents to newtesting/folderdocs/folder to package root.Issue: