Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vr-tests-v9): Convert Card VR tests to CSF #25526

Merged
merged 6 commits into from
Nov 16, 2022

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Nov 4, 2022

Changes:

  • uses storybook codemod script convert storiesOf stories to CSF:
    npx sb migrate storiesof-to-csf --glob="apps/vr-tests-react-components/src/stories/{ComponentName}/*.stories.tsx"
  • manually adds RTL, Dark Mode and High Contrast story variants via the getStoryVariant function.

Follows pattern set in #25108.

Related Issue(s)

Part of #25078

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 4, 2022

📊 Bundle size report

🤖 This report was generated against e22929a533e0830fc75e547b733b38dee60af00e

@size-auditor
Copy link

size-auditor bot commented Nov 4, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 38cbc51623baf411e5379936c050f0b2c53ecc54 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e9d455:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@TristanWatanabe TristanWatanabe requested a review from a team November 4, 2022 16:07
@TristanWatanabe
Copy link
Member Author

Screener change seems to be a minor crop issue caused by the usage of the withFluentProvider addon which can probably be ignored

@marcosmoura marcosmoura self-requested a review November 10, 2022 13:38
@TristanWatanabe TristanWatanabe merged commit f72f978 into microsoft:master Nov 16, 2022
@TristanWatanabe TristanWatanabe deleted the card-to-csf branch November 16, 2022 20:31
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* chore: convert card stories to csf

* nit: remove unused import

* convert CardSelectable stories to CSF

* fix asset url

* fix: delete old story file

* Add side margins to Appearance stories
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* chore: convert card stories to csf

* nit: remove unused import

* convert CardSelectable stories to CSF

* fix asset url

* fix: delete old story file

* Add side margins to Appearance stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants