Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vr-tests-v9): Convert Badge VR tests to CSF #25539

Merged
merged 5 commits into from
Nov 16, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

  • uses storybook codemod script convert storiesOf stories to CSF:
    npx sb migrate storiesof-to-csf --glob="apps/vr-tests-react-components/src/stories/{ComponentName}/*.stories.tsx"
  • manually adds RTL, Dark Mode and High Contrast story variants via the getStoryVariant function.

Follows pattern set in #25108

Related Issue(s)

Part of #25078

@TristanWatanabe TristanWatanabe requested a review from a team as a code owner November 4, 2022 20:14
@TristanWatanabe TristanWatanabe self-assigned this Nov 4, 2022
@github-actions github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 4, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Nov 4, 2022

📊 Bundle size report

🤖 This report was generated against 131d20e15d6c59dce2dcbbd8794b5ee75701a670

@size-auditor
Copy link

size-auditor bot commented Nov 4, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 131d20e15d6c59dce2dcbbd8794b5ee75701a670 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 4, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4c793a6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@TristanWatanabe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@TristanWatanabe TristanWatanabe requested a review from a team as a code owner November 14, 2022 22:24
@TristanWatanabe TristanWatanabe requested review from khmakoto and removed request for a team November 14, 2022 22:57
@TristanWatanabe TristanWatanabe merged commit 5b8cd50 into microsoft:master Nov 16, 2022
@TristanWatanabe TristanWatanabe deleted the badge-to-csf branch November 16, 2022 19:55
NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022
* chore: convert Badge to CSF

* fix: move CounterBadge to its own subfolder and delete old CounterBadge story file

* Update Avatar.stories.tsx

* Update useArrowNavigationGroup.ts
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* chore: convert Badge to CSF

* fix: move CounterBadge to its own subfolder and delete old CounterBadge story file

* Update Avatar.stories.tsx

* Update useArrowNavigationGroup.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants