chore(.storybook): disable telemetry #25633

Hotell · 2022-11-11T11:21:39Z

Current Behavior

we send data to storybook with every storybook start

New Behavior

no data are sent

Related Issue(s)

discussed 2 months ago on v-build sync

size-auditor · 2022-11-11T11:41:05Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 06d0d5598c28ac70e07d9b9e7d1b77151369d193 (build)

codesandbox-ci · 2022-11-11T11:43:32Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f142dd7:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2022-11-11T11:44:27Z

Perf Analysis (`@fluentui/react-components`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
Avatar	mount	1341	1292	5000
Button	mount	946	959	5000
FluentProvider	mount	1580	1562	5000
FluentProviderWithTheme	mount	621	628	10
FluentProviderWithTheme	virtual-rerender	584	596	10
FluentProviderWithTheme	virtual-rerender-with-unmount	627	617	10
MakeStyles	mount	1902	1931	50000
SpinButton	mount	2565	2524	5000

fabricteam · 2022-11-11T11:48:02Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`533 B` `341 B`
`global-context` createContextSelector	`554 B` `348 B`
`priority-overflow` createOverflowManager	`3.153 kB` `1.299 kB`
`react-accordion` Accordion (including children components)	`79.284 kB` `24.446 kB`
`react-alert` Alert	`86.986 kB` `21.736 kB`
`react-avatar` Avatar	`51.171 kB` `14.313 kB`
`react-avatar` AvatarGroup	`14.996 kB` `6.013 kB`
`react-avatar` AvatarGroupItem	`65.749 kB` `18.412 kB`
`react-badge` Badge	`22.646 kB` `7.228 kB`
`react-badge` CounterBadge	`23.536 kB` `7.512 kB`
`react-badge` PresenceBadge	`24.096 kB` `7.09 kB`
`react-button` Button	`36.85 kB` `9.917 kB`
`react-button` CompoundButton	`43.875 kB` `11.134 kB`
`react-button` MenuButton	`41.527 kB` `11.19 kB`
`react-button` SplitButton	`48.973 kB` `12.592 kB`
`react-button` ToggleButton	`52.675 kB` `11.418 kB`
`react-card` Card - All	`71.863 kB` `20.939 kB`
`react-card` Card	`67.641 kB` `19.897 kB`
`react-card` CardFooter	`8.607 kB` `3.622 kB`
`react-card` CardHeader	`9.782 kB` `3.998 kB`
`react-card` CardPreview	`8.708 kB` `3.678 kB`
`react-combobox` Combobox (including child components)	`78.076 kB` `24.991 kB`
`react-combobox` Dropdown (including child components)	`77.363 kB` `24.893 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`62.941 kB` `17.678 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`189.948 kB` `52.991 kB`
`react-components` react-components: FluentProvider & webLightTheme	`33.446 kB` `11.033 kB`
`react-dialog` Dialog (including children components)	`83.147 kB` `24.799 kB`
`react-divider` Divider	`16.505 kB` `5.925 kB`
`react-image` Image	`10.826 kB` `4.286 kB`
`react-infobutton` InfoButton	`117.928 kB` `35.402 kB`
`react-input` Input	`24.112 kB` `7.892 kB`
`react-label` Label	`9.384 kB` `3.883 kB`
`react-link` Link	`11.852 kB` `4.888 kB`
`react-menu` Menu (including children components)	`117.131 kB` `36.2 kB`
`react-menu` Menu (including selectable components)	`120.2 kB` `36.726 kB`
`react-overflow` hooks only	`11.004 kB` `4.188 kB`
`react-persona` Persona	`56.289 kB` `15.712 kB`
`react-popover` Popover	`103.672 kB` `31.871 kB`
`react-portal` Portal	`10.495 kB` `3.851 kB`
`react-portal-compat` PortalCompatProvider	`5.857 kB` `1.978 kB`
`react-positioning` usePositioning	`19.826 kB` `7.417 kB`
`react-progress` Progress	`13.526 kB` `5.113 kB`
`react-provider` FluentProvider	`15.807 kB` `5.909 kB`
`react-radio` Radio	`36.436 kB` `12.126 kB`
`react-radio` RadioGroup	`14.294 kB` `5.723 kB`
`react-select` Select	`23.428 kB` `8.023 kB`
`react-slider` Slider	`32.108 kB` `10.195 kB`
`react-spinbutton` SpinButton	`44.42 kB` `12.815 kB`
`react-spinner` Spinner	`20.003 kB` `6.449 kB`
`react-switch` Switch	`33.443 kB` `10.585 kB`
`react-text` Text - Default	`11.828 kB` `4.627 kB`
`react-text` Text - Wrappers	`15.138 kB` `5.064 kB`
`react-textarea` Textarea	`25.687 kB` `8.331 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`29.65 kB` `6.444 kB`
`react-theme` Teams: Light theme	`17.486 kB` `5.057 kB`
`react-tooltip` Tooltip	`42.032 kB` `14.739 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 06d0d5598c28ac70e07d9b9e7d1b77151369d193}

fabricteam · 2022-11-11T11:50:06Z

Perf Analysis (`@fluentui/react-northstar`)

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
AvatarMinimalPerf.default	169	156	1.08:1
GridMinimalPerf.default	313	292	1.07:1
RadioGroupMinimalPerf.default	402	381	1.06:1
ButtonMinimalPerf.default	139	132	1.05:1
LayoutMinimalPerf.default	319	305	1.05:1
IconMinimalPerf.default	588	558	1.05:1
TreeWith60ListItems.default	137	131	1.05:1
TableMinimalPerf.default	363	350	1.04:1
AttachmentMinimalPerf.default	132	128	1.03:1
DropdownManyItemsPerf.default	548	530	1.03:1
ReactionMinimalPerf.default	337	326	1.03:1
ButtonSlotsPerf.default	428	420	1.02:1
DialogMinimalPerf.default	695	683	1.02:1
FlexMinimalPerf.default	250	245	1.02:1
ImageMinimalPerf.default	346	338	1.02:1
ListNestedPerf.default	476	465	1.02:1
LoaderMinimalPerf.default	267	263	1.02:1
MenuMinimalPerf.default	739	727	1.02:1
RosterPerf.default	1708	1677	1.02:1
PortalMinimalPerf.default	141	138	1.02:1
StatusMinimalPerf.default	612	600	1.02:1
CustomToolbarPrototype.default	2178	2142	1.02:1
AnimationMinimalPerf.default	474	469	1.01:1
ButtonOverridesMissPerf.default	1024	1015	1.01:1
ChatDuplicateMessagesPerf.default	216	214	1.01:1
ChatWithPopoverPerf.default	291	289	1.01:1
HeaderSlotsPerf.default	682	677	1.01:1
ItemLayoutMinimalPerf.default	966	953	1.01:1
ListMinimalPerf.default	458	452	1.01:1
TextMinimalPerf.default	297	293	1.01:1
TextAreaMinimalPerf.default	404	401	1.01:1
TreeMinimalPerf.default	703	693	1.01:1
BoxMinimalPerf.default	299	298	1:1
CheckboxMinimalPerf.default	1530	1524	1:1
DropdownMinimalPerf.default	2172	2172	1:1
EmbedMinimalPerf.default	2639	2648	1:1
LabelMinimalPerf.default	344	343	1:1
ListWith60ListItems.default	497	498	1:1
PopupMinimalPerf.default	551	551	1:1
ProviderMergeThemesPerf.default	981	981	1:1
ProviderMinimalPerf.default	318	317	1:1
SegmentMinimalPerf.default	309	308	1:1
SplitButtonMinimalPerf.default	3264	3261	1:1
ToolbarMinimalPerf.default	792	793	1:1
AttachmentSlotsPerf.default	867	874	0.99:1
CardMinimalPerf.default	458	461	0.99:1
ChatMinimalPerf.default	630	637	0.99:1
FormMinimalPerf.default	315	318	0.99:1
HeaderMinimalPerf.default	311	315	0.99:1
ListCommonPerf.default	510	513	0.99:1
MenuButtonMinimalPerf.default	1337	1346	0.99:1
RefMinimalPerf.default	185	186	0.99:1
SkeletonMinimalPerf.default	301	305	0.99:1
TableManyItemsPerf.default	1550	1559	0.99:1
AlertMinimalPerf.default	227	231	0.98:1
DatepickerMinimalPerf.default	4568	4684	0.98:1
InputMinimalPerf.default	845	858	0.98:1
SliderMinimalPerf.default	1224	1244	0.98:1
CarouselMinimalPerf.default	342	351	0.97:1
DividerMinimalPerf.default	304	312	0.97:1
TooltipMinimalPerf.default	1846	1906	0.97:1
VideoMinimalPerf.default	602	624	0.96:1
AccordionMinimalPerf.default	116	129	0.9:1

fabricteam · 2022-11-11T11:58:42Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	1244	1243	5000
Breadcrumb	mount	3070	3030	1000
Checkbox	mount	2651	2681	5000
CheckboxBase	mount	2407	2410	5000
ChoiceGroup	mount	4318	4300	5000
ComboBox	mount	1178	1215	1000
CommandBar	mount	9584	9590	1000
ContextualMenu	mount	11889	11785	1000
DefaultButton	mount	1367	1355	5000
DetailsRow	mount	3421	3365	5000
DetailsRowFast	mount	3443	3421	5000
DetailsRowNoStyles	mount	3259	3246	5000
Dialog	mount	3030	2998	1000
DocumentCardTitle	mount	582	589	1000
Dropdown	mount	3181	3236	5000
FocusTrapZone	mount	2000	1964	5000
FocusZone	mount	1984	1946	5000
GroupedList	mount	1887	2125	2
GroupedList	virtual-rerender	1133	1118	2
GroupedList	virtual-rerender-with-unmount	1630	1648	2
GroupedListV2	mount	587	571	2
GroupedListV2	virtual-rerender	549	567	2
GroupedListV2	virtual-rerender-with-unmount	570	571	2
IconButton	mount	1801	1808	5000
Label	mount	758	771	5000
Layer	mount	4200	4187	5000
Link	mount	859	873	5000
MenuButton	mount	1615	1623	5000
MessageBar	mount	2310	2384	5000
Nav	mount	3107	3080	1000
OverflowSet	mount	1429	1423	5000
Panel	mount	2553	2496	1000
Persona	mount	1266	1281	1000
Pivot	mount	1555	1535	1000
PrimaryButton	mount	1511	1486	5000
Rating	mount	7104	7095	5000
SearchBox	mount	1512	1512	5000
Shimmer	mount	2897	2923	5000
Slider	mount	2118	2137	5000
SpinButton	mount	4372	4315	5000
Spinner	mount	838	824	5000
SplitButton	mount	2914	2897	5000
Stack	mount	876	885	5000
StackWithIntrinsicChildren	mount	2375	2388	5000
StackWithTextChildren	mount	5087	5075	5000
SwatchColorPicker	mount	9561	9720	5000
TagPicker	mount	2388	2368	5000
TeachingBubble	mount	87334	88978	5000
Text	mount	836	829	5000
TextField	mount	1576	1575	5000
ThemeProvider	mount	1474	1450	5000
ThemeProvider	virtual-rerender	1140	1155	5000
ThemeProvider	virtual-rerender-with-unmount	1995	1985	5000
Toggle	mount	1129	1123	5000
buttonNative	mount	539	547	5000

Hotell · 2022-11-11T16:31:31Z

/azp run

azure-pipelines · 2022-11-11T16:31:55Z

Azure Pipelines successfully started running 3 pipeline(s).

Hotell · 2022-11-11T16:55:09Z

/azp run

azure-pipelines · 2022-11-11T16:55:26Z

Azure Pipelines successfully started running 3 pipeline(s).

* generate changefiles

Hotell requested review from chrisdholt, EisenbergEffect, nicholasrice and a team as code owners November 11, 2022 11:21

Hotell enabled auto-merge (squash) November 11, 2022 11:21

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 11, 2022

msft-fluent-ui-bot assigned smhigley Nov 11, 2022

Hotell added Area: Build System Storybook labels Nov 11, 2022

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 11, 2022

Hotell unassigned smhigley Nov 11, 2022

Hotell force-pushed the hotell/build/storybook/turn-off-telemetry branch from 92b653e to 06442c0 Compare November 11, 2022 11:28

Hotell requested a review from a team as a code owner November 11, 2022 11:28

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 11, 2022

Hotell removed this from the October Project Cycle Q4 2022 milestone Nov 11, 2022

Hotell closed this Nov 11, 2022

auto-merge was automatically disabled November 11, 2022 12:50
Pull request was closed

Hotell reopened this Nov 11, 2022

github-actions bot added this to the October Project Cycle Q4 2022 milestone Nov 11, 2022

chore(.storybook): disable telemetry

f67dc5f

generate changefiles

f142dd7

Hotell force-pushed the hotell/build/storybook/turn-off-telemetry branch from 2d84231 to f142dd7 Compare November 11, 2022 18:14

spmonahan approved these changes Nov 11, 2022

View reviewed changes

ling1726 approved these changes Nov 14, 2022

View reviewed changes

Hotell enabled auto-merge (squash) November 14, 2022 12:57

EisenbergEffect approved these changes Nov 14, 2022

View reviewed changes

Hotell merged commit d419dfa into microsoft:master Nov 14, 2022

NotWoods pushed a commit to NotWoods/fluentui that referenced this pull request Nov 18, 2022

chore(.storybook): disable telemetry (microsoft#25633)

39505f7

* generate changefiles

Hotell added a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023

chore(.storybook): disable telemetry (microsoft#25633)

3ad50ef

* generate changefiles

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(.storybook): disable telemetry #25633

chore(.storybook): disable telemetry #25633

Hotell commented Nov 11, 2022

size-auditor bot commented Nov 11, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 11, 2022 •

edited

Loading

fabricteam commented Nov 11, 2022 •

edited

Loading

fabricteam commented Nov 11, 2022 •

edited

Loading

fabricteam commented Nov 11, 2022 •

edited

Loading

fabricteam commented Nov 11, 2022 •

edited

Loading

Hotell commented Nov 11, 2022

azure-pipelines bot commented Nov 11, 2022

Hotell commented Nov 11, 2022

azure-pipelines bot commented Nov 11, 2022

chore(.storybook): disable telemetry #25633

chore(.storybook): disable telemetry #25633

Conversation

Hotell commented Nov 11, 2022

Current Behavior

New Behavior

Related Issue(s)

size-auditor bot commented Nov 11, 2022 • edited Loading

Asset size changes

codesandbox-ci bot commented Nov 11, 2022 • edited Loading

fabricteam commented Nov 11, 2022 • edited Loading

Perf Analysis (@fluentui/react-components)

fabricteam commented Nov 11, 2022 • edited Loading

📊 Bundle size report

fabricteam commented Nov 11, 2022 • edited Loading

Perf Analysis (@fluentui/react-northstar)

fabricteam commented Nov 11, 2022 • edited Loading

Perf Analysis (@fluentui/react)

Hotell commented Nov 11, 2022

azure-pipelines bot commented Nov 11, 2022

Hotell commented Nov 11, 2022

azure-pipelines bot commented Nov 11, 2022

size-auditor bot commented Nov 11, 2022 •

edited

Loading

codesandbox-ci bot commented Nov 11, 2022 •

edited

Loading

fabricteam commented Nov 11, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Nov 11, 2022 •

edited

Loading

fabricteam commented Nov 11, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Nov 11, 2022 •

edited

Loading

Perf Analysis (`@fluentui/react`)