chore(v0 docs): Add storybook stories that reference docsite examples for 1JS VR tool migration #25663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
This reverts commit 50f4eb3.
TristanWatanabe
commented
Nov 30, 2022
| "lint": "eslint --ext .js,.ts,.tsx .", | ||
| "lint:fix": "yarn lint --fix", | ||
| "start": "gulp docs", | ||
| "screener:build": "yarn build:storybook", |
There was a problem hiding this comment.
Using the name screener here to simplify and align with current template we have while running the VR tool. Will be renamed (along with others) once we completely remove screener.
ling1726
approved these changes
Nov 30, 2022
khmakoto
added
Fluent UI react-northstar (v0)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Dec 2, 2022
* master: fix: Pressed and Hover states for toolbar buttons (microsoft#25835) feat: add large size for toolbar (microsoft#25830) applying package updates adding perf test for Persona (microsoft#25863) fix: Fixing Slider's programmatic focus (microsoft#25869) chore(v0 docs): Add storybook stories that reference docsite examples for 1JS VR tool migration (microsoft#25663) fix: Respecting user-provided ids in ComboBox options (microsoft#25867) refactor(scripts): more domain boundaries encapsulation (microsoft#25851) docs: add documentation about how to migrate V0 createSvgIcon (microsoft#25828) support cross story linking and create example in Menu story (microsoft#25850)
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
… for 1JS VR tool migration (microsoft#25663)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Story:
react-northstarVR test setup is incompatible with 1JS's tool because it does not use storybook. 1JS's toolStoryWrightheavily relies on storybook stories to work correctly. In an effort to reduce as much friction as possible, the following changes below were made to simplify the transition from Screener to 1JS's VR tool forreact-northstarChanges:
vr-testssubfolder to house.stories.tsxfiles to be used by the new 1JS VR Tool.Screenertests from@fluentui/docsexamplespackages/fluentui/docs/examples/components/**that don't have any special.steps.suffix in its file name are combined together in a{ComponentName}.stories.tsxfile and all those components are re-exported as stories (example).packages/fluentui/docs/examples/components/**that contain.steps.in its filename will have its own separate{fileName}.stories.tsxfile created where its wrapped by a decorator that contains those specificsteps(example).Themevariants are handled by thegetThemeStoryVariantutility function which returns a story with the appropriateThemeprovider decorator. Component examples that had theALL_THEMESconfig in their corresponding.steps.file use thegetThemeStoryVariantutility in their new.stories.file to provide same functionality (example).main.jsandpreview.jsfilesstart:storybookandbuild:storybookscripts topackage.jsonRelated Issue(s)
Part of #25078