Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a check whether to run vr tests based on affected packages check #25676

Merged
merged 110 commits into from
Nov 16, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
110 commits
Select commit Hold shift + click to select a range
bbb79fa
Update azure-pipelines.yml for Azure Pipelines
sunilsurana Oct 6, 2022
f45d0c3
storywright tests
sunilsurana Oct 7, 2022
4928f2d
Merge pull request #1 from sunilsurana/susurana/storywright
sunilsurana Oct 7, 2022
2c105b7
Update azure-pipelines.yml for Azure Pipelines
sunilsurana Oct 7, 2022
05869e7
Update azure-pipelines.yml for Azure Pipelines
sunilsurana Oct 7, 2022
54dd43e
Update azure-pipelines.yml for Azure Pipelines
sunilsurana Oct 9, 2022
4df01bc
Update azure-pipelines.yml for Azure Pipelines
sunilsurana Oct 9, 2022
f41bd23
Update azure-pipelines.yml for Azure Pipelines
sunilsurana Oct 9, 2022
811f617
Set up CI with Azure Pipelines
sunilsurana Oct 11, 2022
0ce7f19
update
sunilsurana Oct 12, 2022
a610b33
update
sunilsurana Oct 12, 2022
4fd95a7
Merge branch 'master' into susurana/storywright
sunilsurana Oct 12, 2022
b50a509
update
sunilsurana Oct 12, 2022
d88034f
update
sunilsurana Oct 12, 2022
314dbd8
update
sunilsurana Oct 12, 2022
7ce33e7
update
sunilsurana Oct 12, 2022
a72b5b2
update
sunilsurana Oct 12, 2022
d14b3a8
update
sunilsurana Oct 12, 2022
f39bbf7
update
sunilsurana Oct 12, 2022
68d799b
update
sunilsurana Oct 12, 2022
7469281
package
sunilsurana Oct 12, 2022
740786d
update
sunilsurana Oct 12, 2022
b03d93d
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
dc5e39b
Update README.md
sunilsurana Oct 18, 2022
5063dfa
Merge pull request #9 from sunilsurana/tmp3
sunilsurana Oct 18, 2022
db1b63d
Update README.md
sunilsurana Oct 18, 2022
87a6f07
Update README.md
sunilsurana Oct 18, 2022
a601cae
Update README.md
sunilsurana Oct 18, 2022
3604361
Merge pull request #10 from sunilsurana/aa1
sunilsurana Oct 18, 2022
97a7cc1
Merge pull request #12 from sunilsurana/aa2
sunilsurana Oct 18, 2022
392a7ca
Merge pull request #11 from sunilsurana/aa3
sunilsurana Oct 18, 2022
a6d649b
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
566f5ed
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
34f60d6
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
ebf5ca1
update ubuntu
sunilsurana Oct 18, 2022
2ddad41
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
ba22f38
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
d345137
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
a27c089
Update main.js
sunilsurana Oct 18, 2022
c2ab7b1
Merge pull request #14 from sunilsurana/a1
sunilsurana Oct 18, 2022
ccfc0ad
Update baseline.yml for Azure Pipelines
sunilsurana Oct 18, 2022
80a9d6e
Merge remote-tracking branch 'origin' into susurana/storywright
Oct 21, 2022
7e7b95b
Merge pull request #5 from sunilsurana/susurana/storywright
sunilsurana Oct 21, 2022
f2729f0
update
Oct 21, 2022
553564c
update
Oct 21, 2022
dc3214f
Update devcontainer.json
sunilsurana Oct 24, 2022
6328e28
Merge remote-tracking branch 'upstream/master'
sunilsurana Oct 26, 2022
b8581fd
update yarn lock
sunilsurana Oct 26, 2022
ab55b39
update
sunilsurana Oct 26, 2022
d9a6111
pipeline changes
Oct 27, 2022
e938790
update pipeline names (#15)
sunilsurana Oct 27, 2022
62d84e3
conflict resolved
Oct 27, 2022
33247e5
yarn lock modified
Oct 27, 2022
001885b
sync changes (#17)
sunilsurana Oct 27, 2022
218c55a
added comments
Oct 27, 2022
58df489
master merge
Oct 27, 2022
112acc3
renamed foldername
Oct 27, 2022
d82c3ff
commented build step
Oct 27, 2022
dc87c95
added static last known good build
Oct 27, 2022
a356079
removed step
Oct 27, 2022
62fb2ac
Merge pull request #16 from sunilsurana/user/pshrivastav/vrscreenshot…
piyush-2712 Oct 27, 2022
c5ae72e
dynamic lkgCI build
Oct 27, 2022
5407ff4
Merge pull request #19 from sunilsurana/user/pshrivastav/vrscreenshot…
piyush-2712 Oct 27, 2022
7eecb3b
Update azure-pipelines.vrt-baseline.yml for Azure Pipelines
sunilsurana Oct 27, 2022
87fd129
test
Oct 27, 2022
c90baf7
yml update
Oct 27, 2022
55900e4
test commit
Oct 28, 2022
20732df
test
Oct 31, 2022
2238679
test
Oct 31, 2022
525c2af
test
Oct 31, 2022
4d1d3c0
test
Oct 31, 2022
13c886b
test1
Oct 31, 2022
eafc694
test
Nov 1, 2022
6d0710b
test
Nov 1, 2022
4446e90
test
Nov 1, 2022
eb46df0
testing test branch
Nov 1, 2022
2c2442b
test
Nov 1, 2022
a113259
test
Nov 1, 2022
4bb91ab
pat token change
Nov 1, 2022
cac4860
test commit
Nov 1, 2022
16b044e
test commit
Nov 1, 2022
2eb737b
removed unwanted changes
Nov 2, 2022
255c4ea
added baseline variable
Nov 2, 2022
f88b530
removed unwanted code
Nov 2, 2022
232800d
Merge pull request #26 from sunilsurana/user/pshrivastav/testbranch-v4
piyush-2712 Nov 2, 2022
f999d1c
Merge remote-tracking branch 'upstream/master'
sunilsurana Nov 2, 2022
42ded9e
update to sync with master
sunilsurana Nov 2, 2022
4aa8ccc
remove unwanted files
sunilsurana Nov 2, 2022
ecb1c22
yml, package.json change update
Nov 3, 2022
2d36782
Merge pull request #27 from sunilsurana/user/pshrivastav/octokit-vers…
piyush-2712 Nov 3, 2022
1db4120
Merge remote-tracking branch 'upstream/master'
sunilsurana Nov 7, 2022
5e0639e
remove whitespace
sunilsurana Nov 7, 2022
c997f32
remove whitespace
sunilsurana Nov 7, 2022
6f46de0
update
sunilsurana Nov 7, 2022
b7c3f8f
remove duplicate
sunilsurana Nov 7, 2022
d47412a
updatE
sunilsurana Nov 7, 2022
50edb97
change package order
sunilsurana Nov 8, 2022
aed0db1
update to recursively replace screener tag
sunilsurana Nov 10, 2022
99683c3
Mastercopy4 (#31)
sunilsurana Nov 12, 2022
eb44f82
update
sunilsurana Nov 12, 2022
debc97e
pull from master
sunilsurana Nov 12, 2022
639c7d8
merge from master
sunilsurana Nov 12, 2022
6feff10
update storywright version (#33)
sunilsurana Nov 12, 2022
1db3cfb
code review comments
sunilsurana Nov 14, 2022
f8a43c9
pr review comment
sunilsurana Nov 14, 2022
7af6ad0
code review comments
sunilsurana Nov 14, 2022
e35279f
Vrtestcheck (#36)
sunilsurana Nov 15, 2022
4a3c22c
merge from master
sunilsurana Nov 15, 2022
7e24e2e
Merge remote-tracking branch 'upstream/master'
sunilsurana Nov 16, 2022
0e345de
removecheck (#37)
sunilsurana Nov 16, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions .devops/templates/runpublishvrscreenshot.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,54 @@ steps:
filePath: yarn-ci.sh
displayName: yarn (install packages)

- script: |
isPR=${{lower(eq(variables['Build.Reason'], 'PullRequest'))}}
echo $isPR
if [[ $isPR == true ]]; then
packageAffected=$(yarn --silent check:affected-package --packages ${{ parameters.vrTestPackageName }} --pr=true)
if [[ $packageAffected == false ]]; then
echo "In PR pipeline but NOT affecting test package. Skipping test run"
echo "##vso[task.setvariable variable=vrTestSkip;]yes"
else
echo "In PR pipeline and affecting test package. NOT Skipping test run"
echo "##vso[task.setvariable variable=vrTestSkip;]no"
fi
else
echo "Not in PR pipeline. NOT Skipping test run"
echo "##vso[task.setvariable variable=vrTestSkip;]no"
fi
displayName: Check if vrTests should be skipped

- script: |
yarn workspace ${{ parameters.vrTestPackageName }} convert
displayName: Convert screener component to storywright
condition: eq(variables['vrTestSkip'], 'no')

- ${{ if eq(parameters.shouldBuildstorybookaddon, 'true') }}:
- script: |
yarn build --to @fluentui/react-storybook-addon
displayName: Build react-storybook-addon
condition: eq(variables['vrTestSkip'], 'no')

- script: |
yarn workspace ${{ parameters.vrTestPackageName }} screener:build
displayName: Build VR tests components package
condition: eq(variables['vrTestSkip'], 'no')

- script: |
yarn workspace ${{ parameters.vrTestPackageName }} test:component --verbose
displayName: 'Run VR tests'
condition: eq(variables['vrTestSkip'], 'no')

- script: |
mkdir -p screenshots
cp -rf ${{ parameters.vrTestPackagePath }}/dist/screenshots/*.png screenshots/
displayName: Collate Artifacts
condition: eq(variables['vrTestSkip'], 'no')

- task: PublishBuildArtifacts@1
inputs:
PathtoPublish: 'screenshots'
ArtifactName: 'vrscreenshot${{ parameters.fluentVersion }}'
publishLocation: 'Container'
condition: eq(variables['vrTestSkip'], 'no')
10 changes: 10 additions & 0 deletions azure-pipelines.vrt-pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,9 @@ jobs:
workspace:
clean: all
steps:
- checkout: self
fetchDepth: 0

- template: .devops/templates/tools.yml

- bash: |
Expand Down Expand Up @@ -73,6 +76,7 @@ jobs:
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
BASELINE_PIPELINE_ID: $(BASELINE-PIPELINE-ID)
condition: eq(variables['vrTestSkip'], 'no')

- bash: node node_modules/vrscreenshotdiff/lib/index.js pr --clientType "fluentuiv9" --buildId $(Build.BuildId) --lkgCIBuild $(LatestBuildId) --pipelineId $(pipelineId) --pipelineName '$(pipelineName)'
displayName: 'Run fluentui-screenshotdiff'
Expand All @@ -87,6 +91,7 @@ jobs:
STORAGE_KEY_FLUENTUI: $(STORAGE-KEY-BLOB-FLUENTUI)
BLOB_CONNECTION_STRING: $(BLOB-CONNECTION-STRING)
VR_APPROVAL_CLIENT_SECRET: $(VR-APPROVAL-CLIENT-SECRET)
condition: eq(variables['vrTestSkip'], 'no')

- job: VisualRegressionTest_V8
variables:
Expand All @@ -95,6 +100,9 @@ jobs:
workspace:
clean: all
steps:
- checkout: self
fetchDepth: 0

- template: .devops/templates/tools.yml

- bash: |
Expand Down Expand Up @@ -145,6 +153,7 @@ jobs:
env:
SYSTEM_ACCESSTOKEN: $(System.AccessToken)
BASELINE_PIPELINE_ID: $(BASELINE-PIPELINE-ID)
condition: eq(variables['vrTestSkip'], 'no')

- bash: node node_modules/vrscreenshotdiff/lib/index.js pr --clientType "fluentuiv8" --buildId $(Build.BuildId) --lkgCIBuild $(LatestBuildId) --pipelineId $(pipelineId) --pipelineName '$(pipelineName)'
displayName: 'Run fluentui-screenshotdiff'
Expand All @@ -159,3 +168,4 @@ jobs:
STORAGE_KEY_FLUENTUI: $(STORAGE-KEY-BLOB-FLUENTUI)
BLOB_CONNECTION_STRING: $(BLOB-CONNECTION-STRING)
VR_APPROVAL_CLIENT_SECRET: $(VR-APPROVAL-CLIENT-SECRET)
condition: eq(variables['vrTestSkip'], 'no')