fix(react-file-type-icons): return correct icon name for documentsFolder #25688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 9066dc6a278db9df1fe3a277e66c94c201107d14 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8009f15:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 9066dc6a278db9df1fe3a277e66c94c201107d14 (build) |
bigbadcapers
approved these changes
Nov 16, 2022
NotWoods
pushed a commit
to NotWoods/fluentui
that referenced
this pull request
Nov 18, 2022
…der (microsoft#25688) * fix(react-file-type-icons): return correct icon name for documentsFolder * add change file
Hotell
pushed a commit
to Hotell/fluentui
that referenced
this pull request
Feb 9, 2023
…der (microsoft#25688) * fix(react-file-type-icons): return correct icon name for documentsFolder * add change file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Use
FileIconType.documentsFolderdoesn't show anything.New Behavior
Fixed icon name for
FileIconType.documentsFolder, and added a unit test to verify.Related Issue(s)
Fixes #25646