Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-persona): migrate to new package structure #25737

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@size-auditor
Copy link

size-auditor bot commented Nov 21, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 3ca7917d818ccde26b1dc172241f88a6e8f322b3 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 21, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
62.975 kB
17.687 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
190.427 kB
53.087 kB
react-components
react-components: FluentProvider & webLightTheme
33.48 kB
11.037 kB
react-persona
Persona
57.131 kB
15.951 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against 3ca7917d818ccde26b1dc172241f88a6e8f322b3

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7887ebb:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 21, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1457 1458 5000
Button mount 1053 1039 5000
FluentProvider mount 1775 1768 5000
FluentProviderWithTheme mount 705 717 10
FluentProviderWithTheme virtual-rerender 668 673 10
FluentProviderWithTheme virtual-rerender-with-unmount 704 694 10
MakeStyles mount 2136 2125 50000
SpinButton mount 2833 2881 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Nov 21, 2022

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 2 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1749 screenshots unchanged, 0 screenshots with different dimensions and 2 screenshots with visible difference.

unknown 2 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.size+active+badge.normal.chromium.png 9 Changed
Avatar Converged.size+active+ring-shadow.normal.chromium.png 11 Changed

@TristanWatanabe
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 4 pipeline(s).

@TristanWatanabe TristanWatanabe marked this pull request as ready for review November 21, 2022 19:01
@TristanWatanabe TristanWatanabe merged commit fafaced into microsoft:master Nov 22, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-persona branch November 22, 2022 20:25
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants