Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore (v9 vr-tests): Remove usage of Screener #25980

Merged

Conversation

TristanWatanabe
Copy link
Member

Changes:

  • removes Screener specific configs.
  • removes Screener related dependencies from package.json.
  • Replaces Screener tags with StoryWright tags,
  • Replaces screener related imports with storywright.

Related Issue(s)

@TristanWatanabe TristanWatanabe self-assigned this Dec 13, 2022
@fabricteam
Copy link
Collaborator

fabricteam commented Dec 13, 2022

📊 Bundle size report

🤖 This report was generated against 3ec3c7736e16e84dc94c85f6fbb71b5d0177a5e7

@size-auditor
Copy link

size-auditor bot commented Dec 13, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 97c1c1ab218afb20e37bfc35936fd88177d439b4 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 13, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b7f3a08:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@TristanWatanabe TristanWatanabe marked this pull request as ready for review December 13, 2022 20:24
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner December 13, 2022 20:24
"convert": "bash convertStoriesToStoryWright.sh",
"clean": "just-scripts clean",
"format": "prettier . -w --ignore-path ../../.prettierignore",
"lint": "just-scripts lint",
"screener": "just-scripts screener",
"screener:build": "yarn build",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

screener:build will be renamed in a separate PR along with other miscellaneous changes

@TristanWatanabe TristanWatanabe merged commit 0d8c7dc into microsoft:master Dec 20, 2022
@TristanWatanabe TristanWatanabe deleted the v9-remove-screener-use branch December 20, 2022 21:53
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants