Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-combobox): migrate to new package structure #26037

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

TristanWatanabe
Copy link
Member

@TristanWatanabe TristanWatanabe commented Dec 19, 2022

Changes:

Issue:

@size-auditor
Copy link

size-auditor bot commented Dec 19, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: f944ddda46a4f5f997fd7614a62b72fcbab09da6 (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Combobox (including child components)
78.587 kB
25.156 kB
react-combobox
Dropdown (including child components)
77.834 kB
25.087 kB
react-components
react-components: Button, FluentProvider & webLightTheme
59.381 kB
16.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.025 kB
52.454 kB
react-components
react-components: FluentProvider & webLightTheme
33.843 kB
11.129 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against bfe6a0aebc33fd01023fb9c89b78a698f3247abf

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1277 1290 5000
Button mount 904 910 5000
FluentProvider mount 1508 1495 5000
FluentProviderWithTheme mount 571 574 10
FluentProviderWithTheme virtual-rerender 547 534 10
FluentProviderWithTheme virtual-rerender-with-unmount 565 572 10
MakeStyles mount 1938 1955 50000
Persona mount 2774 2768 5000
SpinButton mount 2311 2332 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3ed7f08:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@TristanWatanabe TristanWatanabe merged commit d301e75 into microsoft:master Dec 20, 2022
@TristanWatanabe TristanWatanabe deleted the combobox-migrate branch December 20, 2022 20:08
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants