Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-components): migrate to new package structure #26051

Merged

Conversation

TristanWatanabe
Copy link
Member

Changes:

Issue:

@size-auditor
Copy link

size-auditor bot commented Dec 20, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e49b13e82eddc73cbc860ec0822afb916c679a7e (build)

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
59.381 kB
16.465 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
187.067 kB
52.466 kB
react-components
react-components: FluentProvider & webLightTheme
33.843 kB
11.129 kB
react-portal-compat
PortalCompatProvider
5.857 kB
1.978 kB
🤖 This report was generated against e49b13e82eddc73cbc860ec0822afb916c679a7e

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1494 1542 5000
Button mount 1128 1090 5000
FluentProvider mount 1895 1908 5000
FluentProviderWithTheme mount 753 756 10
FluentProviderWithTheme virtual-rerender 680 688 10
FluentProviderWithTheme virtual-rerender-with-unmount 709 726 10
MakeStyles mount 2227 2231 50000
Persona mount 3489 3435 5000
SpinButton mount 2865 2981 5000

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit aa1efbe:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@TristanWatanabe TristanWatanabe marked this pull request as ready for review December 20, 2022 21:54
@TristanWatanabe TristanWatanabe requested a review from a team as a code owner December 20, 2022 21:54
@TristanWatanabe TristanWatanabe merged commit 1c41739 into microsoft:master Dec 21, 2022
@TristanWatanabe TristanWatanabe deleted the migrate-react-components branch December 21, 2022 15:57
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants