Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-persona): Move Persona to stable #26114

Merged
merged 15 commits into from
Jan 3, 2023

Conversation

sopranopillow
Copy link
Contributor

This PR moves Persona to stable.

Related Issue(s)

@size-auditor
Copy link

size-auditor bot commented Dec 27, 2022

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 5b9042fea309185404fb2c8b8986d46381af8241 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Dec 27, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 661380f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1657 1681 5000
Button mount 1150 1148 5000
FluentProvider mount 1968 1983 5000
FluentProviderWithTheme mount 712 741 10
FluentProviderWithTheme virtual-rerender 682 679 10
FluentProviderWithTheme virtual-rerender-with-unmount 715 725 10
MakeStyles mount 2303 2305 50000
Persona mount 3854 3919 5000
SpinButton mount 3191 3301 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

🕵 fluentuiv8 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Combobox (including child components)
79.959 kB
25.572 kB
react-combobox
ComboboxField
77.155 kB
25.536 kB
react-combobox
Dropdown (including child components)
79.205 kB
25.496 kB
react-components
react-components: Button, FluentProvider & webLightTheme
59.888 kB
16.652 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
188.856 kB
53.066 kB
react-components
react-components: FluentProvider & webLightTheme
34.379 kB
11.322 kB
react-persona
Persona
57.552 kB
16.102 kB
react-portal-compat
PortalCompatProvider
6.069 kB
2.053 kB
🤖 This report was generated against 5b9042fea309185404fb2c8b8986d46381af8241

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-northstar)

⚠️ No perf measurements available

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

🕵 fluentuiv9 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Dec 27, 2022

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 1203 1180 5000
Breadcrumb mount 2985 2991 1000
Checkbox mount 2662 2649 5000
CheckboxBase mount 2351 2361 5000
ChoiceGroup mount 4443 4415 5000
ComboBox mount 1264 1256 1000
CommandBar mount 9778 9768 1000
ContextualMenu mount 12300 11950 1000
DefaultButton mount 1382 1390 5000
DetailsRow mount 3594 3595 5000
DetailsRowFast mount 3642 3610 5000
DetailsRowNoStyles mount 3471 3511 5000
Dialog mount 3086 3123 1000
DocumentCardTitle mount 564 571 1000
Dropdown mount 3212 3242 5000
FocusTrapZone mount 2034 2020 5000
FocusZone mount 1943 2004 5000
GroupedList mount 1921 2206 2
GroupedList virtual-rerender 1134 1136 2
GroupedList virtual-rerender-with-unmount 1705 1663 2
GroupedListV2 mount 579 579 2
GroupedListV2 virtual-rerender 538 533 2
GroupedListV2 virtual-rerender-with-unmount 580 581 2
IconButton mount 1906 1914 5000
Label mount 722 744 5000
Layer mount 4323 4342 5000
Link mount 822 827 5000
MenuButton mount 1652 1688 5000
MessageBar mount 2319 2329 5000
Nav mount 3256 3318 1000
OverflowSet mount 1353 1338 5000
Panel mount 2553 2549 1000
Persona mount 1304 1310 1000
Pivot mount 1646 1634 1000
PrimaryButton mount 1513 1523 5000
Rating mount 6911 6948 5000
SearchBox mount 1502 1504 5000
Shimmer mount 2915 2909 5000
Slider mount 2083 2124 5000
SpinButton mount 4636 4656 5000
Spinner mount 805 802 5000
SplitButton mount 3091 3125 5000
Stack mount 824 828 5000
StackWithIntrinsicChildren mount 2310 2303 5000
StackWithTextChildren mount 4771 4797 5000
SwatchColorPicker mount 10474 10469 5000
TagPicker mount 2626 2649 5000
TeachingBubble mount 95990 96734 5000
Text mount 791 794 5000
TextField mount 1575 1588 5000
ThemeProvider mount 1520 1536 5000
ThemeProvider virtual-rerender 1079 1080 5000
ThemeProvider virtual-rerender-with-unmount 2144 2135 5000
Toggle mount 1100 1105 5000
buttonNative mount 547 555 5000

@sopranopillow sopranopillow requested review from a team and smhigley as code owners December 27, 2022 21:48
@sopranopillow sopranopillow removed the request for review from a team December 29, 2022 00:13
@sopranopillow sopranopillow enabled auto-merge (squash) December 29, 2022 18:43
auto-merge was automatically disabled December 29, 2022 18:56

Pull request was closed

@sopranopillow sopranopillow reopened this Dec 29, 2022
@sopranopillow sopranopillow enabled auto-merge (squash) December 29, 2022 19:54
auto-merge was automatically disabled December 30, 2022 21:13

Pull request was closed

@sopranopillow sopranopillow reopened this Dec 30, 2022
@sopranopillow sopranopillow merged commit 3e322d1 into microsoft:master Jan 3, 2023
@sopranopillow sopranopillow deleted the persona/stable branch January 3, 2023 23:53
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
* preparing persona to release

* updating disallowed changes

* change files

* updating combobx stories

* updating persona's stories

* update persona import

* updating change type of react-componentS

* updating change types and package version to automatically bump to 9.1.0

* updating packages

* reverting packages

* adding requested changeS

* changing type to change file to fix beachball issue
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
* preparing persona to release

* updating disallowed changes

* change files

* updating combobx stories

* updating persona's stories

* update persona import

* updating change type of react-componentS

* updating change types and package version to automatically bump to 9.1.0

* updating packages

* reverting packages

* adding requested changeS

* changing type to change file to fix beachball issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Persona: Move Persona to stable issues
8 participants