Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updating fluent-tooltip wc styles to support custom tag names #26154

Merged
merged 5 commits into from
Jan 4, 2023

Conversation

abbasc52
Copy link
Contributor

@abbasc52 abbasc52 commented Jan 4, 2023

Previous Behavior

Fluent tooltip not showing triangle tip when tag is renamed

New Behavior

Fluent tooltip correctly shows triangle tip when tag is renamed

Related Issue(s)

@abbasc52 abbasc52 marked this pull request as ready for review January 4, 2023 06:36
@abbasc52 abbasc52 requested a review from a team as a code owner January 4, 2023 06:36
@fabricteam
Copy link
Collaborator

fabricteam commented Jan 4, 2023

📊 Bundle size report

🤖 This report was generated against 4e088fd8cad55d33ebf269a985f851e26358cd26

@size-auditor
Copy link

size-auditor bot commented Jan 4, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4e088fd8cad55d33ebf269a985f851e26358cd26 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e42a9c0:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration
wizardly-breeze-vskvmp Issue #26153

@chrisdholt
Copy link
Member

Thanks @abbasc52!

@chrisdholt chrisdholt merged commit b53326e into microsoft:master Jan 4, 2023
q1b pushed a commit to q1b/fluentui that referenced this pull request Jan 24, 2023
…oft#26154)

* Updated fluent-tooltip styles to tag rename

* added missing import

* Change files

* reverted unintended changes

* fixed linting errors
Hotell pushed a commit to Hotell/fluentui that referenced this pull request Feb 9, 2023
…oft#26154)

* Updated fluent-tooltip styles to tag rename

* added missing import

* Change files

* reverted unintended changes

* fixed linting errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: fluent-tooltip does not show anchor pointer when tag is renamed
5 participants