Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove obsolete configs and decouple type-check from bundling in v0 perf app #26421

Merged
merged 3 commits into from
Apr 6, 2023
Merged

chore: remove obsolete configs and decouple type-check from bundling in v0 perf app #26421

merged 3 commits into from
Apr 6, 2023

Conversation

Hotell
Copy link
Contributor

@Hotell Hotell commented Jan 19, 2023 •
edited
Loading

New Behavior

  • obsolete configs removed from webpack
  • introduced type-check alias to run tsc
  • skipLibCheck for v0 enabled

Related Issue(s)

@size-auditor
Copy link

size-auditor bot commented Jan 19, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 2bea5b29844ac124b923a40e20e135e5b25668c6 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 19, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d987a7f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 19, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 942 915 5000
Button mount 569 584 5000
Field mount 1656 1681 5000
FluentProvider mount 1214 1221 5000
FluentProviderWithTheme mount 309 306 10
FluentProviderWithTheme virtual-rerender 299 294 10
FluentProviderWithTheme virtual-rerender-with-unmount 301 306 10
InfoButton mount 219 213 5000
MakeStyles mount 1314 1314 50000
Persona mount 2301 2233 5000
SpinButton mount 1993 1993 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 19, 2023 •
edited
Loading

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext		 533 B
341 B
global-context
createContextSelector		 560 B
352 B
priority-overflow
createOverflowManager		 3.194 kB
1.314 kB
react-accordion
Accordion (including children components)		 88.882 kB
26.551 kB
react-alert
Alert		 96.647 kB
23.133 kB
react-avatar
Avatar		 60.312 kB
15.579 kB
react-avatar
AvatarGroup		 18.178 kB
6.683 kB
react-avatar
AvatarGroupItem		 76.573 kB
20.086 kB
react-badge
Badge		 25.85 kB
7.585 kB
react-badge
CounterBadge		 26.833 kB
7.889 kB
react-badge
PresenceBadge		 34.458 kB
8.693 kB
react-button
Button		 39.749 kB
9.959 kB
react-button
CompoundButton		 46.921 kB
11.428 kB
react-button
MenuButton		 44.437 kB
11.306 kB
react-button
SplitButton		 52.931 kB
12.872 kB
react-button
ToggleButton		 58.121 kB
11.878 kB
react-card
Card - All		 83.489 kB
23.894 kB
react-card
Card		 78.308 kB
22.431 kB
react-card
CardFooter		 9.035 kB
3.799 kB
react-card
CardHeader		 10.959 kB
4.503 kB
react-card
CardPreview		 9.84 kB
4.153 kB
react-checkbox
Checkbox		 36.067 kB
10.856 kB
react-checkbox
CheckboxField		 43.019 kB
12.787 kB
react-combobox
Combobox (including child components)		 88.73 kB
28.105 kB
react-combobox
ComboboxField		 85.147 kB
27.871 kB
react-combobox
Dropdown (including child components)		 87.428 kB
27.853 kB
react-components
react-components: Button, FluentProvider & webLightTheme		 67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover		 207.4 kB
57.516 kB
react-components
react-components: FluentProvider & webLightTheme		 38.819 kB
12.351 kB
react-datepicker-compat
DatePicker Compat		 250.208 kB
66.95 kB
react-dialog
Dialog (including children components)		 93.388 kB
27.408 kB
react-divider
Divider		 19.863 kB
6.697 kB
react-field
Field		 20.552 kB
7.092 kB
react-image
Image		 14.011 kB
4.993 kB
react-infobutton
InfoButton		 130.577 kB
39.439 kB
react-infobutton
InfoLabel		 133.874 kB
40.488 kB
react-input
Input		 25.747 kB
7.697 kB
react-input
InputField		 35.723 kB
10.637 kB
react-label
Label		 12.57 kB
4.586 kB
react-link
Link		 12.301 kB
5.07 kB
react-menu
Menu (including children components)		 130.926 kB
39.629 kB
react-menu
Menu (including selectable components)		 134.062 kB
40.161 kB
react-overflow
hooks only		 11.214 kB
4.271 kB
react-persona
Persona		 67.338 kB
17.524 kB
react-popover
Popover		 117.58 kB
35.828 kB
react-portal
Portal		 11.649 kB
4.263 kB
react-portal-compat
PortalCompatProvider		 6.446 kB
2.185 kB
react-positioning
usePositioning		 24.008 kB
8.798 kB
react-progress
ProgressBar		 15.961 kB
5.675 kB
react-progress
ProgressField		 26.435 kB
8.859 kB
react-provider
FluentProvider		 20.766 kB
7.119 kB
react-radio
Radio		 35.48 kB
11.126 kB
react-radio
RadioGroup		 17.988 kB
6.544 kB
react-radio
RadioGroupField		 28.166 kB
9.735 kB
react-select
Select		 26.957 kB
8.766 kB
react-select
SelectField		 36.293 kB
11.316 kB
react-slider
Slider		 35.919 kB
11.059 kB
react-slider
SliderField		 45.847 kB
14.005 kB
react-spinbutton
SpinButton		 35.648 kB
10.348 kB
react-spinbutton
SpinButtonField		 44.671 kB
12.812 kB
react-spinner
Spinner		 23.425 kB
7.195 kB
react-switch
Switch		 31.413 kB
9.294 kB
react-switch
SwitchField		 38.317 kB
11.21 kB
react-table
DataGrid		 149.878 kB
40.662 kB
react-table
Table (Primitives only)		 47.119 kB
12.703 kB
react-table
Table as DataGrid		 138.018 kB
35.282 kB
react-table
Table (Selection only)		 85.849 kB
21.303 kB
react-table
Table (Sort only)		 85.179 kB
21.113 kB
react-text
Text - Default		 15.018 kB
5.327 kB
react-text
Text - Wrappers		 15.572 kB
5.23 kB
react-textarea
Textarea		 29.07 kB
9.081 kB
react-textarea
TextareaField		 39.454 kB
12.055 kB
react-theme
Single theme token import		 69 B
89 B
react-theme
Teams: all themes		 31.33 kB
6.764 kB
react-theme
Teams: Light theme		 17.895 kB
5.162 kB
react-tooltip
Tooltip		 49.388 kB
16.815 kB
react-utilities
SSRProvider		 180 B
159 B
🤖 This report was generated against 2bea5b29844ac124b923a40e20e135e5b25668c6

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 19, 2023 •
edited
Loading

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
AttachmentMinimalPerf.default 110 88 1.25:1
TreeWith60ListItems.default 120 108 1.11:1
AvatarMinimalPerf.default 139 129 1.08:1
ButtonMinimalPerf.default 108 102 1.06:1
TextAreaMinimalPerf.default 346 331 1.05:1
AccordionMinimalPerf.default 97 93 1.04:1
RefMinimalPerf.default 152 146 1.04:1
StatusMinimalPerf.default 496 478 1.04:1
TextMinimalPerf.default 245 235 1.04:1
ButtonSlotsPerf.default 405 393 1.03:1
CardMinimalPerf.default 375 364 1.03:1
ChatWithPopoverPerf.default 250 242 1.03:1
DividerMinimalPerf.default 257 250 1.03:1
ImageMinimalPerf.default 276 269 1.03:1
ListCommonPerf.default 484 471 1.03:1
ToolbarMinimalPerf.default 664 646 1.03:1
TooltipMinimalPerf.default 1634 1580 1.03:1
DatepickerMinimalPerf.default 4514 4413 1.02:1
DialogMinimalPerf.default 555 543 1.02:1
DropdownManyItemsPerf.default 481 470 1.02:1
LabelMinimalPerf.default 277 271 1.02:1
LayoutMinimalPerf.default 258 254 1.02:1
ListNestedPerf.default 388 382 1.02:1
PopupMinimalPerf.default 448 440 1.02:1
SegmentMinimalPerf.default 244 239 1.02:1
SkeletonMinimalPerf.default 247 243 1.02:1
TableManyItemsPerf.default 1392 1366 1.02:1
ButtonOverridesMissPerf.default 807 799 1.01:1
CarouselMinimalPerf.default 332 329 1.01:1
ChatMinimalPerf.default 510 507 1.01:1
CheckboxMinimalPerf.default 1519 1498 1.01:1
FlexMinimalPerf.default 195 194 1.01:1
ItemLayoutMinimalPerf.default 848 840 1.01:1
RosterPerf.default 1936 1926 1.01:1
ReactionMinimalPerf.default 264 261 1.01:1
IconMinimalPerf.default 446 443 1.01:1
AttachmentSlotsPerf.default 812 814 1:1
BoxMinimalPerf.default 239 238 1:1
DropdownMinimalPerf.default 1789 1786 1:1
HeaderMinimalPerf.default 252 253 1:1
LoaderMinimalPerf.default 242 242 1:1
ProviderMinimalPerf.default 265 264 1:1
RadioGroupMinimalPerf.default 310 310 1:1
SliderMinimalPerf.default 883 884 1:1
SplitButtonMinimalPerf.default 2931 2917 1:1
VideoMinimalPerf.default 524 524 1:1
AnimationMinimalPerf.default 371 375 0.99:1
GridMinimalPerf.default 229 232 0.99:1
InputMinimalPerf.default 700 704 0.99:1
ListMinimalPerf.default 359 364 0.99:1
MenuMinimalPerf.default 582 590 0.99:1
MenuButtonMinimalPerf.default 1214 1225 0.99:1
ProviderMergeThemesPerf.default 870 875 0.99:1
TableMinimalPerf.default 277 279 0.99:1
CustomToolbarPrototype.default 1827 1846 0.99:1
TreeMinimalPerf.default 560 563 0.99:1
ChatDuplicateMessagesPerf.default 184 187 0.98:1
EmbedMinimalPerf.default 2283 2323 0.98:1
HeaderSlotsPerf.default 550 559 0.98:1
PortalMinimalPerf.default 111 114 0.97:1
FormMinimalPerf.default 273 283 0.96:1
ListWith60ListItems.default 452 471 0.96:1
AlertMinimalPerf.default 185 195 0.95:1

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 19, 2023 •
edited
Loading

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 987 986 5000
Breadcrumb mount 2370 2303 1000
Checkbox mount 2205 2207 5000
CheckboxBase mount 1982 1983 5000
ChoiceGroup mount 3791 3842 5000
ComboBox mount 1016 1054 1000
CommandBar mount 8265 8234 1000
ContextualMenu mount 16875 16268 1000
DefaultButton mount 1159 1144 5000
DetailsRow mount 3072 3073 5000
DetailsRowFast mount 3059 3056 5000
DetailsRowNoStyles mount 2821 2833 5000
Dialog mount 3350 3352 1000
DocumentCardTitle mount 440 433 1000
Dropdown mount 2760 2751 5000
FocusTrapZone mount 1630 1652 5000
FocusZone mount 1582 1615 5000
GroupedList mount 50332 58842 2
GroupedList virtual-rerender 22106 24484 2
GroupedList virtual-rerender-with-unmount 75717 75522 2
GroupedListV2 mount 441 441 2
GroupedListV2 virtual-rerender 410 423 2
GroupedListV2 virtual-rerender-with-unmount 441 438 2
IconButton mount 1604 1596 5000
Label mount 565 574 5000
Layer mount 3663 3708 5000
Link mount 638 650 5000
MenuButton mount 1391 1400 5000
MessageBar mount 27571 27516 5000
Nav mount 2705 2712 1000
OverflowSet mount 1129 1101 5000
Panel mount 2131 2166 1000
Persona mount 1094 1085 1000
Pivot mount 1345 1321 1000
PrimaryButton mount 1243 1249 5000
Rating mount 5835 5846 5000
SearchBox mount 1249 1250 5000
Shimmer mount 2417 2420 5000
Slider mount 1781 1787 5000
SpinButton mount 3911 3871 5000
Spinner mount 634 642 5000
SplitButton mount 2678 2667 5000
Stack mount 658 659 5000
StackWithIntrinsicChildren mount 1246 1250 5000
StackWithTextChildren mount 3388 3373 5000
SwatchColorPicker mount 8266 8303 5000
TagPicker mount 2171 2108 5000
Text mount 642 631 5000
TextField mount 1329 1297 5000
ThemeProvider mount 1219 1247 5000
ThemeProvider virtual-rerender 891 893 5000
ThemeProvider virtual-rerender-with-unmount 1811 1813 5000
Toggle mount 896 906 5000
buttonNative mount 402 407 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Jan 19, 2023 •
edited
Loading

🕵 fluentuiv9 No visual regressions between this PR and main

@Hotell Hotell changed the title Hotell/build/scripts/v0 untagled 2 chore(scripts): remove obsolete configs and fix webpack perf tsconfig path Jan 19, 2023
@Hotell Hotell force-pushed the hotell/build/scripts/v0-untagled-2 branch from 03ccc1c to 52d15ed Compare April 3, 2023 09:01
@Hotell Hotell changed the title chore(scripts): remove obsolete configs and fix webpack perf tsconfig path chore: remove obsolete configs and decouple type-check from bundling in v0 perf app Apr 3, 2023
@Hotell Hotell force-pushed the hotell/build/scripts/v0-untagled-2 branch from 2cb95c3 to d987a7f Compare April 3, 2023 09:58
@Hotell Hotell marked this pull request as ready for review April 3, 2023 10:49
@Hotell Hotell requested review from a team as code owners April 3, 2023 10:49
@Hotell Hotell requested a review from a team as a code owner April 3, 2023 10:49
@Hotell Hotell merged commit dea94a8 into microsoft:master Apr 6, 2023
@Hotell Hotell deleted the hotell/build/scripts/v0-untagled-2 branch April 6, 2023 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabricteam fabricteam fabricteam left review comments

@ling1726 ling1726 ling1726 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
April Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
4 participants
@Hotell @fabricteam @ling1726 @TristanWatanabe