fix: [text] block breaks the style attribute #27129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 487984c48f621c01643ad569b2cde759d393bbf4 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 05ffe80:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 487984c48f621c01643ad569b2cde759d393bbf4 (build) |
chrisdholt
requested changes
Mar 8, 2023
Comment on lines
39
to
43
| ${/* slot defaults display to contents, this ensures slotted items inherit from the host */ ''} | ||
| slot { | ||
| display: inherit; | ||
| } | ||
|
|
There was a problem hiding this comment.
I would really prefer to not do this if we can avoid it - it's definitely not ideal. Do we actually need inheritance in this case?
What about simply using a selector list for block to make sure both get updated?
:host([block]),
:host([block]) ::slotted(*) {
display: block;
}
chrisdholt
reviewed
Mar 8, 2023
There was a problem hiding this comment.
@eljefe223 I think we want to revert this last change as well. This way, the default for any text node slotted is inline and only setting block changes that to block.
Co-authored-by: Chris Holt <chhol@microsoft.com>
chrisdholt
approved these changes
Mar 8, 2023
|
closes #27048 |
chrisdholt
added a commit
that referenced
this pull request
Apr 29, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 29, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
to radium-v/fluentui
that referenced
this pull request
Apr 30, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
Apr 30, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 2, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 3, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 6, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 8, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
radium-v
pushed a commit
that referenced
this pull request
May 10, 2024
* fix: [text] block breaks the style attribute * chnage files * addresed comments * Update packages/web-components/src/text/text.styles.ts Co-authored-by: Chris Holt <chhol@microsoft.com> * addressed pr comments --------- Co-authored-by: Chris Holt <chhol@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The
styleattribute is not applied to the text whenblockis set.New Behavior
The
styleshould be applied to the text, as it is whenblockis not set.Related Issue(s)
blockbreaks thestyleattribute. #27048