Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(web-components): add css containment to v3 components #27190

Conversation

chrisdholt
Copy link
Member

Previous Behavior

No CSS Containment

New Behavior

Adds contain: content to all components except Avatar which implements contain: layout style (paint cannot be applied due to the presence badge).

Related Issue(s)

n/a

  • Fixes #

@fabricteam
Copy link
Collaborator

📊 Bundle size report

🤖 This report was generated against 6e51be008ee479451431421eaf2e3e63744b6d5c

@size-auditor
Copy link

size-auditor bot commented Mar 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6e51be008ee479451431421eaf2e3e63744b6d5c (build)

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b6b105:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@chrisdholt chrisdholt merged commit fc86569 into microsoft:web-components-v3 Mar 13, 2023
@chrisdholt chrisdholt deleted the users/chhol/add-css-containment-to-components branch March 13, 2023 22:29
chrisdholt added a commit that referenced this pull request Apr 29, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request Apr 30, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 2, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 2, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 2, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 3, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 6, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 6, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 8, 2024
* add css containment to custom elements

* add css containment to existing web components
radium-v pushed a commit that referenced this pull request May 10, 2024
* add css containment to custom elements

* add css containment to existing web components
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants