Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make border around Avatar's badge transparent, not a solid color #27292

Closed
wants to merge 3 commits into from

Conversation

behowell
Copy link
Contributor

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 22, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert
96.524 kB
23.109 kB
100.003 kB
23.828 kB
3.479 kB
719 B
react-avatar
Avatar
60.189 kB
15.557 kB
63.668 kB
16.236 kB
3.479 kB
679 B
react-avatar
AvatarGroupItem
76.45 kB
20.063 kB
79.929 kB
20.78 kB
3.479 kB
717 B
react-persona
Persona
67.215 kB
17.502 kB
70.694 kB
18.188 kB
3.479 kB
686 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-avatar
AvatarGroup
18.059 kB
6.662 kB
react-components
react-components: Button, FluentProvider & webLightTheme
67.372 kB
18.188 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
206.778 kB
57.319 kB
react-components
react-components: FluentProvider & webLightTheme
38.201 kB
12.128 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-table
DataGrid
149.705 kB
40.623 kB
react-table
Table (Primitives only)
47 kB
12.681 kB
react-table
Table as DataGrid
137.845 kB
35.252 kB
react-table
Table (Selection only)
85.68 kB
21.276 kB
react-table
Table (Sort only)
85.01 kB
21.086 kB
🤖 This report was generated against 77bb9ec1eeedef91315dee3750bd06b15168c693

@size-auditor
Copy link

size-auditor bot commented Mar 22, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 77bb9ec1eeedef91315dee3750bd06b15168c693 (build)

@@ -0,0 +1,7 @@
{
Copy link
Collaborator

@fabricteam fabricteam Mar 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 163 screenshots

✅ There was 0 screenshots added, 0 screenshots removed, 1740 screenshots unchanged, 0 screenshots with different dimensions and 163 screenshots with visible difference.

unknown 163 screenshots
Image Name Diff(in Pixels) Image Type
Avatar Converged.basic - Dark Mode.normal.chromium.png 3 Changed
Avatar Converged.basic - High Contrast.normal.chromium.png 9 Changed
Avatar Converged.basic - RTL.normal.chromium.png 34 Changed
Avatar Converged.basic.normal.chromium.png 6 Changed
Avatar Converged.customSize+name+badge.normal.chromium.png 83 Changed
Avatar Converged.size+icon+badge+square.normal.chromium.png 47 Changed
Avatar Converged.size+image+badge.normal.chromium.png 70 Changed
Avatar Converged.size+inactive+badge.normal.chromium.png 43 Changed
Persona Converged.basic - Dark Mode.normal.chromium.png 1 Changed
Persona Converged.basic - High Contrast.normal.chromium.png 5 Changed
Persona Converged.basic - RTL.normal.chromium.png 2 Changed
Persona Converged.basic.normal.chromium.png 3 Changed
Persona Converged.textWrap.normal.chromium.png 3 Changed
Table flex - subtle selection.rest.chromium.png 9 Changed
Table flex - subtle selection.rest.hover unselected row.chromium.png 9 Changed
Table layout flex - cell actions.always visible - Dark Mode.chromium.png 6 Changed
Table layout flex - cell actions.always visible - Dark Mode.hover row.chromium.png 7 Changed
Table layout flex - cell actions.always visible - High Contrast.chromium.png 19 Changed
Table layout flex - cell actions.always visible - High Contrast.hover row.chromium.png 33 Changed
Table layout flex - cell actions.always visible - RTL.chromium.png 9 Changed
Table layout flex - cell actions.always visible - RTL.hover row.chromium.png 8 Changed
Table layout flex - cell actions.always visible.chromium.png 9 Changed
Table layout flex - cell actions.always visible.hover row.chromium.png 9 Changed
Table layout flex - cell actions.default - Dark Mode.chromium.png 6 Changed
Table layout flex - cell actions.default - Dark Mode.hover row.chromium.png 7 Changed
Table layout flex - cell actions.default - High Contrast.chromium.png 19 Changed
Table layout flex - cell actions.default - High Contrast.hover row.chromium.png 33 Changed
Table layout flex - cell actions.default - RTL.chromium.png 9 Changed
Table layout flex - cell actions.default - RTL.hover row.chromium.png 8 Changed
Table layout flex - cell actions.default.chromium.png 9 Changed
Table layout flex - cell actions.default.hover row.chromium.png 9 Changed
Table layout flex - cell actions.in header cell.chromium.png 9 Changed
Table layout flex - cell actions.in header cell.hover row.chromium.png 9 Changed
Table layout flex - headers.sortable - Dark Mode.chromium.png 6 Changed
Table layout flex - headers.sortable - Dark Mode.hover header.chromium.png 6 Changed
Table layout flex - headers.sortable - Dark Mode.press header.chromium.png 6 Changed
Table layout flex - headers.sortable - High Contrast.chromium.png 19 Changed
Table layout flex - headers.sortable - High Contrast.hover header.chromium.png 19 Changed
Table layout flex - headers.sortable - High Contrast.press header.chromium.png 19 Changed
Table layout flex - headers.sortable.chromium.png 9 Changed
Table layout flex - headers.sortable.hover header.chromium.png 9 Changed
Table layout flex - headers.sortable.press header.chromium.png 9 Changed
Table layout flex - truncate.default (disabled).chromium.png 9 Changed
Table layout flex - truncate.false.chromium.png 9 Changed
Table layout flex - truncate.true.chromium.png 9 Changed
Table layout flex.multiselect (checked) - brand - Dark Mode.chromium.png 8 Changed
Table layout flex.multiselect (checked) - brand - High Contrast.chromium.png 111 Changed
Table layout flex.multiselect (checked) - brand - RTL.chromium.png 7 Changed
Table layout flex.multiselect (checked) - brand.chromium.png 11 Changed
Table layout flex.multiselect (checked) - neutral - Dark Mode.chromium.png 5 Changed
Table layout flex.multiselect (checked) - neutral - High Contrast.chromium.png 76 Changed
Table layout flex.multiselect (checked) - neutral - RTL.chromium.png 8 Changed
Table layout flex.multiselect (checked) - neutral.chromium.png 13 Changed
Table layout flex.multiselect (mixed) - brand - Dark Mode.chromium.png 7 Changed
Table layout flex.multiselect (mixed) - brand - High Contrast.chromium.png 65 Changed
Table layout flex.multiselect (mixed) - brand - RTL.chromium.png 8 Changed
Table layout flex.multiselect (mixed) - brand.chromium.png 10 Changed
Table layout flex.multiselect (mixed) - neutral - Dark Mode.chromium.png 6 Changed
Table layout flex.multiselect (mixed) - neutral - High Contrast.chromium.png 48 Changed
Table layout flex.multiselect (mixed) - neutral - RTL.chromium.png 9 Changed
Table layout flex.multiselect (mixed) - neutral.chromium.png 11 Changed
Table layout flex.multiselect - Dark Mode.chromium.png 6 Changed
Table layout flex.multiselect - High Contrast.chromium.png 19 Changed
Table layout flex.multiselect - RTL.chromium.png 9 Changed
Table layout flex.multiselect.chromium.png 9 Changed
Table layout flex.primary cell.chromium.png 9 Changed
Table layout flex.single select (checked) - Dark Mode.chromium.png 6 Changed
Table layout flex.single select (checked) - High Contrast.chromium.png 19 Changed
Table layout flex.single select (checked) - RTL.chromium.png 9 Changed
Table layout flex.single select (checked) - brand - Dark Mode.chromium.png 7 Changed
Table layout flex.single select (checked) - brand - High Contrast.chromium.png 42 Changed
Table layout flex.single select (checked) - brand - RTL.chromium.png 9 Changed
Table layout flex.single select (checked) - brand.chromium.png 10 Changed
Table layout flex.single select (checked) - neutral - Dark Mode.chromium.png 6 Changed
Table layout flex.single select (checked) - neutral - High Contrast.chromium.png 33 Changed
Table layout flex.single select (checked) - neutral - RTL.chromium.png 9 Changed
Table layout flex.single select (checked) - neutral.chromium.png 10 Changed
Table layout flex.single select (checked).chromium.png 9 Changed
Table layout flex.single select - Dark Mode.chromium.png 6 Changed
Table layout flex.single select - High Contrast.chromium.png 19 Changed
Table layout flex.single select - RTL.chromium.png 9 Changed
Table layout flex.single select.chromium.png 9 Changed
Table layout flex.size - extra small.chromium.png 7 Changed
Table layout flex.size - medium - Dark Mode.chromium.png 6 Changed
Table layout flex.size - medium - High Contrast.chromium.png 19 Changed
Table layout flex.size - medium - RTL.chromium.png 9 Changed
Table layout flex.size - medium.chromium.png 9 Changed
Table layout flex.size - small.chromium.png 7 Changed
Table layout table - cell actions.always visible - Dark Mode.chromium.png 6 Changed
Table layout table - cell actions.always visible - Dark Mode.hover row.chromium.png 7 Changed
Table layout table - cell actions.always visible - High Contrast.chromium.png 19 Changed
Table layout table - cell actions.always visible - High Contrast.hover row.chromium.png 33 Changed
Table layout table - cell actions.always visible - RTL.chromium.png 9 Changed
Table layout table - cell actions.always visible - RTL.hover row.chromium.png 8 Changed
Table layout table - cell actions.always visible.chromium.png 9 Changed
Table layout table - cell actions.always visible.hover row.chromium.png 9 Changed
Table layout table - cell actions.default - Dark Mode.chromium.png 6 Changed
Table layout table - cell actions.default - Dark Mode.hover row.chromium.png 7 Changed
Table layout table - cell actions.default - High Contrast.chromium.png 19 Changed
Table layout table - cell actions.default - High Contrast.hover row.chromium.png 33 Changed
Table layout table - cell actions.default - RTL.chromium.png 9 Changed
Table layout table - cell actions.default - RTL.hover row.chromium.png 8 Changed
Table layout table - cell actions.default.chromium.png 9 Changed
Table layout table - cell actions.default.hover row.chromium.png 9 Changed
Table layout table - cell actions.in header cell.chromium.png 9 Changed
Table layout table - cell actions.in header cell.hover row.chromium.png 9 Changed
Table layout table - headers.sortable - Dark Mode.chromium.png 6 Changed
Table layout table - headers.sortable - Dark Mode.hover header.chromium.png 6 Changed
Table layout table - headers.sortable - Dark Mode.press header.chromium.png 6 Changed
Table layout table - headers.sortable - High Contrast.chromium.png 19 Changed
Table layout table - headers.sortable - High Contrast.hover header.chromium.png 19 Changed
Table layout table - headers.sortable - High Contrast.press header.chromium.png 19 Changed
Table layout table - headers.sortable.chromium.png 9 Changed
Table layout table - headers.sortable.hover header.chromium.png 9 Changed
Table layout table - headers.sortable.press header.chromium.png 9 Changed
Table layout table - truncate.default (disabled).chromium.png 9 Changed
Table layout table - truncate.false.chromium.png 9 Changed
Table layout table - truncate.true.chromium.png 9 Changed
Table layout table.multiselect (checked) - brand - Dark Mode.chromium.png 8 Changed
Table layout table.multiselect (checked) - brand - High Contrast.chromium.png 111 Changed
Table layout table.multiselect (checked) - brand - RTL.chromium.png 7 Changed
Table layout table.multiselect (checked) - brand.chromium.png 11 Changed
Table layout table.multiselect (checked) - neutral - Dark Mode.chromium.png 5 Changed
Table layout table.multiselect (checked) - neutral - High Contrast.chromium.png 76 Changed
Table layout table.multiselect (checked) - neutral - RTL.chromium.png 8 Changed
Table layout table.multiselect (checked) - neutral.chromium.png 13 Changed
Table layout table.multiselect (mixed) - brand - Dark Mode.chromium.png 7 Changed
Table layout table.multiselect (mixed) - brand - High Contrast.chromium.png 65 Changed
Table layout table.multiselect (mixed) - brand - RTL.chromium.png 8 Changed
Table layout table.multiselect (mixed) - brand.chromium.png 10 Changed
Table layout table.multiselect (mixed) - neutral - Dark Mode.chromium.png 6 Changed
Table layout table.multiselect (mixed) - neutral - High Contrast.chromium.png 48 Changed
Table layout table.multiselect (mixed) - neutral - RTL.chromium.png 9 Changed
Table layout table.multiselect (mixed) - neutral.chromium.png 11 Changed
Table layout table.multiselect - Dark Mode.chromium.png 6 Changed
Table layout table.multiselect - High Contrast.chromium.png 19 Changed
Table layout table.multiselect - RTL.chromium.png 9 Changed
Table layout table.multiselect.chromium.png 9 Changed
Table layout table.primary cell.chromium.png 9 Changed
Table layout table.single select (checked) - Dark Mode.chromium.png 6 Changed
Table layout table.single select (checked) - High Contrast.chromium.png 19 Changed
Table layout table.single select (checked) - RTL.chromium.png 9 Changed
Table layout table.single select (checked) - brand - Dark Mode.chromium.png 7 Changed
Table layout table.single select (checked) - brand - High Contrast.chromium.png 42 Changed
Table layout table.single select (checked) - brand - RTL.chromium.png 9 Changed
Table layout table.single select (checked) - brand.chromium.png 10 Changed
Table layout table.single select (checked) - neutral - Dark Mode.chromium.png 6 Changed
Table layout table.single select (checked) - neutral - High Contrast.chromium.png 33 Changed
Table layout table.single select (checked) - neutral - RTL.chromium.png 9 Changed
Table layout table.single select (checked) - neutral.chromium.png 10 Changed
Table layout table.single select (checked).chromium.png 9 Changed
Table layout table.single select - Dark Mode.chromium.png 6 Changed
Table layout table.single select - High Contrast.chromium.png 19 Changed
Table layout table.single select - RTL.chromium.png 9 Changed
Table layout table.single select.chromium.png 9 Changed
Table layout table.size - extra small.chromium.png 7 Changed
Table layout table.size - medium - Dark Mode.chromium.png 6 Changed
Table layout table.size - medium - High Contrast.chromium.png 19 Changed
Table layout table.size - medium - RTL.chromium.png 9 Changed
Table layout table.size - medium.chromium.png 9 Changed
Table layout table.size - small.chromium.png 7 Changed
Table table - subtle selection.rest.chromium.png 9 Changed
Table table - subtle selection.rest.hover unselected row.chromium.png 9 Changed

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a89239:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 1078 1108 5000
Button mount 694 680 5000
Field mount 1956 1948 5000
FluentProvider mount 1371 1416 5000
FluentProviderWithTheme mount 383 381 10
FluentProviderWithTheme virtual-rerender 290 278 10
FluentProviderWithTheme virtual-rerender-with-unmount 356 342 10
InfoButton mount 249 257 5000
MakeStyles mount 1552 1576 50000
Persona mount 2664 2708 5000
SpinButton mount 2326 2397 5000

@behowell
Copy link
Contributor Author

Abandoning in favor of #27527

@behowell behowell closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants