Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add menu button as new component #27396

Conversation

chrisdholt
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Mar 31, 2023

📊 Bundle size report

🤖 This report was generated against 14df67d349d979290b8a802b12b14d0bb66d9441

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 31, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8bb473e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Mar 31, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 14df67d349d979290b8a802b12b14d0bb66d9441 (build)

@chrisdholt chrisdholt force-pushed the users/chhol/add-menu-button-as-new-component branch from ebf5fd1 to 8bb473e Compare April 5, 2023 17:40
@chrisdholt
Copy link
Member Author

I'm going to merge this as the only deltas between button and menu button is the addition of default slotted content.

@chrisdholt chrisdholt merged commit 2a1f8f6 into microsoft:web-components-v3 Apr 5, 2023
@chrisdholt chrisdholt deleted the users/chhol/add-menu-button-as-new-component branch April 5, 2023 18:04
chrisdholt added a commit that referenced this pull request Apr 29, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request Apr 30, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 2, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 2, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 2, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 3, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 6, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 6, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 8, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
radium-v pushed a commit that referenced this pull request May 10, 2024
* add menu button as a new component

* remove unnecessary icon attr in stories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants