Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit tests for donut chart #27424

Merged
merged 4 commits into from
Apr 18, 2023

Conversation

srmukher
Copy link
Contributor

@srmukher srmukher commented Apr 4, 2023

Added unit test plan and unit tests for Donut Chart component.
Added unit tests for colors utility functions.

Improved the code coverage as follows:

Master: (colors utility having coverage of 75.86%)

image

To: (colors utility having improved coverage of 96.55%)

image

Related Issue(s)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 5a00fd5:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 4, 2023

📊 Bundle size report

🤖 This report was generated against bbdfcb9795bca865f8b632f30ee5c7156e092fc5

@size-auditor
Copy link

size-auditor bot commented Apr 4, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bbdfcb9795bca865f8b632f30ee5c7156e092fc5 (build)

@srmukher srmukher force-pushed the users/srmukher/UnitTestsDonut branch from 553fdc3 to 5ccda3d Compare April 4, 2023 07:18
@srmukher srmukher force-pushed the users/srmukher/UnitTestsDonut branch from 5ccda3d to fb5b655 Compare April 4, 2023 07:33
@srmukher srmukher force-pushed the users/srmukher/UnitTestsDonut branch from e219fd3 to 5a00fd5 Compare April 13, 2023 09:56
@srmukher srmukher merged commit af59ca5 into microsoft:master Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants