Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Components V3 - Tabs, Tab, Tab-Panel package.json mappings #27505

Merged

Conversation

bearcat-msft
Copy link
Contributor

Relevant Code Missing

Pr which added Tabs, Tab and Tab-Panel neglected to add mappings in package json to the dist folder.

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

📊 Bundle size report

🤖 This report was generated against 44be2f18fcde3f2708814ada84dad16c1f0a68fe

@size-auditor
Copy link

size-auditor bot commented Apr 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 44be2f18fcde3f2708814ada84dad16c1f0a68fe (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 68f53b2:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@bearcat-msft
Copy link
Contributor Author

bearcat-msft commented Apr 10, 2023

@miroslavstastny @eljefe223 My build is failing for lack of change file. What is causing this error?

image

There is no yarn change script in web-components-v3

@miroslavstastny
Copy link
Member

There is no yarn change script in web-components-v3
You need to run yarn change in the repo root + manually commit the generated change file.

@bearcat-msft bearcat-msft merged commit 30b72e9 into microsoft:web-components-v3 Apr 10, 2023
chrisdholt pushed a commit that referenced this pull request Apr 29, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
…soft#27505)

* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 29, 2024
…soft#27505)

* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit to radium-v/fluentui that referenced this pull request Apr 30, 2024
…soft#27505)

* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request Apr 30, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 2, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 2, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 2, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 3, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 6, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 6, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 8, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
radium-v pushed a commit that referenced this pull request May 10, 2024
* adding missing package.json mappings

* fixing package.json syntax

* Adding change file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants