Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update stable version of fast foundation to provide bug fixes #27506

Conversation

chrisdholt
Copy link
Member

Previous Behavior

New Behavior

Related Issue(s)

  • Fixes #

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-badge
Badge
25.85 kB
7.585 kB
25.985 kB
7.6 kB
135 B
15 B
react-badge
CounterBadge
26.833 kB
7.889 kB
26.968 kB
7.907 kB
135 B
18 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
533 B
341 B
global-context
createContextSelector
560 B
352 B
priority-overflow
createOverflowManager
3.194 kB
1.314 kB
react-accordion
Accordion (including children components)
88.882 kB
26.551 kB
react-alert
Alert
96.647 kB
23.133 kB
react-avatar
Avatar
60.312 kB
15.579 kB
react-avatar
AvatarGroup
18.178 kB
6.683 kB
react-avatar
AvatarGroupItem
76.573 kB
20.086 kB
react-badge
PresenceBadge
34.458 kB
8.693 kB
react-button
Button
39.749 kB
9.959 kB
react-button
CompoundButton
46.921 kB
11.428 kB
react-button
MenuButton
44.437 kB
11.306 kB
react-button
SplitButton
52.931 kB
12.872 kB
react-button
ToggleButton
58.121 kB
11.878 kB
react-card
Card - All
83.489 kB
23.894 kB
react-card
Card
78.308 kB
22.431 kB
react-card
CardFooter
9.035 kB
3.799 kB
react-card
CardHeader
10.959 kB
4.503 kB
react-card
CardPreview
9.84 kB
4.153 kB
react-checkbox
Checkbox
37.02 kB
11.255 kB
react-combobox
Combobox (including child components)
89.718 kB
28.49 kB
react-combobox
Dropdown (including child components)
88.402 kB
28.217 kB
react-components
react-components: Button, FluentProvider & webLightTheme
67.994 kB
18.395 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.512 kB
57.555 kB
react-components
react-components: FluentProvider & webLightTheme
38.819 kB
12.351 kB
react-datepicker-compat
DatePicker Compat
251.272 kB
67.329 kB
react-dialog
Dialog (including children components)
93.352 kB
27.394 kB
react-divider
Divider
19.863 kB
6.697 kB
react-field
Field
21.509 kB
7.408 kB
react-image
Image
14.011 kB
4.993 kB
react-infobutton
InfoButton
130.577 kB
39.439 kB
react-infobutton
InfoLabel
133.874 kB
40.488 kB
react-input
Input
26.707 kB
8.113 kB
react-label
Label
12.57 kB
4.586 kB
react-link
Link
12.301 kB
5.07 kB
react-menu
Menu (including children components)
131.038 kB
39.653 kB
react-menu
Menu (including selectable components)
134.174 kB
40.187 kB
react-overflow
hooks only
11.214 kB
4.271 kB
react-persona
Persona
67.338 kB
17.524 kB
react-popover
Popover
117.58 kB
35.828 kB
react-portal
Portal
11.649 kB
4.263 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-positioning
usePositioning
24.008 kB
8.798 kB
react-progress
ProgressBar
16.322 kB
5.822 kB
react-provider
FluentProvider
20.766 kB
7.119 kB
react-radio
Radio
35.48 kB
11.126 kB
react-radio
RadioGroup
18.889 kB
6.929 kB
react-select
Select
27.915 kB
9.189 kB
react-slider
Slider
36.845 kB
11.474 kB
react-spinbutton
SpinButton
36.615 kB
10.757 kB
react-spinner
Spinner
23.425 kB
7.195 kB
react-switch
Switch
32.438 kB
9.706 kB
react-table
DataGrid
150.829 kB
41.052 kB
react-table
Table (Primitives only)
47.119 kB
12.703 kB
react-table
Table as DataGrid
138.971 kB
35.722 kB
react-table
Table (Selection only)
86.8 kB
21.742 kB
react-table
Table (Sort only)
86.13 kB
21.549 kB
react-text
Text - Default
15.018 kB
5.327 kB
react-text
Text - Wrappers
15.572 kB
5.23 kB
react-textarea
Textarea
30.108 kB
9.478 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
31.33 kB
6.764 kB
react-theme
Teams: Light theme
17.895 kB
5.162 kB
react-tooltip
Tooltip
49.388 kB
16.815 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against d8dfb287b687034e5f9676792697d9d5903f9baf

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 10, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d755af6:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 10, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 72acd40b2319325eb725760888185a2fabdd46e7 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 621 603 5000
Button mount 323 329 5000
Field mount 1103 1134 5000
FluentProvider mount 822 822 5000
FluentProviderWithTheme mount 108 99 10
FluentProviderWithTheme virtual-rerender 81 86 10
FluentProviderWithTheme virtual-rerender-with-unmount 97 95 10
InfoButton mount 20 19 5000
MakeStyles mount 1006 1114 50000
Persona mount 1780 1759 5000
SpinButton mount 1424 1349 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
RefMinimalPerf.default 145 130 1.12:1
ButtonMinimalPerf.default 115 105 1.1:1
ChatWithPopoverPerf.default 250 230 1.09:1
AvatarMinimalPerf.default 140 130 1.08:1
FlexMinimalPerf.default 211 195 1.08:1
LoaderMinimalPerf.default 244 230 1.06:1
RadioGroupMinimalPerf.default 340 322 1.06:1
BoxMinimalPerf.default 254 243 1.05:1
ListNestedPerf.default 419 400 1.05:1
IconMinimalPerf.default 470 446 1.05:1
TreeWith60ListItems.default 114 109 1.05:1
AttachmentMinimalPerf.default 100 96 1.04:1
CarouselMinimalPerf.default 349 337 1.04:1
VideoMinimalPerf.default 535 516 1.04:1
ChatDuplicateMessagesPerf.default 194 188 1.03:1
HeaderMinimalPerf.default 258 251 1.03:1
ItemLayoutMinimalPerf.default 914 884 1.03:1
LayoutMinimalPerf.default 263 256 1.03:1
TextAreaMinimalPerf.default 354 344 1.03:1
CheckboxMinimalPerf.default 1575 1543 1.02:1
DialogMinimalPerf.default 585 572 1.02:1
DropdownManyItemsPerf.default 493 481 1.02:1
ListMinimalPerf.default 381 373 1.02:1
RosterPerf.default 1826 1790 1.02:1
PopupMinimalPerf.default 446 436 1.02:1
ReactionMinimalPerf.default 270 266 1.02:1
SegmentMinimalPerf.default 248 244 1.02:1
TooltipMinimalPerf.default 1666 1635 1.02:1
AttachmentSlotsPerf.default 832 825 1.01:1
ButtonOverridesMissPerf.default 825 815 1.01:1
CardMinimalPerf.default 370 366 1.01:1
ChatMinimalPerf.default 533 527 1.01:1
DropdownMinimalPerf.default 1804 1795 1.01:1
FormMinimalPerf.default 271 269 1.01:1
GridMinimalPerf.default 247 244 1.01:1
ProviderMinimalPerf.default 270 267 1.01:1
SliderMinimalPerf.default 903 894 1.01:1
SplitButtonMinimalPerf.default 2988 2972 1.01:1
CustomToolbarPrototype.default 1895 1874 1.01:1
TreeMinimalPerf.default 595 589 1.01:1
AnimationMinimalPerf.default 359 359 1:1
DatepickerMinimalPerf.default 4460 4477 1:1
DividerMinimalPerf.default 264 263 1:1
EmbedMinimalPerf.default 2376 2370 1:1
InputMinimalPerf.default 722 722 1:1
ListCommonPerf.default 498 497 1:1
ListWith60ListItems.default 464 462 1:1
MenuButtonMinimalPerf.default 1251 1255 1:1
PortalMinimalPerf.default 119 119 1:1
SkeletonMinimalPerf.default 252 253 1:1
ToolbarMinimalPerf.default 658 656 1:1
AccordionMinimalPerf.default 99 100 0.99:1
AlertMinimalPerf.default 190 192 0.99:1
ImageMinimalPerf.default 278 281 0.99:1
LabelMinimalPerf.default 273 275 0.99:1
MenuMinimalPerf.default 606 610 0.99:1
ProviderMergeThemesPerf.default 962 971 0.99:1
TableManyItemsPerf.default 1405 1419 0.99:1
TableMinimalPerf.default 294 298 0.99:1
ButtonSlotsPerf.default 403 413 0.98:1
TextMinimalPerf.default 243 249 0.98:1
HeaderSlotsPerf.default 564 579 0.97:1
StatusMinimalPerf.default 492 507 0.97:1

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

🕵 FluentUI-v0 No visual regressions between this PR and main

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 10, 2023

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 812 820 5000
Breadcrumb mount 2199 2195 1000
Checkbox mount 2170 2174 5000
CheckboxBase mount 1881 1881 5000
ChoiceGroup mount 3738 3724 5000
ComboBox mount 885 885 1000
CommandBar mount 8023 8043 1000
ContextualMenu mount 15942 16309 1000
DefaultButton mount 983 981 5000
DetailsRow mount 2905 2892 5000
DetailsRowFast mount 2927 2892 5000
DetailsRowNoStyles mount 2630 2668 5000
Dialog mount 3512 3443 1000
DocumentCardTitle mount 308 310 1000
Dropdown mount 2542 2575 5000
FocusTrapZone mount 1507 1480 5000
FocusZone mount 1470 1454 5000
GroupedList mount 50768 59108 2
GroupedList virtual-rerender 24385 24540 2
GroupedList virtual-rerender-with-unmount 74997 74910 2
GroupedListV2 mount 317 305 2
GroupedListV2 virtual-rerender 309 303 2
GroupedListV2 virtual-rerender-with-unmount 318 321 2
IconButton mount 1433 1415 5000
Label mount 481 461 5000
Layer mount 3600 3631 5000
Link mount 543 527 5000
MenuButton mount 1227 1233 5000
MessageBar mount 27527 27382 5000
Nav mount 2530 2581 1000
OverflowSet mount 1005 999 5000
Panel mount 2237 2233 1000
Persona mount 959 978 1000
Pivot mount 1189 1183 1000
PrimaryButton mount 1116 1111 5000
Rating mount 5826 5836 5000
SearchBox mount 1151 1151 5000
Shimmer mount 2347 2316 5000
Slider mount 1711 1702 5000
SpinButton mount 3784 3788 5000
Spinner mount 522 520 5000
SplitButton mount 2445 2460 5000
Stack mount 533 526 5000
StackWithIntrinsicChildren mount 1132 1136 5000
StackWithTextChildren mount 3217 3223 5000
SwatchColorPicker mount 8173 8171 5000
TagPicker mount 1977 1989 5000
Text mount 500 500 5000
TextField mount 1219 1210 5000
ThemeProvider mount 1139 1127 5000
ThemeProvider virtual-rerender 769 777 5000
ThemeProvider virtual-rerender-with-unmount 1718 1748 5000
Toggle mount 789 818 5000
buttonNative mount 276 281 5000

@chrisdholt chrisdholt force-pushed the users/chhol/update-fast-stable-package-versions branch from a121fc1 to cabea43 Compare April 10, 2023 20:16
@@ -0,0 +1,7 @@
{
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵 fluentuiv9 Open the Visual Regressions report to inspect the 1 screenshots

✅ There was 1 screenshots added, 0 screenshots removed, 1930 screenshots unchanged, 0 screenshots with different dimensions and 0 screenshots with visible difference.

unknown 1 screenshots
Image Name Diff(in Pixels) Image Type
Badge Converged.width constrained.chromium.png 0 Added

@chrisdholt chrisdholt merged commit d641ed3 into microsoft:master Apr 10, 2023
@chrisdholt chrisdholt deleted the users/chhol/update-fast-stable-package-versions branch April 10, 2023 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants