Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-tree): adopt custom JSX pragma #27542

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-tree
  2. adds resolveShorthand to all slots (some root slots were missing it)

@bsunderhus bsunderhus self-assigned this Apr 13, 2023
@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 13, 2023
@bsunderhus bsunderhus changed the title chore(react-tree): adopt custom jsx pragma chore(react-tree): adopt custom JSX pragma Apr 13, 2023
@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 80139da:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: bb758eb9091e5c53f8d1d58baf50505aa2aa34cc (build)

@bsunderhus bsunderhus closed this Apr 13, 2023
@bsunderhus bsunderhus reopened this Apr 13, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

📊 Bundle size report

Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.093 kB
18.424 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
207.629 kB
57.6 kB
react-components
react-components: FluentProvider & webLightTheme
38.833 kB
12.37 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 2e1cf8928df3e4f0b64b7390408374db94ae9e2c

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 20 20 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 705 720 5000
Button mount 396 405 5000
Field mount 1252 1244 5000
FluentProvider mount 783 775 5000
FluentProviderWithTheme mount 107 107 10
FluentProviderWithTheme virtual-rerender 96 96 10
FluentProviderWithTheme virtual-rerender-with-unmount 104 100 10
InfoButton mount 20 20 5000 Possible regression
MakeStyles mount 1181 1205 50000
Persona mount 1975 1926 5000
SpinButton mount 1481 1512 5000

@bsunderhus bsunderhus marked this pull request as ready for review April 13, 2023 12:50
@bsunderhus bsunderhus requested a review from a team as a code owner April 13, 2023 12:50
@bsunderhus bsunderhus force-pushed the react-tree/feat--adopt-custom-jsx-pragma branch from e6dcaec to 6376fb5 Compare April 14, 2023 09:11
@bsunderhus
Copy link
Contributor Author

I'll be waiting for #27571 before merging this PR

@bsunderhus bsunderhus added the Status: Blocked Resolution blocked by another issue label Apr 14, 2023
@bsunderhus bsunderhus force-pushed the react-tree/feat--adopt-custom-jsx-pragma branch from 6376fb5 to 80139da Compare April 15, 2023 09:04
@bsunderhus bsunderhus removed the Status: Blocked Resolution blocked by another issue label Apr 15, 2023
@bsunderhus bsunderhus merged commit 2766573 into microsoft:master Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants