chore(react-data-grid-react-window): adopt custom JSX pragma #27552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle size report🤖 This report was generated against 2e1cf8928df3e4f0b64b7390408374db94ae9e2c |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit a335944:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bb758eb9091e5c53f8d1d58baf50505aa2aa34cc (build) |
bsunderhus
force-pushed
the
react-data-grid-react-window/chore--adopt-custom-JSX-pragma
branch
from
d93f045 to
f284168
Compare
|
I'll be waiting for #27571 before merging this PR |
bsunderhus
force-pushed
the
react-data-grid-react-window/chore--adopt-custom-JSX-pragma
branch
from
f284168 to
a335944
Compare
miroslavstastny
approved these changes
Apr 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
react-jsx-runtimecustom pragma onreact-data-grid-react-windowresolveShorthandto all slots (somerootslots were missing it)