Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(public-docsite): Add banner to React component pages to promote v9 #27557

Merged

Conversation

sopranopillow
Copy link
Contributor

@sopranopillow sopranopillow commented Apr 13, 2023

Previous Behavior

We only have a small banner announcing v9, but other than that there's no reference to our new version.

image

New Behavior

Remove previous banner and add a banner section to the page. This banner will only be shown in the React platform's component pages.

image

Related Issue(s)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 13, 2023

📊 Bundle size report

🤖 This report was generated against 6292ed9f4a5d4292b17de2c031ce7b82d99598ed

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 13, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 7f141ec:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 13, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 6292ed9f4a5d4292b17de2c031ce7b82d99598ed (build)

@sopranopillow sopranopillow changed the title feat(public-docsite): Add link to v9 docsite next to v8's version picker for better reach feat(public-docsite): Add banner to promote v9 Apr 19, 2023
@sopranopillow sopranopillow changed the title feat(public-docsite): Add banner to promote v9 feat(public-docsite): Add banner to v8 component pages to promote v9 Apr 19, 2023
@sopranopillow sopranopillow changed the title feat(public-docsite): Add banner to v8 component pages to promote v9 feat(public-docsite): Add banner to React component pages to promote v9 Apr 19, 2023
@sopranopillow sopranopillow merged commit 37e17af into microsoft:master Apr 19, 2023
@sopranopillow sopranopillow deleted the public-docsite/v9-banner branch April 19, 2023 22:45
marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Apr 24, 2023
* master: (58 commits)
  fix(react-datepicker-compat): Make onValidationError onValidationResult so the error is updated when there's no longer an error (microsoft#27655)
  Fix `@fluentui/react-portal-compat`: to be compatible with React 18 (microsoft#27577)
  chore: fix versions of @fluentui/react-datepicker-compat (microsoft#27666)
  applying package updates
  applying package updates
  Make line chart screen reader accessible (microsoft#27632)
  fix(react-examples): Improve keyboard navigation in ContextualMenu.CustomMenuList (microsoft#25172)
  docs(react-textarea): Update examples to use Field (microsoft#27644)
  bugfix(react-dialog): `DialogTitle` root as `h2` by default (microsoft#27555)
  applying package updates
  chore: restructure stories, add separate category for flat tree (microsoft#27586)
  fix document link (microsoft#27499)
  fix(react): exclude React.HTMLAttributes defined `content` prop for Tooltip and TooltipHost Prop types to mitigate @types/react breaking changes (microsoft#27467)
  chore(react-tabs): adopts custom JSX pragma (microsoft#27640)
  fix: ContextualMenuSplitButton always sets aria-checked (does not leave it undefined) when it is checkable (microsoft#27650)
  feat(react-datepicker-compat): Move DatePicker compat to stable (microsoft#27378)
  bugfix(react-tree): fix parent navigation after independency from id (microsoft#27642)
  applying package updates
  feat(react-datepicker-compat): Add error handling to DatePicker and update popup's padding (microsoft#27637)
  feat(public-docsite): Add banner to React component pages to promote v9 (microsoft#27557)
  ...
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
…v9 (microsoft#27557)

* adding link to v9 next to version picker

* change files

* remove banner and add BannerSection to Page

* removing fragment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

public-docsite: Add more visible banner to v9 docs
3 participants