Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-badge): adopt custom JSX pragma #27603

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-badge

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8821b69:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d340ff4b1c3aa7e1818780ec4d41f46c86e451c9 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-alert
Alert
96.544 kB
23.295 kB
96.425 kB
23.441 kB
-119 B
146 B
react-avatar
Avatar
59.542 kB
15.569 kB
59.494 kB
15.587 kB
-48 B
18 B
react-avatar
AvatarGroup
18.19 kB
6.706 kB
18.223 kB
6.7 kB
33 B
-6 B
react-avatar
AvatarGroupItem
75.803 kB
20.072 kB
75.719 kB
20.079 kB
-84 B
7 B
react-badge
Badge
26.075 kB
7.629 kB
26.099 kB
7.632 kB
24 B
3 B
react-badge
CounterBadge
27.058 kB
7.938 kB
27.084 kB
7.943 kB
26 B
5 B
react-badge
PresenceBadge
34.547 kB
8.726 kB
34.573 kB
8.739 kB
26 B
13 B
react-persona
Persona
67.188 kB
17.737 kB
66.426 kB
17.533 kB
-762 B
-204 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-components
react-components: Button, FluentProvider & webLightTheme
68.69 kB
18.686 kB
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.031 kB
57.838 kB
react-components
react-components: FluentProvider & webLightTheme
38.773 kB
12.375 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-table
DataGrid
151.388 kB
41.247 kB
react-table
Table (Primitives only)
47.03 kB
12.784 kB
react-table
Table as DataGrid
133.952 kB
33.942 kB
react-table
Table (Selection only)
81.863 kB
19.962 kB
react-table
Table (Sort only)
81.193 kB
19.773 kB
🤖 This report was generated against b61892e1d2e6b8bef5b5b1ba22e08247238fb45c

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

Perf Analysis (@fluentui/react-components)

Scenario Render type Master Ticks PR Ticks Iterations Status
InfoButton mount 16 20 5000 Possible regression
All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 685 698 5000
Button mount 384 379 5000
Field mount 1303 1292 5000
FluentProvider mount 933 922 5000
FluentProviderWithTheme mount 115 119 10
FluentProviderWithTheme virtual-rerender 98 92 10
FluentProviderWithTheme virtual-rerender-with-unmount 104 102 10
InfoButton mount 16 20 5000 Possible regression
MakeStyles mount 1127 1188 50000
Persona mount 2038 2013 5000
SpinButton mount 1566 1593 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-badge/chore--adopt-custom-JSX-pragma branch from 1da4f78 to 7667f09 Compare April 18, 2023 10:08
@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 10:58
@bsunderhus bsunderhus requested review from a team and behowell as code owners April 18, 2023 10:58
@bsunderhus bsunderhus enabled auto-merge (squash) April 18, 2023 14:48
@bsunderhus bsunderhus force-pushed the react-badge/chore--adopt-custom-JSX-pragma branch from 7667f09 to 8821b69 Compare April 18, 2023 19:01
@bsunderhus bsunderhus merged commit 477d9f6 into microsoft:master Apr 18, 2023
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants