Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-date-picker-compat): adopt custom JSX pragma #27609

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-date-picker-compat

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: d340ff4b1c3aa7e1818780ec4d41f46c86e451c9 (build)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d31e90f:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-datepicker-compat
DatePicker Compat
222.742 kB
58.93 kB
223.352 kB
59.089 kB
610 B
159 B

🤖 This report was generated against b61892e1d2e6b8bef5b5b1ba22e08247238fb45c

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-date-picker-compat/chore--adopt-custom-JSX-pragma branch from 694272e to 80bf628 Compare April 18, 2023 10:08
@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 10:58
@bsunderhus bsunderhus requested review from a team, sopranopillow and khmakoto as code owners April 18, 2023 10:58
@bsunderhus bsunderhus enabled auto-merge (squash) April 18, 2023 14:49
@bsunderhus bsunderhus force-pushed the react-date-picker-compat/chore--adopt-custom-JSX-pragma branch from 80bf628 to d31e90f Compare April 18, 2023 19:09
@bsunderhus bsunderhus merged commit 59ef51f into microsoft:master Apr 18, 2023
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants