Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(react-drawer): adopt custom JSX pragma #27611

Merged
merged 1 commit into from
Apr 18, 2023
Merged

chore(react-drawer): adopt custom JSX pragma #27611

merged 1 commit into from
Apr 18, 2023

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-drawer

@bsunderhus bsunderhus self-assigned this Apr 18, 2023
@github-actions github-actions bot added this to the April Project Cycle Q2 2023 milestone Apr 18, 2023
@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023 •
edited
Loading

📊 Bundle size report

🤖 This report was generated against 85c36e249b33b0bad79be4edd1a943dfc5233b11

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2d33e33:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023 •
edited
Loading

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 391878bf4d8a8210a8279a6ced8bf9a64daf4c64 (build)

@bsunderhus bsunderhus force-pushed the react-drawer/chore--adopt-custom-JSX-pragma branch from c95c58c to 2d33e33 Compare April 18, 2023 10:08
@bsunderhus bsunderhus mentioned this pull request Apr 18, 2023
Closed
@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 10:43
@bsunderhus bsunderhus requested a review from a team as a code owner April 18, 2023 10:43
@bsunderhus bsunderhus merged commit 3fff8ce into microsoft:master Apr 18, 2023
@bsunderhus bsunderhus deleted the react-drawer/chore--adopt-custom-JSX-pragma branch April 18, 2023 14:49
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
@bsunderhus @marcosmoura
chore(react-drawer): adopt custom JSX pragma (microsoft#27611)
cbcd88c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tudorpopams tudorpopams tudorpopams approved these changes

Assignees

@bsunderhus bsunderhus

Labels
Component: Drawer The Fluent v9 Drawer component Fluent UI react-components (v9)
Projects
None yet
Milestone
April Project Cycle Q2 2023
Development

Successfully merging this pull request may close these issues.
3 participants
@bsunderhus @fabricteam @tudorpopams