Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-image): adopt custom JSX pragma #27613

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-image

@codesandbox-ci
Copy link

codesandbox-ci bot commented Apr 18, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 659dfbd:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 391878bf4d8a8210a8279a6ced8bf9a64daf4c64 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Button, FluentProvider & webLightTheme
68.803 kB
18.728 kB
68.69 kB
18.686 kB
-113 B
-42 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.156 kB
57.857 kB
208.031 kB
57.838 kB
-125 B
-19 B
react-components
react-components: FluentProvider & webLightTheme
38.886 kB
12.41 kB
38.773 kB
12.375 kB
-113 B
-35 B
react-image
Image
14.023 kB
5.008 kB
14.067 kB
5.012 kB
44 B
4 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 85c36e249b33b0bad79be4edd1a943dfc5233b11

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 820 912 5000
Button mount 454 438 5000
Field mount 1552 1501 5000
FluentProvider mount 1089 1059 5000
FluentProviderWithTheme mount 132 140 10
FluentProviderWithTheme virtual-rerender 119 125 10
FluentProviderWithTheme virtual-rerender-with-unmount 127 120 10
InfoButton mount 22 21 5000
MakeStyles mount 1358 1307 50000
Persona mount 2413 2373 5000
SpinButton mount 1916 1911 5000

@fabricteam
Copy link
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 11:22
@bsunderhus bsunderhus requested a review from a team as a code owner April 18, 2023 11:22
@bsunderhus bsunderhus merged commit a6ff855 into microsoft:master Apr 18, 2023
@bsunderhus bsunderhus deleted the react-image/chore--adopt-custom-JSX-pragma branch April 18, 2023 14:50
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants