Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-infobutton): adopt custom JSX pragma #27615

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-infobutton

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-infobutton/chore--adopt-custom-JSX-pragma branch from 3e6477b to 3dd93a9 Compare April 18, 2023 10:08
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 3dd93a9:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-components
react-components: Button, FluentProvider & webLightTheme
68.803 kB
18.728 kB
68.69 kB
18.686 kB
-113 B
-42 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.156 kB
57.857 kB
208.043 kB
57.817 kB
-113 B
-40 B
react-components
react-components: FluentProvider & webLightTheme
38.886 kB
12.41 kB
38.773 kB
12.375 kB
-113 B
-35 B
react-infobutton
InfoButton
131.476 kB
39.787 kB
130.655 kB
39.484 kB
-821 B
-303 B
react-infobutton
InfoLabel
134.77 kB
40.807 kB
134.558 kB
40.673 kB
-212 B
-134 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
🤖 This report was generated against 85c36e249b33b0bad79be4edd1a943dfc5233b11

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 391878bf4d8a8210a8279a6ced8bf9a64daf4c64 (build)

@fabricteam
Copy link
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 830 855 5000
Button mount 460 447 5000
Field mount 1546 1537 5000
FluentProvider mount 1057 1098 5000
FluentProviderWithTheme mount 139 138 10
FluentProviderWithTheme virtual-rerender 117 118 10
FluentProviderWithTheme virtual-rerender-with-unmount 127 129 10
InfoButton mount 27 22 5000
MakeStyles mount 1317 1338 50000
Persona mount 2439 2304 5000
SpinButton mount 1920 1891 5000

@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 11:22
@bsunderhus bsunderhus requested review from a team and sopranopillow as code owners April 18, 2023 11:22
@bsunderhus bsunderhus enabled auto-merge (squash) April 18, 2023 14:50
@bsunderhus bsunderhus merged commit dd76eca into microsoft:master Apr 18, 2023
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants