Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(react-label): adopt custom JSX pragma #27616

Conversation

bsunderhus
Copy link
Contributor

New Behavior

  1. Adopts react-jsx-runtime custom pragma on react-label

@size-auditor
Copy link

size-auditor bot commented Apr 18, 2023

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 391878bf4d8a8210a8279a6ced8bf9a64daf4c64 (build)

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 692 728 5000
Button mount 381 390 5000
Field mount 1286 1306 5000
FluentProvider mount 911 912 5000
FluentProviderWithTheme mount 114 117 10
FluentProviderWithTheme virtual-rerender 103 97 10
FluentProviderWithTheme virtual-rerender-with-unmount 107 102 10
InfoButton mount 15 20 5000
MakeStyles mount 1103 1103 50000
Persona mount 2047 2038 5000
SpinButton mount 1613 1624 5000

@fabricteam
Copy link
Collaborator

fabricteam commented Apr 18, 2023

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus bsunderhus force-pushed the react-label/chore--adopt-custom-JSX-pragma branch from d5a1a5b to 87ce62e Compare April 18, 2023 10:08
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 87ce62e:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam
Copy link
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-checkbox
Checkbox
37.109 kB
11.286 kB
37.795 kB
11.455 kB
686 B
169 B
react-components
react-components: Button, FluentProvider & webLightTheme
68.803 kB
18.728 kB
68.69 kB
18.686 kB
-113 B
-42 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
208.156 kB
57.857 kB
208.043 kB
57.817 kB
-113 B
-40 B
react-components
react-components: FluentProvider & webLightTheme
38.886 kB
12.41 kB
38.773 kB
12.375 kB
-113 B
-35 B
react-datepicker-compat
DatePicker Compat
252.153 kB
67.645 kB
252.021 kB
67.57 kB
-132 B
-75 B
react-field
Field
21.589 kB
7.453 kB
22.277 kB
7.642 kB
688 B
189 B
react-infobutton
InfoButton
131.476 kB
39.787 kB
131.363 kB
39.748 kB
-113 B
-39 B
react-infobutton
InfoLabel
134.77 kB
40.807 kB
134.635 kB
40.682 kB
-135 B
-125 B
react-label
Label
12.657 kB
4.618 kB
12.693 kB
4.626 kB
36 B
8 B
react-radio
Radio
29.921 kB
9.118 kB
30.696 kB
9.312 kB
775 B
194 B
react-spinner
Spinner
23.515 kB
7.226 kB
24.202 kB
7.42 kB
687 B
194 B
react-switch
Switch
32.528 kB
9.73 kB
33.216 kB
9.9 kB
688 B
170 B
react-table
DataGrid
151.536 kB
41.299 kB
151.388 kB
41.247 kB
-148 B
-52 B
react-table
Table (Primitives only)
47.143 kB
12.817 kB
47.03 kB
12.784 kB
-113 B
-33 B
react-table
Table as DataGrid
134.099 kB
34.001 kB
133.952 kB
33.942 kB
-147 B
-59 B
react-table
Table (Selection only)
82.011 kB
20.028 kB
81.863 kB
19.962 kB
-148 B
-66 B
react-table
Table (Sort only)
81.341 kB
19.84 kB
81.193 kB
19.773 kB
-148 B
-67 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
react-combobox
Combobox (including child components)
89.878 kB
28.552 kB
react-combobox
Dropdown (including child components)
88.562 kB
28.275 kB
react-input
Input
26.796 kB
8.148 kB
react-portal-compat
PortalCompatProvider
6.446 kB
2.185 kB
react-progress
ProgressBar
16.409 kB
5.855 kB
react-radio
RadioGroup
13.952 kB
5.163 kB
react-select
Select
28.004 kB
9.223 kB
react-slider
Slider
36.934 kB
11.514 kB
react-spinbutton
SpinButton
36.705 kB
10.792 kB
react-textarea
Textarea
30.203 kB
9.519 kB
🤖 This report was generated against 85c36e249b33b0bad79be4edd1a943dfc5233b11

@bsunderhus bsunderhus marked this pull request as ready for review April 18, 2023 11:06
@bsunderhus bsunderhus enabled auto-merge (squash) April 18, 2023 14:50
@bsunderhus bsunderhus merged commit b61892e into microsoft:master Apr 18, 2023
marcosmoura pushed a commit to marcosmoura/fluentui that referenced this pull request Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants